cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Glen Mazza <glen.ma...@verizon.net>
Subject Re: svn commit: r583017 - /incubator/cxf/trunk/rt/ws/security/src/test/java/org/apache/cxf/ws/security/wss4j/RoundTripTest.java
Date Thu, 11 Oct 2007 23:25:36 GMT
I would tend to agree--ignore + JIRA makes sense.  It is true, when
newbies submit a patch and see failures they don't know if its their
code or something preexisting, and it can cause unnecessary stress.

Glen

Am Dienstag, den 09.10.2007, 09:37 -0400 schrieb Daniel Kulp:
> Honestly,  I'd prefer if this test (and the SequenceTest that keeps 
> randomly failing for me) get @Ignores and a JIRA then logged so it's 
> tracked. 
> 
> Random failures are extremely bad to have.   If someone new (like Glen) 
> tries to make a change and starts seeing failures, they could waste a 
> lot of time trying to figure out why and can easily get discouraged.
> 
> The other problem I have is if the test randomly fails during the "mvn 
> release:prepare" step or "mvn release:perform" step, it's a pain to 
> recover from.
> 
> Dan
> 
> 
> On Monday 08 October 2007, Bozhong Lin wrote:
> > Hi Glen,
> >
> > Do you plan to revisit this later? I never experienced this test hang
> > on SUSE Linux. Instead of ignoring this test, we should fix the test
> > if there is any issue.
> >
> > Cheers,
> > Bo
> >
> > gmazza@apache.org wrote:
> > > Author: gmazza
> > > Date: Mon Oct  8 17:27:03 2007
> > > New Revision: 583017
> > >
> > > URL: http://svn.apache.org/viewvc?rev=583017&view=rev
> > > Log:
> > > Test commit; ignoring one of the tests (does not work with Linux).
> > >
> > > Modified:
> > >    
> > > incubator/cxf/trunk/rt/ws/security/src/test/java/org/apache/cxf/ws/s
> > >ecurity/wss4j/RoundTripTest.java
> > >
> > > Modified:
> > > incubator/cxf/trunk/rt/ws/security/src/test/java/org/apache/cxf/ws/s
> > >ecurity/wss4j/RoundTripTest.java URL:
> > > http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/ws/security/src/
> > >test/java/org/apache/cxf/ws/security/wss4j/RoundTripTest.java?rev=583
> > >017&r1=583016&r2=583017&view=diff
> > > ====================================================================
> > >========== ---
> > > incubator/cxf/trunk/rt/ws/security/src/test/java/org/apache/cxf/ws/s
> > >ecurity/wss4j/RoundTripTest.java (original) +++
> > > incubator/cxf/trunk/rt/ws/security/src/test/java/org/apache/cxf/ws/s
> > >ecurity/wss4j/RoundTripTest.java Mon Oct  8 17:27:03 2007 @@ -100,6
> > > +100,7 @@
> > >          assertEquals("test", echo.echo("test"));
> > >      }
> > >      @Test
> > > +    @Ignore("Seems to randomly hang on Linux")
> > >      public void testUsernameToken() throws Exception {
> > >          String actions = WSHandlerConstants.ENCRYPT + " " +
> > > WSHandlerConstants.SIGNATURE + " " + WSHandlerConstants.TIMESTAMP +
> > > " " + WSHandlerConstants.USERNAME_TOKEN;
> 
> 
> 


Mime
View raw message