cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Kulp <dk...@apache.org>
Subject Re: svn commit: r573082 - in/incubator/cxf/trunk/rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/namespaces: ./ NamespaceConfusionTest.java data/ data/Name.java impl/impl/NameServiceImpl.java intf/ intf/NameService.java
Date Thu, 06 Sep 2007 14:58:37 GMT

Will do.   My next commit will have the comment.

Thanks!
Dan


On Wednesday 05 September 2007, Benson Margulies wrote:
> That's fair. Dan, instead of going through the jira-to-you-to-svn pass
> again, how about you add the following javadoc to the class ...
>
> /**
>   * Regression test for CXF-959. This is a point test for consistent
> use of
>   * namespace prefixes in generated WSDL/XMLSchema. This test could
>   * be made into a more comprehensive functional test by exercising
> cases
>   * such as multiple schema.
>   */
>
> > -----Original Message-----
> > From: Glen Mazza [mailto:glen.mazza@verizon.net]
> > Sent: Wednesday, September 05, 2007 6:20 PM
> > To: cxf-dev@incubator.apache.org
> > Subject: Re: svn commit: r573082 -
>
> in/incubator/cxf/trunk/rt/databinding/aegis/src/test/java/org/apache/c
>xf /a
>
> > egis/namespaces: ./ NamespaceConfusionTest.java data/ data/Name.java
> > impl/impl/NameServiceImpl.java intf/ intf/NameService.java
> >
> > Am Mittwoch, den 05.09.2007, 21:59 +0000 schrieb dkulp@apache.org:
> > > Author: dkulp
> > > Date: Wed Sep  5 14:59:07 2007
> > > New Revision: 573082
> > >
> > > URL: http://svn.apache.org/viewvc?rev=573082&view=rev
> > > Log:
> > > [CXF-959] Add testcase provided by Benson Margulies
> > >
> > > +
> > > +public class NamespaceConfusionTest extends AbstractAegisTest {
> > > +
> >
> > I think it would be nice to have a comment for this class explaining
> > what it does/what it is for.  By name alone, I don't think it is
> > sufficiently evident to the reader (at least not this one.)
> >
> > Glen



-- 
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727    C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog

Mime
View raw message