Return-Path: Delivered-To: apmail-incubator-cxf-dev-archive@locus.apache.org Received: (qmail 53424 invoked from network); 1 Aug 2007 19:29:34 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 1 Aug 2007 19:29:34 -0000 Received: (qmail 23630 invoked by uid 500); 1 Aug 2007 19:29:34 -0000 Delivered-To: apmail-incubator-cxf-dev-archive@incubator.apache.org Received: (qmail 23580 invoked by uid 500); 1 Aug 2007 19:29:33 -0000 Mailing-List: contact cxf-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cxf-dev@incubator.apache.org Delivered-To: mailing list cxf-dev@incubator.apache.org Received: (qmail 23571 invoked by uid 99); 1 Aug 2007 19:29:33 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Aug 2007 12:29:33 -0700 X-ASF-Spam-Status: No, hits=2.6 required=10.0 tests=FM_FAKE_HELO_VERIZON,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of glen.mazza@verizon.net designates 206.46.252.42 as permitted sender) Received: from [206.46.252.42] (HELO vms042pub.verizon.net) (206.46.252.42) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Aug 2007 19:29:05 +0000 Received: from [192.168.1.43] ([70.17.116.113]) by vms042.mailsrvcs.net (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTPA id <0JM400CPG0S5EOS3@vms042.mailsrvcs.net> for cxf-dev@incubator.apache.org; Wed, 01 Aug 2007 14:28:54 -0500 (CDT) Date: Wed, 01 Aug 2007 15:28:55 -0400 From: Glen Mazza Subject: Re: svn commit: r561871 - in /incubator/cxf/trunk/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/generators: AntGenerator.java ClientGenerator.java ServerGenerator.java In-reply-to: <200708011500.47247.dkulp@apache.org> To: cxf-dev@incubator.apache.org Message-id: <1185996535.785.0.camel@gmazza-desktop> MIME-version: 1.0 X-Mailer: Evolution 2.10.1 Content-type: text/plain Content-transfer-encoding: 7bit References: <20070801170453.BE9DA1A981C@eris.apache.org> <1185990267.27438.6.camel@gmazza-desktop> <200708011500.47247.dkulp@apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Oops! How could I have missed that? Glen Am Mittwoch, den 01.08.2007, 15:00 -0400 schrieb Daniel Kulp: > Glen, > > On Wednesday 01 August 2007 13:44, Glen Mazza wrote: > > > + String interfaceName = jp.getInterfaceClass(); > > > (A) JavaInterface intf = > > > interfaces.get(interfaceName); (B)+ if (intf == null) > > > { > > > (C)+ interfaceName = jp.getPortType(); > > > (D)+ intf = interfaces.get(interfaceName); > > > (E)+ } > > > > There may be a bug here (and in the two cases below). Namely, I can't > > see the reason for statement (D) above. If (A) results in intf being > > set to NULL, lines (B) - (E) will be activated. But how can statement > > (D) set intf to anything but null again--statement (C) has no side > > effect in adding interface names to the interfaces object. > > Line (C) results in a new value for interfaceName which results in a new > value being used to lookup stuff from the interfaces Map. The map > doesn't change, the lookup key does. > >