Return-Path: Delivered-To: apmail-incubator-cxf-dev-archive@locus.apache.org Received: (qmail 69428 invoked from network); 1 Aug 2007 12:33:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 1 Aug 2007 12:33:08 -0000 Received: (qmail 59447 invoked by uid 500); 1 Aug 2007 12:33:08 -0000 Delivered-To: apmail-incubator-cxf-dev-archive@incubator.apache.org Received: (qmail 59383 invoked by uid 500); 1 Aug 2007 12:33:08 -0000 Mailing-List: contact cxf-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cxf-dev@incubator.apache.org Delivered-To: mailing list cxf-dev@incubator.apache.org Received: (qmail 59373 invoked by uid 99); 1 Aug 2007 12:33:07 -0000 Received: from Unknown (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Aug 2007 05:33:07 -0700 X-ASF-Spam-Status: No, hits=2.6 required=10.0 tests=FM_FAKE_HELO_VERIZON,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of glen.mazza@verizon.net designates 206.46.252.40 as permitted sender) Received: from [206.46.252.40] (HELO vms040pub.verizon.net) (206.46.252.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Aug 2007 12:32:58 +0000 Received: from [192.168.1.43] ([70.17.116.113]) by vms040.mailsrvcs.net (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTPA id <0JM300FSRHIDVHQ2@vms040.mailsrvcs.net> for cxf-dev@incubator.apache.org; Wed, 01 Aug 2007 07:32:37 -0500 (CDT) Date: Wed, 01 Aug 2007 08:32:37 -0400 From: Glen Mazza Subject: Re: svn commit: r561354 - in /incubator/cxf/trunk/rt/frontend/jaxws/src: main/java/org/apache/cxf/jaxws/ main/resources/schemas/ test/java/org/apache/cxf/jaxws/spring/ In-reply-to: <7b774c950707310902q467d3153t19c4443667ca943@mail.gmail.com> To: cxf-dev@incubator.apache.org Message-id: <1185971557.13023.2.camel@gmazza-desktop> MIME-version: 1.0 X-Mailer: Evolution 2.10.1 Content-type: text/plain Content-transfer-encoding: 7bit References: <20070731150356.688E51A981A@eris.apache.org> <1185895728.11812.66.camel@gmazza-desktop> <7b774c950707310902q467d3153t19c4443667ca943@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org I see. Thanks for the explanation. Glen Am Dienstag, den 31.07.2007, 12:02 -0400 schrieb Dan Diephouse: > Glen: The point of that part of the test is to find an endpoint in the > spring context which has had an id auto-generated. The > EndpointDefinitionParser generate spring ids of the form " > org.apache.cxf.jaxws.EndpointImpl" + hashCode(). So that part of the test is > looking for a spring id which starts with EndpointImpl (we don't know the > hashcode so we can't search for that). > > Cheers, > - Dan > > On 7/31/07, Glen Mazza wrote: > > > > Am Dienstag, den 31.07.2007, 15:03 +0000 schrieb dandiep@apache.org: > > > Author: dandiep > > > Date: Tue Jul 31 08:03:43 2007 > > > New Revision: 561354 > > > > > > Modified: > > incubator/cxf/trunk/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/spring/SpringBeansTest.java > > > URL: > > http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/spring/SpringBeansTest.java?view=diff&rev=561354&r1=561353&r2=561354 > > > > > ============================================================================== > > > --- > > incubator/cxf/trunk/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/spring/SpringBeansTest.java > > (original) > > > +++ > > incubator/cxf/trunk/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/spring/SpringBeansTest.java > > Tue Jul 31 08:03:43 2007 > > > @@ -85,6 +85,12 @@ > > > ep = (EndpointImpl) bean; > > > assertTrue(ep.getInvoker() instanceof NullInvoker); > > > assertTrue(ep.getService().getInvoker() instanceof > > NullInvoker); > > > + > > > + bean = ctx.getBean("implementorClass"); > > > + assertNotNull(bean); > > > + ep = (EndpointImpl) bean; > > > + assertEquals(Hello.class, ep.getImplementorClass()); > > > + assertTrue(ep.getImplementor().getClass() == Object.class); > > > > > > bean = ctx.getBean("epWithProps"); > > > assertNotNull(bean); > > > @@ -109,6 +115,21 @@ > > > bean = ctx.getBean("wsdlLocation"); > > > assertNotNull(bean); > > > > > > + // test for existence of Endpoint without an id element > > > + boolean found = false; > > > + String[] names = ctx.getBeanNamesForType(EndpointImpl.class); > > > + for (String n : names) { > > > + if (n.startsWith(EndpointImpl.class.getName())) { > > > + found = true; > > > + } > > > + } > > > > If there is a bean named "FooBar" and I'm searching for an Endpoint > > named "Foo", wouldn't the above incorrectly set found = true because of > > the startWith() (instead of equals())? > > > > Thanks, > > Glen > > > > > > > >