Mailing-List: contact cxf-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cxf-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: domain of james.mao@iona.com designates
 12.170.54.180 as permitted sender)
Message-ID: <468320C1.9070606@iona.com>
Date: Thu, 28 Jun 2007 10:45:21 +0800
From: James Mao <james.mao@iona.com>
User-Agent: Thunderbird 1.5.0.12 (Windows/20070509)
MIME-Version: 1.0
To: cxf-dev@incubator.apache.org
Subject: Re: svn commit: r551110 - in
 /incubator/cxf/trunk:	api/src/main/java/org/apache/cxf/service/
 rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/
	rt/frontend/simple/src/main/java/org/apache/cxf/frontend/
 tools/javato/core/src/main/java/org/apache/cxf/tool...
References: <20070627095754.81BAD1A981A@eris.apache.org>
 <1182952131.9430.21.camel@gmazza-desktop>
In-Reply-To: <1182952131.9430.21.camel@gmazza-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Glen,

Excellent catch!

The reason tools ignore the service class implement the java.rmi.Remote 
is that we don't support it in the runtime.
And the reason that we throw exceptions, is that in other project 
(especially the Eclipse STP)  would like to catch such exception.
I know in tools we should have a concept of warnings and errors, but 
that will be another story.

James

> Am Mittwoch, den 27.06.2007, 09:57 +0000 schrieb mmao@apache.org:
>   
>> Author: mmao
>> Date: Wed Jun 27 02:57:53 2007
>> New Revision: 551110
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=551110
>> Log:
>> Java2Wsdl validate the service class before generating the artifacts
>> * In jaxws case, it will fail if the srevice class extends/implement from the java.rmi.Remote
>>
>>
>>     
>
> I wonder if a warning "this interface is ignored by JAXWS" instead of an
> exception would be preferable.  While I understand the java.rmi.Remote
> interface is not used by JAXWS, I'm unsure why forbidding it is
> necessary (or even encouraged by the spec), it's just a marker interface
> that is ignored in JAXWS.  That service class might also be implementing
> 15 other things that CXF will ignore--why worry about java.rmi.Remote in
> particular?
>
>
>   
>> -            throw new ToolException("Can not find the ServiceBulider
>> for style: " + s, e);
>> +            throw new ToolException("Can not find or initialize the ServiceBulider for style: " + s
>> +                                    + " Reason: \n" + e.getMessage(),
>> +                                    e);
>>     
>
> "ServiceBuilder"
>
> Glen
>
>
>