Return-Path: Delivered-To: apmail-incubator-cxf-dev-archive@locus.apache.org Received: (qmail 89488 invoked from network); 17 May 2007 04:17:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 May 2007 04:17:22 -0000 Received: (qmail 32018 invoked by uid 500); 17 May 2007 04:17:27 -0000 Delivered-To: apmail-incubator-cxf-dev-archive@incubator.apache.org Received: (qmail 31974 invoked by uid 500); 17 May 2007 04:17:27 -0000 Mailing-List: contact cxf-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cxf-dev@incubator.apache.org Delivered-To: mailing list cxf-dev@incubator.apache.org Received: (qmail 31965 invoked by uid 99); 17 May 2007 04:17:27 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 May 2007 21:17:27 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of ning.jiang@iona.com designates 65.223.216.181 as permitted sender) Received: from [65.223.216.181] (HELO amereast-smg1.iona.com) (65.223.216.181) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 May 2007 21:17:20 -0700 Received: from amer-ems1.IONAGLOBAL.COM ([10.65.6.25]) by amereast-smg1.iona.com (Switch-3.1.7/Switch-3.1.7) with ESMTP id l4H4Fse5014288 for ; Thu, 17 May 2007 00:15:54 -0400 (EDT) Received: from [127.0.0.1] ([10.129.9.181]) by amer-ems1.IONAGLOBAL.COM with Microsoft SMTPSVC(6.0.3790.1830); Thu, 17 May 2007 00:16:55 -0400 Message-ID: <464BD6FC.8020902@iona.com> Date: Thu, 17 May 2007 12:15:56 +0800 From: Willem Jiang User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) MIME-Version: 1.0 To: cxf-dev@incubator.apache.org Subject: Re: Proper destroy() method for jaxws:endpoint References: <05F5FDC16A447442B12B21A432878AC501029AD6@amer-ems1.IONAGLOBAL.COM> In-Reply-To: <05F5FDC16A447442B12B21A432878AC501029AD6@amer-ems1.IONAGLOBAL.COM> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 17 May 2007 04:16:58.0203 (UTC) FILETIME=[35D512B0:01C7983A] X-Virus-Checked: Checked by ClamAV on apache.org Hi Seumas, Soltysik, Seumas wrote: > The current designated destroy method for the jaxws:endpoint spring bean is EndpointImpl.stop(). The effect of calling this stop() method is to remove the endpoint from an endpoints list. > > if (mo instanceof MultipleEndpointObserver) { > ((MultipleEndpointObserver) mo).getEndpoints().remove(endpoint); > } else { > getDestination().setMessageObserver(null); > } > > However, it does not actually shutdown/deactive the associated Destination it only diables the endpoint. I am not sure that this makes sense to me. When the destroy method is called on the jaxws:endpoint bean, should the endpoint simply be made unavailable or should the infrastructure for that endpoint be torn down? > > Maybe DanD can answer this question. I just checked out the change log of MultipleEndpointObserver MutlipleEndpointObserver. If multiple a user attempts to register multiple endpoints on the same address, this observer will be created. Various binding interceptors and routing interceptors will be added to it. Does it mean that the endpoints within the MultipleEndpointObserver could still listen to the other address? > Should the EndpointImpl.stop() method be changed to deactivate the Destination or does it need to keep the same behavior per the JAX-WS spec? Do we need to add a special EndpointImpl.shutdown() method and use this as the jaxws:endpoint destroy() method? > > Regards, > Seumas > > Cheers, Willem.