cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrea Smyth <andrea.sm...@iona.com>
Subject Re: svn commit: r540413 - in /incubator/cxf/trunk/distribution/src/main/release/samples: common_build.xml hello_world/build.xml hello_world/src/demo/hw/client/Client.java hello_world/src/demo/hw/server/Server.java
Date Tue, 22 May 2007 11:00:38 GMT
VALIDATION_AUTO is in fact Spring's default, and that's what the 
BusApplication context leaves it at unless a system property is specified.
We don't know anything about the performance impact of schema validation 
yet;  if this turns out to be significant the bus application context 
should revert to VAIDATION_NONE.
Buggy schemas and cfg files however are not a reason to revert IMO - 
they should be fixed so there is no need to explicitly change the 
validation mode.

Andrea.
 

James Mao wrote:

> I mean VALIDATION_NONE should be a default value right? you can 
> explicitly turn it on if you want to validation.
> And the reason is for performance.
> I'm not sure if it's a valid request, just my personal opinion.
>
> James
>
>
>> Once schemas and cfg files are fixed that (i.e. the explicit setting 
>> of spring.validation.mode to VALIDATION_NONE in maven and pom build 
>> files) will not be necessary any more - unless someone wants to 
>> disable validation for performance reasons.
>>
>> Andrea.
>>
>> James Mao wrote:
>>
>>> Is possible to set the spring.validation.mode to VALIDATION_NONE as 
>>> default in the Runtime?
>>> So in the client/server and tools you don't need to set the property
>>> IMO, this is really a redundant step for all users.
>>>
>>>
>>> James
>>>
>>>
>>>> Author: ffang
>>>> Date: Mon May 21 21:09:22 2007
>>>> New Revision: 540413
>>>>
>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=540413
>>>> Log:
>>>> [CXF-668] provide a way to let demo specify spring validation mode 
>>>> to get hello_world demo working
>>>>
>>>> Modified:
>>>>     
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/common_build.xml

>>>>
>>>>     
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/build.xml

>>>>
>>>>     
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/client/Client.java

>>>>
>>>>     
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/server/Server.java

>>>>
>>>>
>>>> Modified: 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/common_build.xml

>>>>
>>>> URL: 
>>>> http://svn.apache.org/viewvc/incubator/cxf/trunk/distribution/src/main/release/samples/common_build.xml?view=diff&rev=540413&r1=540412&r2=540413

>>>>
>>>> ==============================================================================

>>>>
>>>> --- 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/common_build.xml

>>>> (original)
>>>> +++ 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/common_build.xml

>>>> Mon May 21 21:09:22 2007
>>>> @@ -200,13 +200,14 @@
>>>>                  </not>
>>>>              </condition>
>>>>              <property name="binding.arg" value=""/>
>>>> -
>>>> +        <property name="spring.validation.mode" 
>>>> value="VALIDATION_AUTO"/>
>>>>              <java failonerror="true" 
>>>> classname="org.apache.cxf.tools.wsdlto.WSDLToJava" fork="yes">
>>>>                  <classpath>
>>>>                      <path refid="cxf.classpath" />
>>>>                  </classpath>
>>>>                  <sysproperty key="java.util.logging.config.file" 
>>>> value="${cxf.etc.dir}/logging.properties"/>
>>>>                  <sysproperty key="exitOnFinish" value="true"/>
>>>> +                <sysproperty key="spring.validation.mode" 
>>>> value="${spring.validation.mode}"/>
>>>>                  <arg line="@{servicename.arg}"/>
>>>>                  <arg line="${package.arg.@{file}}"/>
>>>>                  <arg line="${binding.arg}"/>
>>>>
>>>> Modified: 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/build.xml

>>>>
>>>> URL: 
>>>> http://svn.apache.org/viewvc/incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/build.xml?view=diff&rev=540413&r1=540412&r2=540413

>>>>
>>>> ==============================================================================

>>>>
>>>> --- 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/build.xml

>>>> (original)
>>>> +++ 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/build.xml

>>>> Mon May 21 21:09:22 2007
>>>> @@ -44,6 +44,7 @@
>>>>               <target name="generate.code">
>>>>          <echo level="info" message="Generating code using 
>>>> wsdl2java..."/>
>>>> +        <property name="spring.validation.mode" 
>>>> value="VALIDATION_NONE"/>
>>>>          <wsdl2java file="hello_world.wsdl"/>
>>>>      </target>
>>>>  
>>>>
>>>> Modified: 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/client/Client.java

>>>>
>>>> URL: 
>>>> http://svn.apache.org/viewvc/incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/client/Client.java?view=diff&rev=540413&r1=540412&r2=540413

>>>>
>>>> ==============================================================================

>>>>
>>>> --- 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/client/Client.java

>>>> (original)
>>>> +++ 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/client/Client.java

>>>> Mon May 21 21:09:22 2007
>>>> @@ -52,6 +52,7 @@
>>>>          }
>>>>                   System.out.println(wsdlURL);
>>>> +        System.setProperty("spring.validation.mode", 
>>>> "VALIDATION_NONE");
>>>>          SOAPService ss = new SOAPService(wsdlURL, SERVICE_NAME);
>>>>          Greeter port = ss.getSoapPort();
>>>>          String resp;
>>>> Modified: 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/server/Server.java

>>>>
>>>> URL: 
>>>> http://svn.apache.org/viewvc/incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/server/Server.java?view=diff&rev=540413&r1=540412&r2=540413

>>>>
>>>> ==============================================================================

>>>>
>>>> --- 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/server/Server.java

>>>> (original)
>>>> +++ 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/server/Server.java

>>>> Mon May 21 21:09:22 2007
>>>> @@ -25,7 +25,7 @@
>>>>  
>>>>      protected Server() throws Exception {
>>>>          System.out.println("Starting Server");
>>>> -
>>>> +        System.setProperty("spring.validation.mode", 
>>>> "VALIDATION_NONE");
>>>>          Object implementor = new GreeterImpl();
>>>>          String address = 
>>>> "http://localhost:9000/SoapContext/SoapPort";
>>>>          Endpoint.publish(address, implementor);
>>>>
>>>>
>>>>
>>>>   
>>>
>>>
>>>
>>
>>
>


Mime
View raw message