Mailing-List: contact cxf-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cxf-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: domain of eoghan.glynn@iona.com
 designates 62.221.12.33 as permitted sender)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Subject: RE: Small problem with testutil-common post move to Junit4
Date: Fri, 16 Mar 2007 14:01:54 -0000
Message-ID: <FA1787F64A095C4090E76EBAF8B183E071FCB7@emea-ems1.IONAGLOBAL.com>
In-Reply-To: <1D195F515BDFE04EA40FA8D046308D6A03027C@emea-ems1.IONAGLOBAL.com>
Thread-Topic: Small problem with testutil-common post move to Junit4
Thread-Index: Acdnx8kesr8MAENpSMGOH8ZkbefSmQAC/JHw
From: "Glynn, Eoghan" <eoghan.glynn@iona.com>
To: <cxf-dev@incubator.apache.org>


Thanks Gary, I've just committed this ...

/Eoghan=20

> -----Original Message-----
> From: Tully, Gary [mailto:Gary.Tully@iona.com]=20
> Sent: 16 March 2007 12:36
> To: cxf-dev@incubator.apache.org
> Subject: Small problem with testutil-common post move to Junit4
>=20
>=20
> Hi,
> I have found a small problem with the default initialization=20
> of the member variable 'bus', in=20
> AbstractBusClientServerTestBase. The result is that an @After=20
> annotated method shuts down 'bus' if it is not null. This=20
> means that if a @BeforeClass initialises the staticBus, after=20
> the first test run, it will be shutdown leaving nothing for=20
> the @AfterClass method and ensuring that a new default bus is=20
> created by the runtime for subsequent tests, which is=20
> contrary to the use of a static bus. The staticBus can be=20
> resolved via BusFactory because it is set as the defaultBus,=20
> so there does not seem to be a need for the default=20
> initialisation of 'bus'.
>=20
> The fix below sorts out the problem. All tests pass with this change.
>=20
> Can someone commit the for me?
>=20
> Thanks,
> Gary.
>=20
>=20
> svn diff
> testutils\src\main\java\org\apache\cxf\testutil\common\Abstrac
> tBusClient
> ServerTestBase.java
> Index:
> testutils/src/main/java/org/apache/cxf/testutil/common/Abstrac
> tBusClient
> ServerTestBase.java
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> ---
> testutils/src/main/java/org/apache/cxf/testutil/common/Abstrac
> tBusClient
> ServerTestBase.java (revision 518934)
> +++
> testutils/src/main/java/org/apache/cxf/testutil/common/Abstrac
> tBusClient
> ServerTestBase.java (working copy)
> @@ -44,7 +44,7 @@
>      protected static Bus staticBus;
>=20
>      protected String configFileName =3D defaultConfigFileName;
> -    protected Bus bus =3D staticBus;
> +    protected Bus bus;
>=20
>      public void createBus(String config) throws Exception {
>          configFileName =3D config;
>=20