Mailing-List: contact cxf-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cxf-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: domain of eoghan.glynn@iona.com
 designates 62.221.12.33 as permitted sender)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: quoted-printable
Subject: RE: Patch for JIRA https://issues.apache.org/jira/browse/CXF-398
Date: Thu, 1 Feb 2007 10:16:08 -0000
Message-ID: <FA1787F64A095C4090E76EBAF8B183E071FBBB@owa-emea.iona.com>
Thread-Topic: Patch for JIRA https://issues.apache.org/jira/browse/CXF-398
Thread-Index: AcdF5hlk7kHCHCGgTE6OiP9mAM0VugAAmVPQ
From: "Glynn, Eoghan" <eoghan.glynn@iona.com>
To: <cxf-dev@incubator.apache.org>


Hi Sergey,

I can apply this patch.

However there is one small issue that needs to be fixed first.=20

Unfortunately our HTTP stacks are reproducing apace, and we already have
three separate stacks with large-scale code duplication across each :(
This oviously needs to be fixed, and I've raised it on cxf-dev & in
JIRA, but in the meantime all changes to HTTP logic need to be
duplicated across the http, http2 and javaws modules (in the jaxws case,
it's the ServletDestination.java that you'll need to update).

Can you do this for your change to the reponse content-type handling and
re-submit the patch?

Cheers,
Eoghan

> -----Original Message-----
> From: Sergey Beryozkin [mailto:sergey.beryozkin@iona.com]=20
> Sent: 01 February 2007 09:49
> To: cxf-dev@incubator.apache.org
> Subject: Patch for JIRA https://issues.apache.org/jira/browse/CXF-398
>=20
> Hi
>=20
> Resending the message describibng the patch under the more=20
> appropriate subject
>=20
> https://issues.apache.org/jira/browse/CXF-398
>=20
> Summary of changes as listed in that Jira issue :
>=20
> * org.apache.cxf.binding.xml.XMLBindingFactory updated to add=20
> AttachmentInInterceptor to created bindings
> * org.apache.cxf.jaxws.ProviderChainObserver.onMessage() adds=20
> AttachmentInInterceptor unless Provider's type parameter is=20
> DataSource or SourceMessage
> * org.apache.cxf.jaxws.support.ContextPropertiesMappping=20
> converts Message.getAttachments into Map<String, DataHandler>=20
> as per JAXWS spec
> * org.apache.cxf.jaxws.interceptors.DispatchInInterceptor=20
> skips GET requets
> * org.apache.cxf.jaxws.interceptors.DispatchOutInterceptor=20
> closes DataSource input stream after copying the data to output stream
> * org.apache.cxf.jaxws.transports.http.JettyHTTPDestination=20
> updated not to duplicate response Content-Type and honour=20
> Content-Type property if set in Provider implementations
> * Updated org.apache.cxf.jaxb.io.XMLMessageDataReader to try=20
> to read even if InputStream.available() shows 0, as it's not=20
> a reliable indication that the stream can not fetch more data
>=20
> Tests added
>=20
> More details can be found in the issue's comments
>=20
> Please apply the patch once it's evaluated
>=20
> Thanks, Sergey
>=20