Return-Path: Delivered-To: apmail-incubator-cxf-dev-archive@locus.apache.org Received: (qmail 61266 invoked from network); 11 Jan 2007 17:44:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 11 Jan 2007 17:44:38 -0000 Received: (qmail 58575 invoked by uid 500); 11 Jan 2007 17:44:44 -0000 Delivered-To: apmail-incubator-cxf-dev-archive@incubator.apache.org Received: (qmail 58539 invoked by uid 500); 11 Jan 2007 17:44:43 -0000 Mailing-List: contact cxf-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cxf-dev@incubator.apache.org Delivered-To: mailing list cxf-dev@incubator.apache.org Received: (qmail 58530 invoked by uid 99); 11 Jan 2007 17:44:43 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jan 2007 09:44:43 -0800 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: local policy) Received: from [64.233.184.233] (HELO wr-out-0506.google.com) (64.233.184.233) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jan 2007 09:44:33 -0800 Received: by wr-out-0506.google.com with SMTP id i22so364371wra for ; Thu, 11 Jan 2007 09:44:12 -0800 (PST) Received: by 10.90.86.10 with SMTP id j10mr1240185agb.1168537452782; Thu, 11 Jan 2007 09:44:12 -0800 (PST) Received: by 10.90.63.13 with HTTP; Thu, 11 Jan 2007 09:44:12 -0800 (PST) Message-ID: <7b774c950701110944u5db75d1foddeb815d2fdd61f5@mail.gmail.com> Date: Thu, 11 Jan 2007 12:44:12 -0500 From: "Dan Diephouse" To: cxf-dev@incubator.apache.org Subject: Re: Identification of Partial Responses In-Reply-To: <7b774c950701110930m792c8e8q14b0e83481985a3e@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_24351_32879674.1168537452663" References: <7b774c950701110930m792c8e8q14b0e83481985a3e@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_24351_32879674.1168537452663 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline A quick question about the two way case - if its already decoupled, why can't the server sent out a at some point during the two way operation. For instance we have this scenario - A sends message to B - B takes an hour before it sends its response back to A - During this time B sends a one way SequenceAcknowledgement to A so as to avoid resends Thanks, - Dan On 1/11/07, Dan Diephouse wrote: > > > > On 1/11/07, Glynn, Eoghan wrote: > > > > > > > 1. Remove isPartialResposne from HTTPConduit - this logic > > > isn't right as it depends on a certain HTTP response code. I > > > think the best way to test to see if we have a response > > > message is to just check and see if the contentType is null. > > > If it isn't, there is a message. If it is null, then there is > > > no message. > > > > Well, null content-type or zero content-length, not sure which is most > > general and reliable indicator. > > > > Currently the logic is reponseCode == 202 && contentLenght != 0, so we > > could simplify this to contentLenght != 0, or check for null-ness of the > > content-type instead as you suggest. > > > Content-Length will often times not be set though as many people need to > do a chunked responses. > > > 2. RM logic shouldn't need anything special now, just > > > recognition of a in response to a > > > one way message. > > > > Remember the SequenceAcknowledgement could also be in a partial response > > to a twoway request (case B as described in an earlier mail on this > > thread). > > > > 3. Remove isPartialResposne from ClientImpl. This call is > > > really superflous as we are going to return as soon as the > > > one way message is sent anyway - we aren't blocking for a > > > response since we check for isOneWay on line 160. We should > > > also change our logic so that we only look for response > > > objects if the call is one way. > > > > Are you assuming that partial responses are only sent for oneways? > > > > If that were the case, then the full/partial response recognition issue > > would indeed go away. > > > > But alas, case B requires that twoway requests may also attract partial > > responses. In this case, we would indeed be waiting for a full response > > in ClientImpl, so we need to be able to make the distinction between > > full and partial responses in ClientImpl, so I can't see how the > > ClientImpl.isPartialResponse() logic is superfluous. > > > > Recall the issue that got this whole discussion started ... > > distinguishing a partial and full response to a bare doc/lit *twoway* > > operation with void return type. The is empty in both > > responses, hence the need to distinguish in some other way. > > > > Ah shit, forgot about the two way case. > > *heads back to drawing board* > > -- > Dan Diephouse > Envoi Solutions > http://envoisolutions.com | http://netzooid.com/blog > -- Dan Diephouse Envoi Solutions http://envoisolutions.com | http://netzooid.com/blog ------=_Part_24351_32879674.1168537452663--