Mailing-List: contact cxf-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cxf-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: domain of Ning.Jiang@iona.com designates
 65.223.216.181 as permitted sender)
Message-ID: <45B108ED.7060007@iona.com>
Date: Fri, 19 Jan 2007 13:07:41 -0500
From: Willem Jiang <ning.jiang@iona.com>
User-Agent: Thunderbird 1.5.0.9 (Windows/20061207)
MIME-Version: 1.0
To: cxf-dev@incubator.apache.org
Subject: Re: svn commit: r497869 -
 /incubator/cxf/trunk/rt/transports/http2/src/main/java/org/apache/cxf/transport/http/JettyHTTPDestination.java
References: <FA1787F64A095C4090E76EBAF8B183E071FB95@owa-emea.iona.com>
In-Reply-To: <FA1787F64A095C4090E76EBAF8B183E071FB95@owa-emea.iona.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hi Eoghan,

The duplication in http transports is because I don't want the
development of the Jetty6 support takes effect to the current code base.

Since Jetty6 's ssl support is in pre-alpha state , we don't want to
replace Jetty5 with Jetty6 right now, I agree we can move the Jetty6
supporting from rt-tranpsorts-http2 to rt-transports-http to reduce the
duplication, and get CXF http-transport more flexible.

Cheers,

Willem.

Glynn, Eoghan wrote:
> Hi Willem,
>
> Why all the duplication in rt-transports-http2?
>
> If we're going to keep the Jetty5-based rt-transports-http stuff, then
> the two modules should be merged so as to avoid duplication, with common
> code factored up into abstract base classes.
>
> I've raised an JIRA task for a similar refactoring of the
> duplication-heavy servlet code:
> http://issues.apache.org/jira/browse/CXF-343
>
> Cheers,
> Eoghan
>
>   
>> -----Original Message-----
>> From: ningjiang@apache.org [mailto:ningjiang@apache.org] 
>> Sent: 19 January 2007 16:48
>> To: cxf-commits@incubator.apache.org
>> Subject: svn commit: r497869 - 
>> /incubator/cxf/trunk/rt/transports/http2/src/main/java/org/apa
>> che/cxf/transport/http/JettyHTTPDestination.java
>>
>> Author: ningjiang
>> Date: Fri Jan 19 08:47:39 2007
>> New Revision: 497869
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=497869
>> Log:
>> Get the ?wsdl work again
>>
>> Modified:
>>     
>> incubator/cxf/trunk/rt/transports/http2/src/main/java/org/apac
>> he/cxf/transport/http/JettyHTTPDestination.java
>>
>> Modified: 
>> incubator/cxf/trunk/rt/transports/http2/src/main/java/org/apac
>> he/cxf/transport/http/JettyHTTPDestination.java
>> URL: 
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/transports
>> /http2/src/main/java/org/apache/cxf/transport/http/JettyHTTPDe
>> stination.java?view=diff&rev=497869&r1=497868&r2=497869
>> ==============================================================
>> ================
>> --- 
>> incubator/cxf/trunk/rt/transports/http2/src/main/java/org/apac
>> he/cxf/transport/http/JettyHTTPDestination.java (original)
>> +++ 
>> incubator/cxf/trunk/rt/transports/http2/src/main/java/org/apache/cxf
>> +++ /transport/http/JettyHTTPDestination.java Fri Jan 19 08:47:39 2007
>> @@ -253,7 +253,8 @@
>>              return;
>>          }
>>  
>> -        if ("GET".equals(req.getMethod()) && 
>> req.getRequestURI().toString().toLowerCase().endsWith("?wsdl")) {
>> +        if ("GET".equals(req.getMethod()) && 
>> req.getQueryString() != null 
>> +            && req.getQueryString().toLowerCase().equals("wsdl")) {
>>              try {
>>  
>>                  
>> resp.addHeader(HttpHeaderHelper.CONTENT_TYPE, "text/xml");
>>
>>
>>
>>     
>
>