Mailing-List: contact cxf-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cxf-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: domain of Ning.Jiang@iona.com designates
 65.223.216.181 as permitted sender)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="----_=_NextPart_001_01C724FF.6F10ADB3"
Subject: =?gb2312?B?tPC4tDogUE1EIGlzc3VlIFt3YXMgUmU6IHN2biBjb21taXQ6IHI0OA==?=
	=?gb2312?B?ODk0OCBbMS8zXV0=?=
Date: Thu, 21 Dec 2006 07:55:16 -0500
Message-ID: <9A4696F35B459043970EE4A85A31739002549F@amer-ems1.IONAGLOBAL.COM>
Thread-Topic: PMD issue [was Re: svn commit: r488948 [1/3]]
Thread-Index: Acck4AIqvEtfoJ61T8uYk3qdWV6lHwAH0DLd
References: <7b774c950612200024n78bfab1dm8ffbbd3fbdc27247@mail.gmail.com>
 <458A4291.9010707@iona.com> <458A4F2C.8010506@iona.com>
From: "Jiang, Ning \(Willem\)" <Ning.Jiang@iona.com>
To: <cxf-dev@incubator.apache.org>

------_=_NextPart_001_01C724FF.6F10ADB3
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable


The question is exception build need to call the Message's toString() =
method.

:)

-----Original Message-----
From: James Mao [mailto:james.mao@iona.com]
Sent: 12/21/2006 (=D0=C7=C6=DA=CB=C4) 17:09
To: cxf-dev@incubator.apache.org
Subject: Re: PMD issue [was Re: svn commit: r488948 [1/3]]
=20
Question is why not throw the exception when you trying to retrieve the=20
opName?
> Hi Dan,
>
> I just looked into this PMD error in Eclipse, find this is your code's =

> error :)
>
>  OperationInfo(InterfaceInfo it, QName n) {
>        intf =3D it;
>        setName(n);
>    }
>    OperationInfo(OperationInfo op) {
>        intf =3D op.getInterface();
>        setName(op.getName());
>    }
>   ...      public final void setName(QName name) {
>        if (name =3D=3D null) {
>            throw new NullPointerException(
>                new Message("OPERATION.NAME.NOT.NULL", =
LOG).toString());
>        }              opName =3D name;
>    }
>
> The code is looked like this, the setName(QName name) is called in the =

> OperationInfo, and if the name is null the setName() will call the=20
> Messsage. toString() which can be overridden. So the PMD think your=20
> code violated the rule of not calling overridden methods.
>
> I tried to set the Message.toString to be final, but PMD error still=20
> there, so I changed the throw new NullPointerException(...) to throw=20
> new NullPointerException("Operation Name cannot be null.");
>
> So I commited these change , and change the PMD rule back.
>
> Cheers,
>
> Willem.
>
> Dan Diephouse wrote:
>
>> On 12/20/06, dandiep@apache.org <dandiep@apache.org> wrote:
>>
>>>
>>>
>>>    =20
>>> =
incubator/cxf/trunk/buildtools/src/main/resources/cxf-pmd-ruleset.xml
>>>
>>>
>>
>> I forgot to add in my commit notes: I had to change this as PMD seems =
to
>> have a bug in it. It thought I was calling toString() in the=20
>> constructor and
>> that violated the rule of not calling overridden methods. However I'm =

>> not
>> calling it AFAIK. Let me know if I missed something...
>>
>> - Dan
>>
>
>


------_=_NextPart_001_01C724FF.6F10ADB3--