Return-Path: Delivered-To: apmail-incubator-cxf-dev-archive@locus.apache.org Received: (qmail 92596 invoked from network); 5 Nov 2006 03:47:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 5 Nov 2006 03:47:40 -0000 Received: (qmail 56342 invoked by uid 500); 5 Nov 2006 03:47:51 -0000 Delivered-To: apmail-incubator-cxf-dev-archive@incubator.apache.org Received: (qmail 56202 invoked by uid 500); 5 Nov 2006 03:47:51 -0000 Mailing-List: contact cxf-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cxf-dev@incubator.apache.org Delivered-To: mailing list cxf-dev@incubator.apache.org Received: (qmail 56193 invoked by uid 99); 5 Nov 2006 03:47:50 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Nov 2006 19:47:50 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [216.73.126.120] (HELO mail.envoisolutions.com) (216.73.126.120) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Nov 2006 19:47:38 -0800 Received: from [75.209.128.235] (235.sub-75-209-128.myvzw.com [75.209.128.235]) by mail.envoisolutions.com (Postfix) with ESMTP id 47D4B1009D for ; Sat, 4 Nov 2006 19:39:43 -0800 (PST) Message-ID: <454D5EC2.4080305@envoisolutions.com> Date: Sat, 04 Nov 2006 19:47:14 -0800 From: Dan Diephouse User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: cxf-dev@incubator.apache.org Subject: Re: Servlet Support References: <4546DBB2.6000507@envoisolutions.com> <4546E05B.1050809@envoisolutions.com> <4546ECE3.2060407@iona.com> <4547B4F1.9080802@envoisolutions.com> <454AEAFE.2010203@iona.com> <454CDE0A.40209@envoisolutions.com> In-Reply-To: <454CDE0A.40209@envoisolutions.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On second thought, there is more than enough work for two people. In XFire we have this thing called an XFireServletController and basically what it is is a class that servlets delegate to. One case where this is handy is when people use Spring remoting. In spring you can set up a handler mapping which maps URLs to services in essence. In XFire we did it like so: http://xfire.codehaus.org/Spring+QuickStart+Guide Would you be interested in helping port this from XFire? We also have a Spring BeanPostProcessor which takes all the JaxWs beans in the context and publishes them. This would also be a cool thing to have :-) - Dan Dan Diephouse wrote: > Hi Willem, > I started working on these a bit wednesday and am about 50% done at > the moment... If you haven't started on these, maybe I'll just finish > them off? I'll see how far I get though... :-) > > - Dan > > Willem Jiang wrote: > >> Hi DanD, >> >> I will work on http://issues.apache.org/jira/browse/CXF-175 and >> http://issues.apache.org/jira/browse/CXF-192. >> >> Willem. >> >> Dan Diephouse wrote: >> >>> Servlet support is so fundamental to a web services framework that >>> I'm not sure it can wait. I will try to spend some time on it >>> today/tonight... >>> >>> - Dan >>> >>> Freeman Fang wrote: >>> >>>> Hi Dan, >>>> 1. 2. 3. should be fixed in my next commit. >>>> >>>> And I create JIRA task to track multiple endpoints per servlet issue. >>>> https://issues.apache.org/jira/browse/CXF-192 >>>> >>>> CXF-175 also is a good idea, and we can take CXF-175/192 into >>>> account after M1 release >>>> >>>> Thanks very much >>>> >>>> >>>> Dan Diephouse wrote: >>>> >>>>> Dan Diephouse wrote: >>>>> >>>>>> Hiya, >>>>>> I started looking at the CXFServlet tonight, but I'm a little >>>>>> confused. It seems that doPost/doGet are associated with one >>>>>> specific Endpoint (it is a field in the class). This would mean >>>>>> that you could only have one endpoint per servlet, which seems >>>>>> odd. Can someone shed some light? Are there any tests for this? I >>>>>> started one using HTTP Unit, but am still trying to figure out >>>>>> what is going on. >>>>>> >>>>>> - Dan >>>>>> >>>>> Other comments: >>>>> >>>>> 1. Lots of ex.printStackTraces() - in fact there are LOTS of these >>>>> all throughout the CXF code. When we just let these fly by it can >>>>> cause lots of damage to a user's experience as they may not have >>>>> any clue what went wrong or we may get stuck in some infinite loop >>>>> or something similarly horrible. PLEASE PLEASE rethrow these... >>>>> ServletException, Fault, and others all have a constcructor which >>>>> takes a Throwable. >>>>> 2. Minor nitpick but: why are doPost/doGet part of >>>>> ServletDestination? It seems like these should be part of >>>>> CXFServlet and then when we get a request it should send a Message >>>>> to the Destination. >>>>> 3. Why are we doing JaxWsServiceFactoryBean.create() after we >>>>> already created an endpoint/service via new EndpointImpl a few >>>>> lines above (170/180ish)?? If you need to access the >>>>> EndpointInfo, you can get it via Endpoint.getEndpointInfo() >>>>> 4. ClassLoaderUtils.loadClass(String name) is around for a reason... >>>>> 5. What about doDelete/doPut? these are needed for REST >>>>> 6. This would also be good to have for all our Spring users with >>>>> an existing ApplicationContext: >>>>> http://issues.apache.org/jira/browse/CXF-175 >>>>> >>>>> - Dan >>>>> >>>> >>>> >>> >>> >> > > -- Dan Diephouse (616) 971-2053 Envoi Solutions LLC http://netzooid.com