cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Mao <james....@iona.com>
Subject CXF-258
Date Wed, 22 Nov 2006 06:48:41 GMT
About the http://issues.apache.org/jira/browse/CXF-258

I found the following issue:

1.
The method isWrapped(Method m)  in JaxWsServiceConfiguration

The SoapBindind annotation can not placed in the method with the RPC 
style according to the JSR181 spec, both the tools and rt should report 
error for this[1].

So this
 SOAPBinding ann = m.getAnnotation(SOAPBinding.class);
 if (ann != null) {
        return !(ann.parameterStyle().equals(ParameterStyle.BARE) || 
ann.style().equals(Style.RPC));
 }
can be changed to
 SOAPBinding ann = m.getAnnotation(SOAPBinding.class);
 if (ann != null) {
      return !(ann.parameterStyle().equals(ParameterStyle.BARE));
 }

besides we should also check the method in the interface


2. The ReflectionServiceFactoryBean set the default wrappedStyle to 
TRUE, but the testcase is RPC style, so the operation wrappedStyle set 
to FALSE
    That's why if the wsdlLocation is missing there will have a NPE in 
the following code.

            if (wrappedStyle) {
                initializeWrappedSchema(serviceInfo);
            }


Cheers,
James.

[1] http://issues.apache.org/jira/browse/CXF-263



Mime
View raw message