cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dan Diephouse <...@envoisolutions.com>
Subject Re: svn commit: r467624 - in /incubator/cxf/trunk: api/src/main/java/org/apache/cxf/phase/ rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/interceptor/ rt/bindings/soap/src/test/java/org/apache/cxf/binding/soap/attachments/ rt/core/ rt/core/src/...
Date Thu, 26 Oct 2006 13:15:05 GMT
Hi Tom,

Can you explain why we're doing this here? I'm not sure that the chain 
should depend on knowledge about whether a client is running it or not. 
Also, if an Exception happens I think it is the client's responsibility 
to check for a message.getContent(Exception.class) - I thought we were 
already doing so even! Can you please look at changing this back so we 
aren't rethrowing anything?

Thanks,
- Dan

tli@apache.org wrote:

>Modified: incubator/cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java
>URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java?view=diff&rev=467624&r1=467623&r2=467624
>==============================================================================
>--- incubator/cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java
(original)
>+++ incubator/cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java
Wed Oct 25 05:36:43 2006
>@@ -154,6 +154,13 @@
>                 
>                 if (faultObserver != null) {
>                     faultObserver.onMessage(message);
>+                } else {
>+                    // Client out-bound message, directly throw exception back to client
>+                    if (message.getExchange() != null 
>+                            && message == message.getExchange().getOutMessage()

>+                            && message.containsKey(Message.REQUESTOR_ROLE)) {
>+                        throw new RuntimeException(ex);
>+                    }
>                 }
>                 state = State.ABORTED;
>             } 
>
>
>  
>


-- 
Dan Diephouse
(616) 971-2053
Envoi Solutions LLC
http://netzooid.com


Mime
View raw message