Mailing-List: contact cxf-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cxf-dev@incubator.apache.org
Message-ID: <451C0022.8030209@envoisolutions.com>
Date: Thu, 28 Sep 2006 13:02:26 -0400
From: Dan Diephouse <dan@envoisolutions.com>
User-Agent: Thunderbird 1.5.0.7 (Windows/20060909)
MIME-Version: 1.0
To: cxf-dev@incubator.apache.org
Subject: Re: Provider/Dispath demo not working now
References: <451A50A0.3070706@iona.com> <451A61CB.6050809@iona.com>
 <451A88A0.8010904@envoisolutions.com> <451B65C5.3010000@iona.com>
In-Reply-To: <451B65C5.3010000@iona.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi James,

James Mao wrote:
> +1 I agree.
>
> We should add more unit/system tests to identify the problem.
>
> Since you modified the code, can you create a jira task just describe 
> why it should be modified, what's the problem of previous code, and 
> how are you going to implement it?
Well I was hoping you would do it as you added the demo, but I can give 
it a looksie.
> And also add the unit/system tests to cover the scenario which 
> previous tests not covered.
> And also should make sure the previous unit/system tests and demos are 
> working properly.
>
> BTW, i'm really not fan of current modification, to reduce 10 lines of 
> code, we just added at least three classes and bunch of code, it's 
> really harder to maintain than the duplicated 10 lines of code.
>
ProviderServiceFactoryBean and WebServiceProviderConfiguration? Well 
there were several reasons:
1. I feel its good encapsulation, as I don't think all that logic should 
be in EndpointImpl.
2. we weren't building up a service model for the code first approach 
before which we need to do.
3. I refactored things to use the MethodDispatcher and this was an easy 
way to get the MethodDispatcher set up

I'm also close to being able to remove ProviderChainObserver & 
ProviderInvoker, so I don't think all is lost :-)

> Thanks.
> James.
>
>> A good solution in my mind would be to write a unit test which tests 
>> this functionality. Obviously, I'm going to have a hard time not 
>> breaking things if they aren't tested at all. I'll take a look, but 
>> it'd be great if you could add a failing unit test somewhere..
>>
>> - Dan
>>
>> Bozhong Lin wrote:
>>> probably it is time now to setup nightly build and run CPI sanity 
>>> check regularly. I will looked into the possibility of porting 
>>> Celtix CPI test to CeltiXfire.
>>>
>>> Cheers,
>>> Bo
>>>
>>> James Mao wrote:
>>>> Hi Dan,
>>>>
>>>> I realized that you changed the code of dispatch/provider, and i 
>>>> found that the demo not working now, Can you please take a look at 
>>>> this.
>>>>
>>>> Thanks in advance.
>>>> James.
>>>>
>>>> Error message from dispatch_provider sample server:
>>>>     [java] Exception in thread "main" 
>>>> java.lang.NullPointerException: Could not find endpoint 
>>>> GreeterDOMSourceMessageProviderPort in Service.
>>>>     [java]     at 
>>>> org.apache.cxf.jaxws.EndpointImpl.<init>(EndpointImpl.java:95)
>>>>     [java]     at 
>>>> org.apache.cxf.jaxws.spi.ProviderImpl.createEndpoint(ProviderImpl.java:57) 
>>>>
>>>>     [java]     at 
>>>> org.apache.cxf.jaxws.spi.ProviderImpl.createAndPublishEndpoint(ProviderImpl.java:66) 
>>>>
>>>>     [java]     at javax.xml.ws.Endpoint.publish(Endpoint.java:156)
>>>>     [java]     at demo.hwDispatch.server.Server.<init>(Server.java:36)
>>>>     [java]     at demo.hwDispatch.server.Server.main(Server.java:45)
>>>>
>>>> Error message from dispatch_provider sample client:
>>>> [java] Invoking server through Dispatch interface using DOMSource 
>>>> in MESSAGE Mode
>>>>     [java] Sep 27, 2006 4:51:18 PM 
>>>> com.sun.xml.messaging.saaj.soap.SOAPPartImpl lookForEnvelope
>>>>     [java] SEVERE: SAAJ0514: Unable to create envelope from given 
>>>> source because the root element is not named Envelope
>>>>     [java] Sep 27, 2006 4:51:18 PM 
>>>> com.sun.xml.messaging.saaj.soap.EnvelopeFactory createEnvelope
>>>>     [java] SEVERE: SAAJ0511: Unable to create envelope from given 
>>>> source
>>>>     [java] Response from server:
>>>>
>>>>     [java] Error 404 /SoapContext/SoapPort2 Not Found
>>>>
>>>>
>>>>     [java] HTTP ERROR: 404/SoapContext/SoapPort2 Not Found
>>>>     [java] RequestURI=/SoapContext/SoapPort2
>>>>     [java] Powered by Jetty://
>>>>
>>>>
>>>>
>>
>>
>


-- 
Dan Diephouse
Envoi Solutions
http://envoisolutions.com
http://netzooid.com/blog