Return-Path: Delivered-To: apmail-incubator-cxf-dev-archive@locus.apache.org Received: (qmail 94111 invoked from network); 25 Sep 2006 02:58:17 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 25 Sep 2006 02:58:17 -0000 Received: (qmail 67911 invoked by uid 500); 25 Sep 2006 02:58:17 -0000 Delivered-To: apmail-incubator-cxf-dev-archive@incubator.apache.org Received: (qmail 67870 invoked by uid 500); 25 Sep 2006 02:58:17 -0000 Mailing-List: contact cxf-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cxf-dev@incubator.apache.org Delivered-To: mailing list cxf-dev@incubator.apache.org Received: (qmail 67861 invoked by uid 99); 25 Sep 2006 02:58:17 -0000 Received: from idunn.apache.osuosl.org (HELO idunn.apache.osuosl.org) (140.211.166.84) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Sep 2006 19:58:17 -0700 Authentication-Results: idunn.apache.osuosl.org smtp.mail=dan@envoisolutions.com; spf=permerror X-ASF-Spam-Status: No, hits=0.0 required=5.0 tests= Received-SPF: error (idunn.apache.osuosl.org: domain envoisolutions.com from 204.127.192.83 cause and error) Received: from [204.127.192.83] ([204.127.192.83:51550] helo=rwcrmhc13.comcast.net) by idunn.apache.osuosl.org (ecelerity 2.1.1.8 r(12930)) with ESMTP id BB/93-13750-7C547154 for ; Sun, 24 Sep 2006 19:58:15 -0700 Received: from [192.168.3.100] (c-71-205-191-164.hsd1.mi.comcast.net[71.205.191.164]) by comcast.net (rwcrmhc13) with ESMTP id <20060925025812m1300m2mine>; Mon, 25 Sep 2006 02:58:13 +0000 Message-ID: <4517459F.5020004@envoisolutions.com> Date: Sun, 24 Sep 2006 22:57:35 -0400 From: Dan Diephouse User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: cxf-dev@incubator.apache.org CC: cxf-commits@incubator.apache.org Subject: Re: svn commit: r449549 - /incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java References: <20060925023813.D5C541A981A@eris.apache.org> In-Reply-To: <20060925023813.D5C541A981A@eris.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Thanks - but can you explain why that fixes the pmd complaint? Are private methods not allowed? That seems silly :-) - Dan ningjiang@apache.org wrote: > Author: ningjiang > Date: Sun Sep 24 19:38:12 2006 > New Revision: 449549 > > URL: http://svn.apache.org/viewvc?view=rev&rev=449549 > Log: > fixed the pmd error for intializeWrapping > > Modified: > incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java > > Modified: incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java > URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java?view=diff&rev=449549&r1=449548&r2=449549 > ============================================================================== > --- incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java (original) > +++ incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java Sun Sep 24 19:38:12 2006 > @@ -154,7 +154,7 @@ > initalizeClassInfo(o, method); > } > > - private void intializeWrapping(OperationInfo o, Method selected) { > + void intializeWrapping(OperationInfo o, Method selected) { > Class responseWrapper = getResponseWrapper(selected); > if (responseWrapper != null) { > o.getUnwrappedOperation().getOutput().setProperty(WrapperClassOutInterceptor.WRAPPER_CLASS, > > > -- Dan Diephouse Envoi Solutions http://envoisolutions.com http://netzooid.com/blog