cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Ning <ning.ji...@iona.com>
Subject Re: svn commit: r449549 - /incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java
Date Mon, 25 Sep 2006 03:19:10 GMT
Hi, Dan,

The  PMD  error said the  private  method 
intializeWrapping(OperationInfo o, Method selected) in unused,  it 
really silly because the method was called by initializeWSDLOperation().
I think it may be the PMD's bug. I and Tom had already reproduce the PMD 
error, so I want to know your enviroment of PMD runing  :)

Willem.

Dan Diephouse wrote:

> Thanks - but can you explain why that fixes the pmd complaint? Are 
> private methods not allowed? That seems silly :-)
>
> - Dan
>
> ningjiang@apache.org wrote:
>
>> Author: ningjiang
>> Date: Sun Sep 24 19:38:12 2006
>> New Revision: 449549
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=449549
>> Log:
>> fixed the pmd error for intializeWrapping
>>
>> Modified:
>>     
>> incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java

>>
>>
>> Modified: 
>> incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java

>>
>> URL: 
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java?view=diff&rev=449549&r1=449548&r2=449549

>>
>> ============================================================================== 
>>
>> --- 
>> incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java

>> (original)
>> +++ 
>> incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java

>> Sun Sep 24 19:38:12 2006
>> @@ -154,7 +154,7 @@
>>          initalizeClassInfo(o, method);
>>      }
>>  
>> -    private void intializeWrapping(OperationInfo o, Method selected) {
>> +    void intializeWrapping(OperationInfo o, Method selected) {
>>          Class responseWrapper = getResponseWrapper(selected);
>>          if (responseWrapper != null) {
>>              
>> o.getUnwrappedOperation().getOutput().setProperty(WrapperClassOutInterceptor.WRAPPER_CLASS,

>>
>>
>>
>>   
>
>
>


-- 
Willem Jiang
Software Engineer

IONA Asia Pacific Software Development Center
2/F, Unit A, Information Center
Zhongguancun Software Park Haidian District,
Beijing, P.R.China (100094)

Tel: +86-10-82825151 - 523
Fax: +86-10-82825210
Email: ning.jiang@iona.com



Mime
View raw message