cxf-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cohei...@apache.org
Subject [cxf-fediz] branch master updated: Fixing a few code warnings
Date Thu, 05 Oct 2017 12:58:33 GMT
This is an automated email from the ASF dual-hosted git repository.

coheigea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cxf-fediz.git


The following commit(s) were added to refs/heads/master by this push:
     new d61dbe6  Fixing a few code warnings
d61dbe6 is described below

commit d61dbe6308f8c180df1d802ab9a4908cc8e91ed0
Author: Colm O hEigeartaigh <coheigea@apache.org>
AuthorDate: Thu Oct 5 13:58:21 2017 +0100

    Fixing a few code warnings
---
 .../cxf/fediz/cxf/plugin/FedizRedirectBindingFilter.java      |  2 +-
 .../org/apache/cxf/fediz/systests/common/AbstractTests.java   | 11 ++++++-----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/plugins/cxf/src/main/java/org/apache/cxf/fediz/cxf/plugin/FedizRedirectBindingFilter.java
b/plugins/cxf/src/main/java/org/apache/cxf/fediz/cxf/plugin/FedizRedirectBindingFilter.java
index 600e21f..b97fe38 100644
--- a/plugins/cxf/src/main/java/org/apache/cxf/fediz/cxf/plugin/FedizRedirectBindingFilter.java
+++ b/plugins/cxf/src/main/java/org/apache/cxf/fediz/cxf/plugin/FedizRedirectBindingFilter.java
@@ -97,7 +97,7 @@ public class FedizRedirectBindingFilter extends AbstractServiceProviderFilter
             if (HttpMethod.GET.equals(httpMethod)) {
                 params = context.getUriInfo().getQueryParameters();
             } else if (HttpMethod.POST.equals(httpMethod)) {
-                String strForm = IOUtils.toString(context.getEntityStream());
+                String strForm = IOUtils.toString(context.getEntityStream(), "UTF-8");
                 params = JAXRSUtils.getStructuredParams(strForm, "&", true, false);
             }
         } catch (Exception ex) {
diff --git a/systests/tests/src/test/java/org/apache/cxf/fediz/systests/common/AbstractTests.java
b/systests/tests/src/test/java/org/apache/cxf/fediz/systests/common/AbstractTests.java
index 4677ea2..4204f8a 100644
--- a/systests/tests/src/test/java/org/apache/cxf/fediz/systests/common/AbstractTests.java
+++ b/systests/tests/src/test/java/org/apache/cxf/fediz/systests/common/AbstractTests.java
@@ -393,7 +393,7 @@ public abstract class AbstractTests {
         // 4. now we try to access the RP and idp without authentication but with the existing
cookies
         // to see if we are really logged out
 
-        // webClient.close();
+        webClient.close();
         webClient = new WebClient();
         webClient.setCookieManager(cookieManager);
         webClient.getOptions().setUseInsecureSSL(true);
@@ -436,7 +436,7 @@ public abstract class AbstractTests {
         // 4. now we try to access the RP and idp without authentication but with the existing
cookies
         // to see if we are really logged out
 
-        // webClient.close();
+        webClient.close();
         webClient = new WebClient();
         webClient.setCookieManager(cookieManager);
         webClient.getOptions().setUseInsecureSSL(true);
@@ -479,7 +479,7 @@ public abstract class AbstractTests {
         // 4. now we try to access the RP and idp without authentication but with the existing
cookies
         // to see if we are really logged out
 
-        // webClient.close();
+        webClient.close();
         webClient = new WebClient();
         webClient.setCookieManager(cookieManager);
         webClient.getOptions().setUseInsecureSSL(true);
@@ -522,7 +522,7 @@ public abstract class AbstractTests {
         // 4. now we try to access the RP and idp without authentication but with the existing
cookies
         // to see if we are really logged out
 
-        // webClient.close();
+        webClient.close();
         webClient = new WebClient();
         webClient.setCookieManager(cookieManager);
         webClient.getOptions().setUseInsecureSSL(true);
@@ -699,7 +699,8 @@ public abstract class AbstractTests {
         // Parse the form to get the token (wresult)
         DomNodeList<DomElement> results = idpPage.getElementsByTagName("input");
 
-        String entity = IOUtils.toString(this.getClass().getClassLoader().getResource("entity.xml").openStream());
+        String entity =
+            IOUtils.toString(this.getClass().getClassLoader().getResource("entity.xml").openStream(),
"UTF-8");
         String reference = "&m;";
 
         for (DomElement result : results) {

-- 
To stop receiving notification emails like this one, please contact
['"commits@cxf.apache.org" <commits@cxf.apache.org>'].

Mime
View raw message