cxf-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dk...@apache.org
Subject [1/3] cxf git commit: Look at some XXX comments and remove them
Date Fri, 11 Aug 2017 20:41:13 GMT
Repository: cxf
Updated Branches:
  refs/heads/master 38c08dde6 -> 214695957


Look at some XXX comments and remove them


Project: http://git-wip-us.apache.org/repos/asf/cxf/repo
Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/5f717335
Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/5f717335
Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/5f717335

Branch: refs/heads/master
Commit: 5f71733592e1b590fa53c98d86f8ccec2a7b2bcd
Parents: 74e2b09
Author: Daniel Kulp <dkulp@apache.org>
Authored: Fri Aug 11 15:01:10 2017 -0400
Committer: Daniel Kulp <dkulp@apache.org>
Committed: Fri Aug 11 16:41:02 2017 -0400

----------------------------------------------------------------------
 .../service/factory/ReflectionServiceFactoryBean.java   |  3 +--
 .../java/org/apache/cxf/wsdl11/WSDLManagerImpl.java     | 12 ------------
 .../internal/annotator/WebParamAnnotatorTest.java       |  9 ---------
 3 files changed, 1 insertion(+), 23 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cxf/blob/5f717335/rt/wsdl/src/main/java/org/apache/cxf/wsdl/service/factory/ReflectionServiceFactoryBean.java
----------------------------------------------------------------------
diff --git a/rt/wsdl/src/main/java/org/apache/cxf/wsdl/service/factory/ReflectionServiceFactoryBean.java
b/rt/wsdl/src/main/java/org/apache/cxf/wsdl/service/factory/ReflectionServiceFactoryBean.java
index 643efce..ce73343 100644
--- a/rt/wsdl/src/main/java/org/apache/cxf/wsdl/service/factory/ReflectionServiceFactoryBean.java
+++ b/rt/wsdl/src/main/java/org/apache/cxf/wsdl/service/factory/ReflectionServiceFactoryBean.java
@@ -2010,8 +2010,7 @@ public class ReflectionServiceFactoryBean extends org.apache.cxf.service.factory
     }
 
     protected boolean isMatchOperation(String methodNameInClass, String methodNameInWsdl)
{
-        // TODO: This seems wrong and not sure who put it here. Will revisit -
-        // DBD
+        // checks to make sure the operation names match ignoring the case of the first character
         boolean ret = false;
         String initOfMethodInClass = methodNameInClass.substring(0, 1);
         String initOfMethodInWsdl = methodNameInWsdl.substring(0, 1);

http://git-wip-us.apache.org/repos/asf/cxf/blob/5f717335/rt/wsdl/src/main/java/org/apache/cxf/wsdl11/WSDLManagerImpl.java
----------------------------------------------------------------------
diff --git a/rt/wsdl/src/main/java/org/apache/cxf/wsdl11/WSDLManagerImpl.java b/rt/wsdl/src/main/java/org/apache/cxf/wsdl11/WSDLManagerImpl.java
index bb57d4e..fbb47f5 100644
--- a/rt/wsdl/src/main/java/org/apache/cxf/wsdl11/WSDLManagerImpl.java
+++ b/rt/wsdl/src/main/java/org/apache/cxf/wsdl11/WSDLManagerImpl.java
@@ -151,22 +151,10 @@ public class WSDLManagerImpl implements WSDLManager {
         return bus;
     }
 
-    /*
-     * (non-Javadoc)
-     *
-     * XXX - getExtensionRegistry()
-     *
-     * @see org.apache.cxf.wsdl.WSDLManager#getExtenstionRegistry()
-     */
     public ExtensionRegistry getExtensionRegistry() {
         return registry;
     }
 
-    /*
-     * (non-Javadoc)
-     *
-     * @see org.apache.cxf.wsdl.WSDLManager#getDefinition(java.lang.String)
-     */
     public Definition getDefinition(String url) throws WSDLException {
         synchronized (definitionsMap) {
             if (definitionsMap.containsKey(url)) {

http://git-wip-us.apache.org/repos/asf/cxf/blob/5f717335/tools/wsdlto/frontend/jaxws/src/test/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/processor/internal/annotator/WebParamAnnotatorTest.java
----------------------------------------------------------------------
diff --git a/tools/wsdlto/frontend/jaxws/src/test/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/processor/internal/annotator/WebParamAnnotatorTest.java
b/tools/wsdlto/frontend/jaxws/src/test/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/processor/internal/annotator/WebParamAnnotatorTest.java
index ff304fd..f28d05c 100644
--- a/tools/wsdlto/frontend/jaxws/src/test/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/processor/internal/annotator/WebParamAnnotatorTest.java
+++ b/tools/wsdlto/frontend/jaxws/src/test/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/processor/internal/annotator/WebParamAnnotatorTest.java
@@ -66,10 +66,6 @@ public class WebParamAnnotatorTest extends Assert {
         assertEquals(2, elements.size());
         assertEquals("http://apache.org/cxf", elements.get(1).getValue());
         assertEquals("x", elements.get(0).getValue());
-        // XXX - order that attributes are appended to the string
-        //       differs with the ibmjdk...
-        //assertEquals("@WebParam(targetNamespace = \"http://apache.org/cxf\", name = \"x\")",
-        //             annotation.toString());
     }
 
     @Test
@@ -84,11 +80,6 @@ public class WebParamAnnotatorTest extends Assert {
                          annotation.toString());
         List<JAnnotationElement> elements = annotation.getElements();
         assertEquals(3, elements.size());
-        // XXX - order that attributes are appended to the string
-        //       differs with the ibmjdk...
-        //assertEquals(
-        //"@WebParam(targetNamespace = \"http://apache.org/cxf\", partName = \"y\", name
= \"x\")",
-        //             annotation.toString());
     }
 
     @Test


Mime
View raw message