cxf-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cohei...@apache.org
Subject [1/2] cxf-fediz git commit: FEDIZ-192 - customSTSParameter propagation
Date Tue, 28 Feb 2017 18:09:49 GMT
Repository: cxf-fediz
Updated Branches:
  refs/heads/master 6e453b98a -> b464dc99e


FEDIZ-192 - customSTSParameter propagation

Add feedback from review

Signed-off-by: Colm O hEigeartaigh <coheigea@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/cxf-fediz/repo
Commit: http://git-wip-us.apache.org/repos/asf/cxf-fediz/commit/b464dc99
Tree: http://git-wip-us.apache.org/repos/asf/cxf-fediz/tree/b464dc99
Diff: http://git-wip-us.apache.org/repos/asf/cxf-fediz/diff/b464dc99

Branch: refs/heads/master
Commit: b464dc99e5b832ff33779616a6bcf1b88084e602
Parents: a78cc23
Author: gonzalad <adr_gonzalez@yahoo.fr>
Authored: Tue Feb 28 17:44:15 2017 +0100
Committer: Colm O hEigeartaigh <coheigea@apache.org>
Committed: Tue Feb 28 18:09:00 2017 +0000

----------------------------------------------------------------------
 .../cxf/fediz/service/idp/STSUPAuthenticationProvider.java       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cxf-fediz/blob/b464dc99/services/idp-core/src/main/java/org/apache/cxf/fediz/service/idp/STSUPAuthenticationProvider.java
----------------------------------------------------------------------
diff --git a/services/idp-core/src/main/java/org/apache/cxf/fediz/service/idp/STSUPAuthenticationProvider.java
b/services/idp-core/src/main/java/org/apache/cxf/fediz/service/idp/STSUPAuthenticationProvider.java
index 5f66266..7e166f3 100644
--- a/services/idp-core/src/main/java/org/apache/cxf/fediz/service/idp/STSUPAuthenticationProvider.java
+++ b/services/idp-core/src/main/java/org/apache/cxf/fediz/service/idp/STSUPAuthenticationProvider.java
@@ -135,10 +135,10 @@ public class STSUPAuthenticationProvider extends STSAuthenticationProvider
{
         if (getCustomSTSParameter() != null) {
             HttpServletRequest request =
                     ((ServletRequestAttributes) RequestContextHolder.currentRequestAttributes()).getRequest();
-            HttpServletResponse response =
-                    ((ServletRequestAttributes) RequestContextHolder.currentRequestAttributes()).getResponse();
             authRealmParameter = request.getParameter(getCustomSTSParameter());
             if (authRealmParameter == null) {
+                HttpServletResponse response =
+                        ((ServletRequestAttributes) RequestContextHolder.currentRequestAttributes()).getResponse();
                 SavedRequest savedRequest = requestCache.getRequest(request, response);
                 String[] parameterValues = savedRequest.getParameterValues(this.getCustomSTSParameter());
                 if (parameterValues != null && parameterValues.length > 0) {


Mime
View raw message