cxf-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cohei...@apache.org
Subject cxf git commit: Removing TODOs
Date Tue, 24 May 2016 11:43:10 GMT
Repository: cxf
Updated Branches:
  refs/heads/3.1.x-fixes a61399635 -> f5b83ad36


Removing TODOs


Project: http://git-wip-us.apache.org/repos/asf/cxf/repo
Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/f5b83ad3
Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/f5b83ad3
Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/f5b83ad3

Branch: refs/heads/3.1.x-fixes
Commit: f5b83ad364b11bca9c4d3e70bcc68951e096f8ed
Parents: a613996
Author: Colm O hEigeartaigh <coheigea@apache.org>
Authored: Mon May 23 10:15:30 2016 +0100
Committer: Colm O hEigeartaigh <coheigea@apache.org>
Committed: Tue May 24 09:56:44 2016 +0100

----------------------------------------------------------------------
 .../cxf/binding/soap/saaj/ParseBodyTest.java     |  1 -
 .../ws/security/wss4j/WSS4JFaultCodeTest.java    | 19 +++----------------
 2 files changed, 3 insertions(+), 17 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cxf/blob/f5b83ad3/rt/bindings/soap/src/test/java/org/apache/cxf/binding/soap/saaj/ParseBodyTest.java
----------------------------------------------------------------------
diff --git a/rt/bindings/soap/src/test/java/org/apache/cxf/binding/soap/saaj/ParseBodyTest.java
b/rt/bindings/soap/src/test/java/org/apache/cxf/binding/soap/saaj/ParseBodyTest.java
index c6b2087..afff3b9 100644
--- a/rt/bindings/soap/src/test/java/org/apache/cxf/binding/soap/saaj/ParseBodyTest.java
+++ b/rt/bindings/soap/src/test/java/org/apache/cxf/binding/soap/saaj/ParseBodyTest.java
@@ -85,7 +85,6 @@ public class ParseBodyTest extends Assert {
         testUsingStaxUtilsCopyWithSAAJWriter(2);
     }
     
-    // TODO - See CXF-6900
     @Test
     public void testReadSOAPFault() throws Exception {
         InputStream inStream = getClass().getResourceAsStream("soap12-fault.xml");

http://git-wip-us.apache.org/repos/asf/cxf/blob/f5b83ad3/rt/ws/security/src/test/java/org/apache/cxf/ws/security/wss4j/WSS4JFaultCodeTest.java
----------------------------------------------------------------------
diff --git a/rt/ws/security/src/test/java/org/apache/cxf/ws/security/wss4j/WSS4JFaultCodeTest.java
b/rt/ws/security/src/test/java/org/apache/cxf/ws/security/wss4j/WSS4JFaultCodeTest.java
index 9414679..51824fe 100644
--- a/rt/ws/security/src/test/java/org/apache/cxf/ws/security/wss4j/WSS4JFaultCodeTest.java
+++ b/rt/ws/security/src/test/java/org/apache/cxf/ws/security/wss4j/WSS4JFaultCodeTest.java
@@ -220,9 +220,8 @@ public class WSS4JFaultCodeTest extends AbstractSecurityTest {
         }
     }
     
-    // TODO - See CXF-6900.
+    // See CXF-6900.
     @Test
-    @org.junit.Ignore
     public void testSignedEncryptedSOAP12Fault() throws Exception {
         Document doc = readDocument("wsse-response-fault.xml");
 
@@ -261,20 +260,8 @@ public class WSS4JFaultCodeTest extends AbstractSecurityTest {
             "org.apache.cxf.ws.security.wss4j.TestPwdCallback"
         );
         
-        inmsg.put(SecurityConstants.RETURN_SECURITY_ERROR, Boolean.TRUE);
-        
-        try {
-            inHandler.handleMessage(inmsg);
-            StaxUtils.print(saajMsg.getSOAPPart());
-            
-            fail("Expected failure on a SOAP Fault");
-        } catch (SoapFault fault) {
-            fault.printStackTrace();
-            // TODO assertTrue(fault.getReason().startsWith(
-               // "An error was discovered processing the <wsse:Security> header"));
-            QName faultCode = new QName(WSConstants.WSSE_NS, "InvalidSecurity");
-            assertTrue(fault.getFaultCode().equals(faultCode));
-        }
+        inHandler.handleMessage(inmsg);
+        // StaxUtils.print(saajMsg.getSOAPPart());
     }
     
 }


Mime
View raw message