cxf-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From serg...@apache.org
Subject cxf git commit: Fixing a typo in the code grant handler
Date Tue, 19 Jan 2016 11:41:51 GMT
Repository: cxf
Updated Branches:
  refs/heads/3.1.x-fixes 12206c314 -> 9f0d1b323


Fixing a typo in the code grant handler


Project: http://git-wip-us.apache.org/repos/asf/cxf/repo
Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/9f0d1b32
Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/9f0d1b32
Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/9f0d1b32

Branch: refs/heads/3.1.x-fixes
Commit: 9f0d1b3236b6b7fdb67c812360c03bda19700cc5
Parents: 12206c3
Author: Sergey Beryozkin <sberyozkin@gmail.com>
Authored: Tue Jan 19 11:40:19 2016 +0000
Committer: Sergey Beryozkin <sberyozkin@gmail.com>
Committed: Tue Jan 19 11:41:36 2016 +0000

----------------------------------------------------------------------
 .../oauth2/grants/code/AuthorizationCodeGrantHandler.java      | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cxf/blob/9f0d1b32/rt/rs/security/oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/grants/code/AuthorizationCodeGrantHandler.java
----------------------------------------------------------------------
diff --git a/rt/rs/security/oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/grants/code/AuthorizationCodeGrantHandler.java
b/rt/rs/security/oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/grants/code/AuthorizationCodeGrantHandler.java
index 72021f0..fb4bd5d 100644
--- a/rt/rs/security/oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/grants/code/AuthorizationCodeGrantHandler.java
+++ b/rt/rs/security/oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/grants/code/AuthorizationCodeGrantHandler.java
@@ -115,11 +115,11 @@ public class AuthorizationCodeGrantHandler extends AbstractGrantHandler
{
     
     private boolean compareCodeVerifierWithChallenge(Client c, String clientCodeVerifier,

                                                      String clientCodeChallenge) {
-        if (clientCodeChallenge == null && clientCodeChallenge == null 
+        if (clientCodeChallenge == null && clientCodeVerifier == null 
             && (c.isConfidential() || !expectCodeVerifierForPublicClients)) {
             return true;
-        } else if (clientCodeChallenge != null && clientCodeChallenge == null 
-            || clientCodeChallenge == null && clientCodeChallenge != null) {
+        } else if (clientCodeChallenge != null && clientCodeVerifier == null 
+            || clientCodeChallenge == null && clientCodeVerifier != null) {
             return false;
         } else {
             String transformedCodeVerifier = codeVerifierTransformer == null 


Mime
View raw message