cxf-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cohei...@apache.org
Subject cxf-fediz git commit: Fixing failing Spring2 test
Date Mon, 07 Sep 2015 15:48:56 GMT
Repository: cxf-fediz
Updated Branches:
  refs/heads/master 7819861ba -> 95fc79c64


Fixing failing Spring2 test


Project: http://git-wip-us.apache.org/repos/asf/cxf-fediz/repo
Commit: http://git-wip-us.apache.org/repos/asf/cxf-fediz/commit/95fc79c6
Tree: http://git-wip-us.apache.org/repos/asf/cxf-fediz/tree/95fc79c6
Diff: http://git-wip-us.apache.org/repos/asf/cxf-fediz/diff/95fc79c6

Branch: refs/heads/master
Commit: 95fc79c6471ac31e5ac71ba19d000088122c34ab
Parents: 7819861
Author: Colm O hEigeartaigh <coheigea@apache.org>
Authored: Mon Sep 7 16:48:44 2015 +0100
Committer: Colm O hEigeartaigh <coheigea@apache.org>
Committed: Mon Sep 7 16:48:44 2015 +0100

----------------------------------------------------------------------
 .../spring/web/FederationAuthenticationFilter.java     |  7 ++++++-
 .../apache/cxf/fediz/integrationtests/Spring2Test.java | 13 +++----------
 2 files changed, 9 insertions(+), 11 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cxf-fediz/blob/95fc79c6/plugins/spring2/src/main/java/org/apache/cxf/fediz/spring/web/FederationAuthenticationFilter.java
----------------------------------------------------------------------
diff --git a/plugins/spring2/src/main/java/org/apache/cxf/fediz/spring/web/FederationAuthenticationFilter.java
b/plugins/spring2/src/main/java/org/apache/cxf/fediz/spring/web/FederationAuthenticationFilter.java
index 972f182..106dc49 100644
--- a/plugins/spring2/src/main/java/org/apache/cxf/fediz/spring/web/FederationAuthenticationFilter.java
+++ b/plugins/spring2/src/main/java/org/apache/cxf/fediz/spring/web/FederationAuthenticationFilter.java
@@ -172,7 +172,12 @@ public class FederationAuthenticationFilter extends AbstractProcessingFilter
{
                 throw new BadCredentialsException(ex.getMessage(), ex);
             }
         }
-        throw authException;
+        
+        try {
+            response.sendError(HttpServletResponse.SC_UNAUTHORIZED);
+        } catch (IOException e) {
+            throw authException;
+        }
     }
     
     private String getResponseToken(ServletRequest request) {

http://git-wip-us.apache.org/repos/asf/cxf-fediz/blob/95fc79c6/systests/spring/src/test/java/org/apache/cxf/fediz/integrationtests/Spring2Test.java
----------------------------------------------------------------------
diff --git a/systests/spring/src/test/java/org/apache/cxf/fediz/integrationtests/Spring2Test.java
b/systests/spring/src/test/java/org/apache/cxf/fediz/integrationtests/Spring2Test.java
index 3bb2aa5..f057b26 100644
--- a/systests/spring/src/test/java/org/apache/cxf/fediz/integrationtests/Spring2Test.java
+++ b/systests/spring/src/test/java/org/apache/cxf/fediz/integrationtests/Spring2Test.java
@@ -81,28 +81,21 @@ public class Spring2Test extends AbstractTests {
     }
     
     @Test
-    @Ignore("This tests is currently failing on Spring")
-    @Override
-    public void testAliceModifiedSignature() throws Exception {
-        
-    }
-    
-    @Test
-    @Ignore("This tests is currently failing on Spring")
+    @Ignore("Logout not supported with Spring2")
     @Override
     public void testIdPLogout() throws Exception {
         
     }
     
     @Test
-    @Ignore("This tests is currently failing on Spring")
+    @Ignore("Logout not supported with Spring2")
     @Override
     public void testIdPLogoutCleanup() throws Exception {
         
     }
     
     @Test
-    @Ignore("This tests is currently failing on Spring")
+    @Ignore("Logout not supported with Spring2")
     @Override
     public void testRPLogout() throws Exception {
         


Mime
View raw message