cxf-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dk...@apache.org
Subject svn commit: r1501039 - in /cxf/build-utils/trunk/buildtools: pom.xml src/main/java/org/apache/cxf/pmd/UnsafeStringConstructorRule.java src/main/resources/cxf-pmd-ruleset-generated.xml src/main/resources/cxf-pmd-ruleset.xml
Date Tue, 09 Jul 2013 01:27:31 GMT
Author: dkulp
Date: Tue Jul  9 01:27:31 2013
New Revision: 1501039

URL: http://svn.apache.org/r1501039
Log:
Start updating the PMD rules to work with the latest PMD plugins

Modified:
    cxf/build-utils/trunk/buildtools/pom.xml
    cxf/build-utils/trunk/buildtools/src/main/java/org/apache/cxf/pmd/UnsafeStringConstructorRule.java
    cxf/build-utils/trunk/buildtools/src/main/resources/cxf-pmd-ruleset-generated.xml
    cxf/build-utils/trunk/buildtools/src/main/resources/cxf-pmd-ruleset.xml

Modified: cxf/build-utils/trunk/buildtools/pom.xml
URL: http://svn.apache.org/viewvc/cxf/build-utils/trunk/buildtools/pom.xml?rev=1501039&r1=1501038&r2=1501039&view=diff
==============================================================================
--- cxf/build-utils/trunk/buildtools/pom.xml (original)
+++ cxf/build-utils/trunk/buildtools/pom.xml Tue Jul  9 01:27:31 2013
@@ -73,9 +73,9 @@
             <scope>provided</scope>
         </dependency>
         <dependency>
-            <groupId>pmd</groupId>
+            <groupId>net.sourceforge.pmd</groupId>
             <artifactId>pmd</artifactId>
-            <version>4.3</version>
+            <version>5.0.2</version>
             <scope>provided</scope>
         </dependency>
     </dependencies>

Modified: cxf/build-utils/trunk/buildtools/src/main/java/org/apache/cxf/pmd/UnsafeStringConstructorRule.java
URL: http://svn.apache.org/viewvc/cxf/build-utils/trunk/buildtools/src/main/java/org/apache/cxf/pmd/UnsafeStringConstructorRule.java?rev=1501039&r1=1501038&r2=1501039&view=diff
==============================================================================
--- cxf/build-utils/trunk/buildtools/src/main/java/org/apache/cxf/pmd/UnsafeStringConstructorRule.java (original)
+++ cxf/build-utils/trunk/buildtools/src/main/java/org/apache/cxf/pmd/UnsafeStringConstructorRule.java Tue Jul  9 01:27:31 2013
@@ -21,20 +21,19 @@ package org.apache.cxf.pmd;
 
 import java.util.List;
 
-import net.sourceforge.pmd.AbstractJavaRule;
+import net.sourceforge.pmd.lang.java.rule.AbstractJavaRule;
 import net.sourceforge.pmd.RuleContext;
-import net.sourceforge.pmd.ast.ASTAdditiveExpression;
-import net.sourceforge.pmd.ast.ASTAllocationExpression;
-import net.sourceforge.pmd.ast.ASTArgumentList;
-import net.sourceforge.pmd.ast.ASTArrayDimsAndInits;
-import net.sourceforge.pmd.ast.ASTClassOrInterfaceType;
-import net.sourceforge.pmd.ast.ASTExpression;
-import net.sourceforge.pmd.ast.ASTName;
-import net.sourceforge.pmd.ast.Node;
-import net.sourceforge.pmd.ast.SimpleNode;
-import net.sourceforge.pmd.symboltable.NameDeclaration;
-import net.sourceforge.pmd.symboltable.VariableNameDeclaration;
-import net.sourceforge.pmd.typeresolution.TypeHelper;
+import net.sourceforge.pmd.lang.java.ast.ASTAdditiveExpression;
+import net.sourceforge.pmd.lang.java.ast.ASTAllocationExpression;
+import net.sourceforge.pmd.lang.java.ast.ASTArgumentList;
+import net.sourceforge.pmd.lang.java.ast.ASTArrayDimsAndInits;
+import net.sourceforge.pmd.lang.java.ast.ASTClassOrInterfaceType;
+import net.sourceforge.pmd.lang.java.ast.ASTExpression;
+import net.sourceforge.pmd.lang.java.ast.ASTName;
+import net.sourceforge.pmd.lang.java.ast.JavaNode;
+import net.sourceforge.pmd.lang.java.symboltable.NameDeclaration;
+import net.sourceforge.pmd.lang.java.symboltable.VariableNameDeclaration;
+import net.sourceforge.pmd.lang.java.typeresolution.TypeHelper;
 
 /**
  * Look for new String(byte[]) or new String(byte[], start, end)

Modified: cxf/build-utils/trunk/buildtools/src/main/resources/cxf-pmd-ruleset-generated.xml
URL: http://svn.apache.org/viewvc/cxf/build-utils/trunk/buildtools/src/main/resources/cxf-pmd-ruleset-generated.xml?rev=1501039&r1=1501038&r2=1501039&view=diff
==============================================================================
--- cxf/build-utils/trunk/buildtools/src/main/resources/cxf-pmd-ruleset-generated.xml (original)
+++ cxf/build-utils/trunk/buildtools/src/main/resources/cxf-pmd-ruleset-generated.xml Tue Jul  9 01:27:31 2013
@@ -25,179 +25,184 @@
   Eclipse, we need a PMD ruleset that turns off those warnings as the
   PMD eclipse plugin doesn't have a way to not run on certain files
   -->
-<ruleset name="pmd-eclipse-generated">
-    <description>PMD Plugin preferences rule set</description>
 
-
-    <rule ref="rulesets/basic.xml/BooleanInstantiation"/>
-    <rule ref="rulesets/basic.xml/CollapsibleIfStatements"/>
-    <rule ref="rulesets/basic.xml/DoubleCheckedLocking"/>
-    <!--<rule ref="rulesets/basic.xml/EmptyCatchBlock"/>-->
-    <!--<rule ref="rulesets/basic.xml/EmptyFinallyBlock"/>-->
-    <!--<rule ref="rulesets/basic.xml/EmptyIfStmt"/>-->
-    <rule ref="rulesets/basic.xml/EmptyStatementNotInLoop"/>
-    <!--<rule ref="rulesets/basic.xml/EmptyStaticInitializer"/>-->
-    <!--<rule ref="rulesets/basic.xml/EmptySwitchStatements"/>-->
-    <!--<rule ref="rulesets/basic.xml/EmptySynchronizedBlock"/>-->
-    <!--<rule ref="rulesets/basic.xml/EmptyTryBlock"/>-->
-    <!--<rule ref="rulesets/basic.xml/EmptyWhileStmt"/>-->
-    <rule ref="rulesets/basic.xml/ForLoopShouldBeWhileLoop"/>
-    <rule ref="rulesets/basic.xml/JumbledIncrementer"/>
-    <!--<rule ref="rulesets/basic.xml/OverrideBothEqualsAndHashcode"/>-->
-    <rule ref="rulesets/basic.xml/ReturnFromFinallyBlock"/>
-    <rule ref="rulesets/basic.xml/UnconditionalIfStatement"/>
-    <rule ref="rulesets/basic.xml/UnnecessaryConversionTemporary"/>
-    <rule ref="rulesets/basic.xml/UnnecessaryFinalModifier"/>
-    <rule ref="rulesets/basic.xml/UnnecessaryReturn"/>
-    <!--<rule ref="rulesets/basic.xml/UselessOverridingMethod"/>-->
-
-    <!--<rule ref="rulesets/braces.xml/ForLoopsMustUseBraces"/>-->
-    <!--<rule ref="rulesets/braces.xml/IfElseStmtsMustUseBraces"/>-->
-    <!--<rule ref="rulesets/braces.xml/IfStmtsMustUseBraces"/>-->
-    <!--<rule ref="rulesets/braces.xml/WhileLoopsMustUseBraces"/>-->
-
-    <!--<rule ref="rulesets/clone.xml/CloneMethodMustImplementCloneable"/>-->
-    <!--<rule ref="rulesets/clone.xml/CloneThrowsCloneNotSupportedException"/>-->
-    <!--<rule ref="rulesets/clone.xml/ProperCloneImplementation"/>-->
-
-    <!--<rule ref="rulesets/codesize.xml/CyclomaticComplexity"/>-->
-    <!--<rule ref="rulesets/codesize.xml/ExcessiveClassLength"/>-->
-    <!--<rule ref="rulesets/codesize.xml/ExcessiveMethodLength"/>-->
-    <!--<rule ref="rulesets/codesize.xml/ExcessiveParameterList"/>-->
-    <!--<rule ref="rulesets/codesize.xml/ExcessivePublicCount"/>-->
-    <!--<rule ref="rulesets/codesize.xml/TooManyFields"/>-->
-
-    <!--<rule ref="rulesets/controversial.xml/AssignmentInOperand"/>-->
-    <!--<rule ref="rulesets/controversial.xml/AtLeastOneConstructor"/>-->
-    <!--<rule ref="rulesets/controversial.xml/CallSuperInConstructor"/>-->
-    <!--<rule ref="rulesets/controversial.xml/DontImportSun"/>-->
-    <!--<rule ref="rulesets/controversial.xml/NullAssignment"/>-->
-    <!--<rule ref="rulesets/controversial.xml/OnlyOneReturn"/>-->
-    <!--<rule ref="rulesets/controversial.xml/SingularField"/>-->
-    <!--<rule ref="rulesets/controversial.xml/SuspiciousOctalEscape"/>-->
-    <!--<rule ref="rulesets/controversial.xml/UnnecessaryConstructor"/>-->
-    <!--<rule ref="rulesets/controversial.xml/UnnecessaryParentheses"/>-->
-    <!--<rule ref="rulesets/controversial.xml/UnusedModifier"/>-->
-
-    <!--<rule ref="rulesets/coupling.xml/CouplingBetweenObjects"/>-->
-    <!--<rule ref="rulesets/coupling.xml/ExcessiveImports"/>-->
-    <!--<rule ref="rulesets/coupling.xml/LooseCoupling"/>-->
-
-    <!--<rule ref="rulesets/design.xml/AbstractClassWithoutAbstractMethod"/>-->
-    <!--<rule ref="rulesets/design.xml/AccessorClassGeneration"/>-->
-    <!--<rule ref="rulesets/design.xml/AssignmentToNonFinalStatic"/>-->
-    <!--<rule ref="rulesets/design.xml/AvoidDeeplyNestedIfStmts"/>-->
-    <!--<rule ref="rulesets/design.xml/AvoidInstanceofChecksInCatchClause"/>-->
-    <rule ref="rulesets/design.xml/AvoidProtectedFieldInFinalClass"/>
-    <!--<rule ref="rulesets/design.xml/AvoidReassigningParameters"/>-->
-    <!--<rule ref="rulesets/design.xml/AvoidSynchronizedAtMethodLevel"/>-->
-    <!--<rule ref="rulesets/design.xml/BadComparison"/>-->
-    <!--<rule ref="rulesets/design.xml/CloseConnection"/>-->
-    <!--<rule ref="rulesets/design.xml/CompareObjectsWithEquals"/>-->
-    <!--<rule ref="rulesets/design.xml/ConfusingTernary"/>-->
-    <rule ref="rulesets/design.xml/ConstructorCallsOverridableMethod"/>
-    <!--<rule ref="rulesets/design.xml/DefaultLabelNotLastInSwitchStmt"/>-->
-    <!--<rule ref="rulesets/design.xml/FinalFieldCouldBeStatic"/>-->
-    <rule ref="rulesets/design.xml/IdempotentOperations"/>
-    <!--<rule ref="rulesets/design.xml/ImmutableField"/>-->
-    <!--<rule ref="rulesets/design.xml/InstantiationToGetClass"/>-->
-    <!--<rule ref="rulesets/design.xml/MissingBreakInSwitch"/>-->
-    <!--<rule ref="rulesets/design.xml/MissingStaticMethodInNonInstantiatableClass"/>-->
-    <!--<rule ref="rulesets/design.xml/NonCaseLabelInSwitchStatement"/>-->
-    <!--<rule ref="rulesets/design.xml/NonStaticInitializer"/>-->
-    <rule ref="rulesets/design.xml/OptimizableToArrayCall"/>
-    <rule ref="rulesets/design.xml/PositionLiteralsFirstInComparisons"/>
-    <rule ref="rulesets/design.xml/SimplifyBooleanExpressions"/>
-    <rule ref="rulesets/design.xml/SimplifyBooleanReturns"/>
-    <rule ref="rulesets/design.xml/SimplifyConditional"/>
-    <!--<rule ref="rulesets/design.xml/SwitchDensity"/>-->
-    <!--<rule ref="rulesets/design.xml/SwitchStmtsShouldHaveDefault"/>-->
-    <!--rule ref="rulesets/design.xml/UnnecessaryLocalBeforeReturn"/-->
-    <!--<rule ref="rulesets/design.xml/UseLocaleWithCaseConversions"/>-->
-    <!--<rule ref="rulesets/design.xml/UseNotifyAllInsteadOfNotify"/>-->
-    <!--<rule ref="rulesets/design.xml/UseSingleton"/>-->
-
-    <!--<rule ref="rulesets/finalizers.xml/EmptyFinalizer"/>-->
-    <!--<rule ref="rulesets/finalizers.xml/FinalizeOnlyCallsSuperFinalize"/>-->
-    <!--<rule ref="rulesets/finalizers.xml/FinalizeOverloaded"/>-->
-    <!--<rule ref="rulesets/finalizers.xml/FinalizeDoesNotCallSuperFinalize"/>-->
-    <!--<rule ref="rulesets/finalizers.xml/FinalizeShouldBeProtected"/>-->
-    <!--<rule ref="rulesets/finalizers.xml/AvoidCallingFinalize"/>-->
-
-    <!--<rule ref="rulesets/imports.xml/DuplicateImports"/>-->
-    <!--<rule ref="rulesets/imports.xml/DontImportJavaLang"/>-->
-    <!--<rule ref="rulesets/imports.xml/UnusedImports"/>-->
-    <!--<rule ref="rulesets/imports.xml/ImportFromSamePackage"/>-->
-
-    <!--<rule ref="rulesets/javabeans.xml/BeanMembersShouldSerialize"/>-->
-    <!--<rule ref="rulesets/javabeans.xml/MissingSerialVersionUID"/>-->
-
-    <!--<rule ref="rulesets/junit.xml/JUnitStaticSuite"/>-->
-    <!--<rule ref="rulesets/junit.xml/JUnitSpelling"/>-->
-    <!--<rule ref="rulesets/junit.xml/JUnitAssertionsShouldIncludeMessage"/>-->
-    <!--<rule ref="rulesets/junit.xml/JUnitTestsShouldIncludeAssert"/>-->
-    <!--<rule ref="rulesets/junit.xml/TestClassWithoutTestCases"/>-->
-    <!--<rule ref="rulesets/junit.xml/UnnecessaryBooleanAssertion"/>-->
-    <!--<rule ref="rulesets/junit.xml/UseAssertEqualsInsteadOfAssertTrue"/>-->
-    <!--<rule ref="rulesets/junit.xml/UseAssertSameInsteadOfAssertTrue"/>-->
-
-    <!--<rule ref="rulesets/logging-java.xml/AvoidPrintStackTrace"/>-->
-    <rule ref="rulesets/logging-java.xml/LoggerIsNotStaticFinal"/>
-    <!--<rule ref="rulesets/logging-java.xml/MoreThanOneLogger"/>-->
-    <!--<rule ref="rulesets/logging-java.xml/LoggerIsNotStaticFinal"/>-->
-    <!--<rule ref="rulesets/logging-java.xml/LogBlockWithoutIf"/>-->
-    <!--<rule ref="rulesets/logging-java.xml/SystemPrintln"/>-->
-    <!--<rule ref="rulesets/logging-jakarta-commons.xml/UseCorrectExceptionLogging"/>-->
-    <!--<rule ref="rulesets/logging-jakarta-commons.xml/ProperLogger"/>-->
-
-    <!--<rule ref="rulesets/naming.xml/ShortVariable"/>-->
-    <!--<rule ref="rulesets/naming.xml/LongVariable"/>-->
-    <!--<rule ref="rulesets/naming.xml/ShortMethodName"/>-->
-    <!--<rule ref="rulesets/naming.xml/VariableNamingConventions"/>-->
-    <!--<rule ref="rulesets/naming.xml/MethodNamingConventions"/>-->
-    <!--<rule ref="rulesets/naming.xml/ClassNamingConventions"/>-->
-    <!--<rule ref="rulesets/naming.xml/AbstractNaming"/>-->
-    <!--<rule ref="rulesets/naming.xml/AvoidDollarSigns"/>-->
-    <!--<rule ref="rulesets/naming.xml/MethodWithSameNameAsEnclosingClass"/>-->
-    <!--<rule ref="rulesets/naming.xml/SuspiciousHashcodeMethodName"/>-->
-    <!--<rule ref="rulesets/naming.xml/SuspiciousConstantFieldName"/>-->
-    <!--<rule ref="rulesets/naming.xml/AvoidFieldNameMatchingTypeName"/>-->
-    <!--<rule ref="rulesets/naming.xml/AvoidFieldNameMatchingMethodName"/>-->
-    <!--<rule ref="rulesets/naming.xml/AvoidNonConstructorMethodsWithClassName"/>-->
-    <!--<rule ref="rulesets/naming.xml/NoPackage"/>-->
-    <!--<rule ref="rulesets/naming.xml/PackageCase"/>-->
-
-    <!--<rule ref="rulesets/optimizations.xml/LocalVariableCouldBeFinal"/>-->
-    <!--<rule ref="rulesets/optimizations.xml/MethodArgumentCouldBeFinal"/>-->
-    <!--<rule ref="rulesets/optimizations.xml/AvoidInstantiatingObjectsInLoops"/>-->
-    <!--<rule ref="rulesets/optimizations.xml/UseArrayListInsteadOfVector"/>-->
-    <!--<rule ref="rulesets/optimizations.xml/SimplifyStartsWith"/>-->
-    <!--<rule ref="rulesets/optimizations.xml/UseStringBuilderForStringAppends"/>-->
-
-    <!--<rule ref="rulesets/strictexception.xml/AvoidCatchingThrowable"/>-->
-    <!--<rule ref="rulesets/strictexception.xml/SignatureDeclareThrowsException"/>-->
-    <!--<rule ref="rulesets/strictexception.xml/ExceptionAsFlowControl"/>-->
-    <!--<rule ref="rulesets/strictexception.xml/AvoidCatchingNPE"/>-->
-    <!--<rule ref="rulesets/strictexception.xml/AvoidThrowingRawExceptionTypes"/>-->
-    <!--<rule ref="rulesets/strictexception.xml/AvoidThrowingNullPointerException"/>-->
-
-    <!--<rule ref="rulesets/strings.xml/AvoidDuplicateLiterals"/>-->
-    <!--<rule ref="rulesets/strings.xml/StringInstantiation"/>-->
-    <!--<rule ref="rulesets/strings.xml/StringToString"/>-->
-    <!--<rule ref="rulesets/strings.xml/AvoidConcatenatingNonLiteralsInStringBuilder"/>-->
-    <!--<rule ref="rulesets/strings.xml/UnnecessaryCaseChange"/>-->
-
-    <!--<rule ref="rulesets/sunsecure.xml/MethodReturnsInternalArray"/>-->
-    <!--<rule ref="rulesets/sunsecure.xml/ArrayIsStoredDirectly"/>-->
-
-    <!--rule ref="rulesets/unusedcode.xml/UnusedLocalVariable"/-->
-    <!--rule ref="rulesets/unusedcode.xml/UnusedPrivateField"/-->
-    <!--rule ref="rulesets/unusedcode.xml/UnusedPrivateMethod"/-->
-    <!--<rule ref="rulesets/unusedcode.xml/UnusedFormalParameter"/>-->
+<ruleset name="pmd-cxf-eclipse-generated" xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
+        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 http://pmd.sourceforge.net/ruleset_2_0_0.xsd">
+        <description>CXF PMD Plugin preferences rule set</description>
+        
+
+
+    <rule ref="rulesets/java/basic.xml/BooleanInstantiation"/>
+    <rule ref="rulesets/java/basic.xml/CollapsibleIfStatements"/>
+    <rule ref="rulesets/java/basic.xml/DoubleCheckedLocking"/>
+    <!--<rule ref="rulesets/java/basic.xml/EmptyCatchBlock"/>-->
+    <!--<rule ref="rulesets/java/basic.xml/EmptyFinallyBlock"/>-->
+    <!--<rule ref="rulesets/java/basic.xml/EmptyIfStmt"/>-->
+    <rule ref="rulesets/java/basic.xml/EmptyStatementNotInLoop"/>
+    <!--<rule ref="rulesets/java/basic.xml/EmptyStaticInitializer"/>-->
+    <!--<rule ref="rulesets/java/basic.xml/EmptySwitchStatements"/>-->
+    <!--<rule ref="rulesets/java/basic.xml/EmptySynchronizedBlock"/>-->
+    <!--<rule ref="rulesets/java/basic.xml/EmptyTryBlock"/>-->
+    <!--<rule ref="rulesets/java/basic.xml/EmptyWhileStmt"/>-->
+    <rule ref="rulesets/java/basic.xml/ForLoopShouldBeWhileLoop"/>
+    <rule ref="rulesets/java/basic.xml/JumbledIncrementer"/>
+    <!--<rule ref="rulesets/java/basic.xml/OverrideBothEqualsAndHashcode"/>-->
+    <rule ref="rulesets/java/basic.xml/ReturnFromFinallyBlock"/>
+    <rule ref="rulesets/java/basic.xml/UnconditionalIfStatement"/>
+    <rule ref="rulesets/java/basic.xml/UnnecessaryConversionTemporary"/>
+    <rule ref="rulesets/java/basic.xml/UnnecessaryFinalModifier"/>
+    <rule ref="rulesets/java/basic.xml/UnnecessaryReturn"/>
+    <!--<rule ref="rulesets/java/basic.xml/UselessOverridingMethod"/>-->
+
+    <!--<rule ref="rulesets/java/braces.xml/ForLoopsMustUseBraces"/>-->
+    <!--<rule ref="rulesets/java/braces.xml/IfElseStmtsMustUseBraces"/>-->
+    <!--<rule ref="rulesets/java/braces.xml/IfStmtsMustUseBraces"/>-->
+    <!--<rule ref="rulesets/java/braces.xml/WhileLoopsMustUseBraces"/>-->
+
+    <!--<rule ref="rulesets/java/clone.xml/CloneMethodMustImplementCloneable"/>-->
+    <!--<rule ref="rulesets/java/clone.xml/CloneThrowsCloneNotSupportedException"/>-->
+    <!--<rule ref="rulesets/java/clone.xml/ProperCloneImplementation"/>-->
+
+    <!--<rule ref="rulesets/java/codesize.xml/CyclomaticComplexity"/>-->
+    <!--<rule ref="rulesets/java/codesize.xml/ExcessiveClassLength"/>-->
+    <!--<rule ref="rulesets/java/codesize.xml/ExcessiveMethodLength"/>-->
+    <!--<rule ref="rulesets/java/codesize.xml/ExcessiveParameterList"/>-->
+    <!--<rule ref="rulesets/java/codesize.xml/ExcessivePublicCount"/>-->
+    <!--<rule ref="rulesets/java/codesize.xml/TooManyFields"/>-->
+
+    <!--<rule ref="rulesets/java/controversial.xml/AssignmentInOperand"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/AtLeastOneConstructor"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/CallSuperInConstructor"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/DontImportSun"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/NullAssignment"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/OnlyOneReturn"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/SingularField"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/SuspiciousOctalEscape"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/UnnecessaryConstructor"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/UnnecessaryParentheses"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/UnusedModifier"/>-->
+
+    <!--<rule ref="rulesets/java/coupling.xml/CouplingBetweenObjects"/>-->
+    <!--<rule ref="rulesets/java/coupling.xml/ExcessiveImports"/>-->
+    <!--<rule ref="rulesets/java/coupling.xml/LooseCoupling"/>-->
+
+    <!--<rule ref="rulesets/java/design.xml/AbstractClassWithoutAbstractMethod"/>-->
+    <!--<rule ref="rulesets/java/design.xml/AccessorClassGeneration"/>-->
+    <!--<rule ref="rulesets/java/design.xml/AssignmentToNonFinalStatic"/>-->
+    <!--<rule ref="rulesets/java/design.xml/AvoidDeeplyNestedIfStmts"/>-->
+    <!--<rule ref="rulesets/java/design.xml/AvoidInstanceofChecksInCatchClause"/>-->
+    <rule ref="rulesets/java/design.xml/AvoidProtectedFieldInFinalClass"/>
+    <!--<rule ref="rulesets/java/design.xml/AvoidReassigningParameters"/>-->
+    <!--<rule ref="rulesets/java/design.xml/AvoidSynchronizedAtMethodLevel"/>-->
+    <!--<rule ref="rulesets/java/design.xml/BadComparison"/>-->
+    <!--<rule ref="rulesets/java/design.xml/CloseConnection"/>-->
+    <!--<rule ref="rulesets/java/design.xml/CompareObjectsWithEquals"/>-->
+    <!--<rule ref="rulesets/java/design.xml/ConfusingTernary"/>-->
+    <rule ref="rulesets/java/design.xml/ConstructorCallsOverridableMethod"/>
+    <!--<rule ref="rulesets/java/design.xml/DefaultLabelNotLastInSwitchStmt"/>-->
+    <!--<rule ref="rulesets/java/design.xml/FinalFieldCouldBeStatic"/>-->
+    <rule ref="rulesets/java/design.xml/IdempotentOperations"/>
+    <!--<rule ref="rulesets/java/design.xml/ImmutableField"/>-->
+    <!--<rule ref="rulesets/java/design.xml/InstantiationToGetClass"/>-->
+    <!--<rule ref="rulesets/java/design.xml/MissingBreakInSwitch"/>-->
+    <!--<rule ref="rulesets/java/design.xml/MissingStaticMethodInNonInstantiatableClass"/>-->
+    <!--<rule ref="rulesets/java/design.xml/NonCaseLabelInSwitchStatement"/>-->
+    <!--<rule ref="rulesets/java/design.xml/NonStaticInitializer"/>-->
+    <rule ref="rulesets/java/design.xml/OptimizableToArrayCall"/>
+    <rule ref="rulesets/java/design.xml/PositionLiteralsFirstInComparisons"/>
+    <rule ref="rulesets/java/design.xml/SimplifyBooleanExpressions"/>
+    <rule ref="rulesets/java/design.xml/SimplifyBooleanReturns"/>
+    <rule ref="rulesets/java/design.xml/SimplifyConditional"/>
+    <!--<rule ref="rulesets/java/design.xml/SwitchDensity"/>-->
+    <!--<rule ref="rulesets/java/design.xml/SwitchStmtsShouldHaveDefault"/>-->
+    <!--rule ref="rulesets/java/design.xml/UnnecessaryLocalBeforeReturn"/-->
+    <!--<rule ref="rulesets/java/design.xml/UseLocaleWithCaseConversions"/>-->
+    <!--<rule ref="rulesets/java/design.xml/UseNotifyAllInsteadOfNotify"/>-->
+    <!--<rule ref="rulesets/java/design.xml/UseSingleton"/>-->
+
+    <!--<rule ref="rulesets/java/finalizers.xml/EmptyFinalizer"/>-->
+    <!--<rule ref="rulesets/java/finalizers.xml/FinalizeOnlyCallsSuperFinalize"/>-->
+    <!--<rule ref="rulesets/java/finalizers.xml/FinalizeOverloaded"/>-->
+    <!--<rule ref="rulesets/java/finalizers.xml/FinalizeDoesNotCallSuperFinalize"/>-->
+    <!--<rule ref="rulesets/java/finalizers.xml/FinalizeShouldBeProtected"/>-->
+    <!--<rule ref="rulesets/java/finalizers.xml/AvoidCallingFinalize"/>-->
+
+    <!--<rule ref="rulesets/java/imports.xml/DuplicateImports"/>-->
+    <!--<rule ref="rulesets/java/imports.xml/DontImportJavaLang"/>-->
+    <!--<rule ref="rulesets/java/imports.xml/UnusedImports"/>-->
+    <!--<rule ref="rulesets/java/imports.xml/ImportFromSamePackage"/>-->
+
+    <!--<rule ref="rulesets/java/javabeans.xml/BeanMembersShouldSerialize"/>-->
+    <!--<rule ref="rulesets/java/javabeans.xml/MissingSerialVersionUID"/>-->
+
+    <!--<rule ref="rulesets/java/junit.xml/JUnitStaticSuite"/>-->
+    <!--<rule ref="rulesets/java/junit.xml/JUnitSpelling"/>-->
+    <!--<rule ref="rulesets/java/junit.xml/JUnitAssertionsShouldIncludeMessage"/>-->
+    <!--<rule ref="rulesets/java/junit.xml/JUnitTestsShouldIncludeAssert"/>-->
+    <!--<rule ref="rulesets/java/junit.xml/TestClassWithoutTestCases"/>-->
+    <!--<rule ref="rulesets/java/junit.xml/UnnecessaryBooleanAssertion"/>-->
+    <!--<rule ref="rulesets/java/junit.xml/UseAssertEqualsInsteadOfAssertTrue"/>-->
+    <!--<rule ref="rulesets/java/junit.xml/UseAssertSameInsteadOfAssertTrue"/>-->
+
+    <!--<rule ref="rulesets/java/logging-java.xml/AvoidPrintStackTrace"/>-->
+    <rule ref="rulesets/java/logging-java.xml/LoggerIsNotStaticFinal"/>
+    <!--<rule ref="rulesets/java/logging-java.xml/MoreThanOneLogger"/>-->
+    <!--<rule ref="rulesets/java/logging-java.xml/LoggerIsNotStaticFinal"/>-->
+    <!--<rule ref="rulesets/java/logging-java.xml/LogBlockWithoutIf"/>-->
+    <!--<rule ref="rulesets/java/logging-java.xml/SystemPrintln"/>-->
+    <!--<rule ref="rulesets/java/logging-jakarta-commons.xml/UseCorrectExceptionLogging"/>-->
+    <!--<rule ref="rulesets/java/logging-jakarta-commons.xml/ProperLogger"/>-->
+
+    <!--<rule ref="rulesets/java/naming.xml/ShortVariable"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/LongVariable"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/ShortMethodName"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/VariableNamingConventions"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/MethodNamingConventions"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/ClassNamingConventions"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/AbstractNaming"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/AvoidDollarSigns"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/MethodWithSameNameAsEnclosingClass"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/SuspiciousHashcodeMethodName"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/SuspiciousConstantFieldName"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/AvoidFieldNameMatchingTypeName"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/AvoidFieldNameMatchingMethodName"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/AvoidNonConstructorMethodsWithClassName"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/NoPackage"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/PackageCase"/>-->
+
+    <!--<rule ref="rulesets/java/optimizations.xml/LocalVariableCouldBeFinal"/>-->
+    <!--<rule ref="rulesets/java/optimizations.xml/MethodArgumentCouldBeFinal"/>-->
+    <!--<rule ref="rulesets/java/optimizations.xml/AvoidInstantiatingObjectsInLoops"/>-->
+    <!--<rule ref="rulesets/java/optimizations.xml/UseArrayListInsteadOfVector"/>-->
+    <!--<rule ref="rulesets/java/optimizations.xml/SimplifyStartsWith"/>-->
+    <!--<rule ref="rulesets/java/optimizations.xml/UseStringBuilderForStringAppends"/>-->
+
+    <!--<rule ref="rulesets/java/strictexception.xml/AvoidCatchingThrowable"/>-->
+    <!--<rule ref="rulesets/java/strictexception.xml/SignatureDeclareThrowsException"/>-->
+    <!--<rule ref="rulesets/java/strictexception.xml/ExceptionAsFlowControl"/>-->
+    <!--<rule ref="rulesets/java/strictexception.xml/AvoidCatchingNPE"/>-->
+    <!--<rule ref="rulesets/java/strictexception.xml/AvoidThrowingRawExceptionTypes"/>-->
+    <!--<rule ref="rulesets/java/strictexception.xml/AvoidThrowingNullPointerException"/>-->
+
+    <!--<rule ref="rulesets/java/strings.xml/AvoidDuplicateLiterals"/>-->
+    <!--<rule ref="rulesets/java/strings.xml/StringInstantiation"/>-->
+    <!--<rule ref="rulesets/java/strings.xml/StringToString"/>-->
+    <!--<rule ref="rulesets/java/strings.xml/AvoidConcatenatingNonLiteralsInStringBuilder"/>-->
+    <!--<rule ref="rulesets/java/strings.xml/UnnecessaryCaseChange"/>-->
+
+    <!--<rule ref="rulesets/java/sunsecure.xml/MethodReturnsInternalArray"/>-->
+    <!--<rule ref="rulesets/java/sunsecure.xml/ArrayIsStoredDirectly"/>-->
+
+    <!--rule ref="rulesets/java/unusedcode.xml/UnusedLocalVariable"/-->
+    <!--rule ref="rulesets/java/unusedcode.xml/UnusedPrivateField"/-->
+    <!--rule ref="rulesets/java/unusedcode.xml/UnusedPrivateMethod"/-->
+    <!--<rule ref="rulesets/java/unusedcode.xml/UnusedFormalParameter"/>-->
 
     <rule name="DontUseLoggerGetLogger"
           message="Don't use Logger.getLogger(...), use LogUtils.getL7dLogger(....) instead"
-          class="net.sourceforge.pmd.rules.XPathRule">
+        class="net.sourceforge.pmd.lang.rule.XPathRule"
+        language="java">
         <priority>2</priority>
         <description>Don't use Logger.getLogger(...), use LogUtils.getL7dLogger(....) instead</description>
         <properties>

Modified: cxf/build-utils/trunk/buildtools/src/main/resources/cxf-pmd-ruleset.xml
URL: http://svn.apache.org/viewvc/cxf/build-utils/trunk/buildtools/src/main/resources/cxf-pmd-ruleset.xml?rev=1501039&r1=1501038&r2=1501039&view=diff
==============================================================================
--- cxf/build-utils/trunk/buildtools/src/main/resources/cxf-pmd-ruleset.xml (original)
+++ cxf/build-utils/trunk/buildtools/src/main/resources/cxf-pmd-ruleset.xml Tue Jul  9 01:27:31 2013
@@ -17,179 +17,182 @@
   specific language governing permissions and limitations
   under the License.
 -->
-<ruleset name="pmd-eclipse">
-    <description>PMD Plugin preferences rule set</description>
-
-
-    <rule ref="rulesets/basic.xml/BooleanInstantiation"/>
-    <rule ref="rulesets/basic.xml/CollapsibleIfStatements"/>
-    <rule ref="rulesets/basic.xml/DoubleCheckedLocking"/>
-    <!--<rule ref="rulesets/basic.xml/EmptyCatchBlock"/>-->
-    <!--<rule ref="rulesets/basic.xml/EmptyFinallyBlock"/>-->
-    <!--<rule ref="rulesets/basic.xml/EmptyIfStmt"/>-->
-    <rule ref="rulesets/basic.xml/EmptyStatementNotInLoop"/>
-    <!--<rule ref="rulesets/basic.xml/EmptyStaticInitializer"/>-->
-    <!--<rule ref="rulesets/basic.xml/EmptySwitchStatements"/>-->
-    <!--<rule ref="rulesets/basic.xml/EmptySynchronizedBlock"/>-->
-    <!--<rule ref="rulesets/basic.xml/EmptyTryBlock"/>-->
-    <!--<rule ref="rulesets/basic.xml/EmptyWhileStmt"/>-->
-    <rule ref="rulesets/basic.xml/ForLoopShouldBeWhileLoop"/>
-    <rule ref="rulesets/basic.xml/JumbledIncrementer"/>
-    <!--<rule ref="rulesets/basic.xml/OverrideBothEqualsAndHashcode"/>-->
-    <rule ref="rulesets/basic.xml/ReturnFromFinallyBlock"/>
-    <rule ref="rulesets/basic.xml/UnconditionalIfStatement"/>
-    <rule ref="rulesets/basic.xml/UnnecessaryConversionTemporary"/>
-    <rule ref="rulesets/basic.xml/UnnecessaryFinalModifier"/>
-    <rule ref="rulesets/basic.xml/UnnecessaryReturn"/>
-    <!--<rule ref="rulesets/basic.xml/UselessOverridingMethod"/>-->
-
-    <!--<rule ref="rulesets/braces.xml/ForLoopsMustUseBraces"/>-->
-    <!--<rule ref="rulesets/braces.xml/IfElseStmtsMustUseBraces"/>-->
-    <!--<rule ref="rulesets/braces.xml/IfStmtsMustUseBraces"/>-->
-    <!--<rule ref="rulesets/braces.xml/WhileLoopsMustUseBraces"/>-->
-
-    <!--<rule ref="rulesets/clone.xml/CloneMethodMustImplementCloneable"/>-->
-    <!--<rule ref="rulesets/clone.xml/CloneThrowsCloneNotSupportedException"/>-->
-    <!--<rule ref="rulesets/clone.xml/ProperCloneImplementation"/>-->
-
-    <!--<rule ref="rulesets/codesize.xml/CyclomaticComplexity"/>-->
-    <!--<rule ref="rulesets/codesize.xml/ExcessiveClassLength"/>-->
-    <!--<rule ref="rulesets/codesize.xml/ExcessiveMethodLength"/>-->
-    <!--<rule ref="rulesets/codesize.xml/ExcessiveParameterList"/>-->
-    <!--<rule ref="rulesets/codesize.xml/ExcessivePublicCount"/>-->
-    <!--<rule ref="rulesets/codesize.xml/TooManyFields"/>-->
-
-    <!--<rule ref="rulesets/controversial.xml/AssignmentInOperand"/>-->
-    <!--<rule ref="rulesets/controversial.xml/AtLeastOneConstructor"/>-->
-    <!--<rule ref="rulesets/controversial.xml/CallSuperInConstructor"/>-->
-    <!--<rule ref="rulesets/controversial.xml/DontImportSun"/>-->
-    <!--<rule ref="rulesets/controversial.xml/NullAssignment"/>-->
-    <!--<rule ref="rulesets/controversial.xml/OnlyOneReturn"/>-->
-    <!--<rule ref="rulesets/controversial.xml/SingularField"/>-->
-    <!--<rule ref="rulesets/controversial.xml/SuspiciousOctalEscape"/>-->
-    <!--<rule ref="rulesets/controversial.xml/UnnecessaryConstructor"/>-->
-    <!--<rule ref="rulesets/controversial.xml/UnnecessaryParentheses"/>-->
-    <!--<rule ref="rulesets/controversial.xml/UnusedModifier"/>-->
-
-    <!--<rule ref="rulesets/coupling.xml/CouplingBetweenObjects"/>-->
-    <!--<rule ref="rulesets/coupling.xml/ExcessiveImports"/>-->
-    <!--<rule ref="rulesets/coupling.xml/LooseCoupling"/>-->
-
-    <!--<rule ref="rulesets/design.xml/AbstractClassWithoutAbstractMethod"/>-->
-    <!--<rule ref="rulesets/design.xml/AccessorClassGeneration"/>-->
-    <!--<rule ref="rulesets/design.xml/AssignmentToNonFinalStatic"/>-->
-    <!--<rule ref="rulesets/design.xml/AvoidDeeplyNestedIfStmts"/>-->
-    <!--<rule ref="rulesets/design.xml/AvoidInstanceofChecksInCatchClause"/>-->
-    <rule ref="rulesets/design.xml/AvoidProtectedFieldInFinalClass"/>
-    <!--<rule ref="rulesets/design.xml/AvoidReassigningParameters"/>-->
-    <!--<rule ref="rulesets/design.xml/AvoidSynchronizedAtMethodLevel"/>-->
-    <!--<rule ref="rulesets/design.xml/BadComparison"/>-->
-    <!--<rule ref="rulesets/design.xml/CloseConnection"/>-->
-    <!--<rule ref="rulesets/design.xml/CompareObjectsWithEquals"/>-->
-    <!--<rule ref="rulesets/design.xml/ConfusingTernary"/>-->
-    <rule ref="rulesets/design.xml/ConstructorCallsOverridableMethod"/>
-    <!--<rule ref="rulesets/design.xml/DefaultLabelNotLastInSwitchStmt"/>-->
-    <!--<rule ref="rulesets/design.xml/FinalFieldCouldBeStatic"/>-->
-    <rule ref="rulesets/design.xml/IdempotentOperations"/>
-    <!--<rule ref="rulesets/design.xml/ImmutableField"/>-->
-    <!--<rule ref="rulesets/design.xml/InstantiationToGetClass"/>-->
-    <!--<rule ref="rulesets/design.xml/MissingBreakInSwitch"/>-->
-    <!--<rule ref="rulesets/design.xml/MissingStaticMethodInNonInstantiatableClass"/>-->
-    <!--<rule ref="rulesets/design.xml/NonCaseLabelInSwitchStatement"/>-->
-    <!--<rule ref="rulesets/design.xml/NonStaticInitializer"/>-->
-    <rule ref="rulesets/design.xml/OptimizableToArrayCall"/>
-    <rule ref="rulesets/design.xml/PositionLiteralsFirstInComparisons"/>
-    <rule ref="rulesets/design.xml/SimplifyBooleanExpressions"/>
-    <rule ref="rulesets/design.xml/SimplifyBooleanReturns"/>
-    <rule ref="rulesets/design.xml/SimplifyConditional"/>
-    <!--<rule ref="rulesets/design.xml/SwitchDensity"/>-->
-    <!--<rule ref="rulesets/design.xml/SwitchStmtsShouldHaveDefault"/>-->
-    <rule ref="rulesets/design.xml/UnnecessaryLocalBeforeReturn"/>
-    <!--<rule ref="rulesets/design.xml/UseLocaleWithCaseConversions"/>-->
-    <!--<rule ref="rulesets/design.xml/UseNotifyAllInsteadOfNotify"/>-->
-    <!--<rule ref="rulesets/design.xml/UseSingleton"/>-->
-
-    <!--<rule ref="rulesets/finalizers.xml/EmptyFinalizer"/>-->
-    <!--<rule ref="rulesets/finalizers.xml/FinalizeOnlyCallsSuperFinalize"/>-->
-    <!--<rule ref="rulesets/finalizers.xml/FinalizeOverloaded"/>-->
-    <!--<rule ref="rulesets/finalizers.xml/FinalizeDoesNotCallSuperFinalize"/>-->
-    <!--<rule ref="rulesets/finalizers.xml/FinalizeShouldBeProtected"/>-->
-    <!--<rule ref="rulesets/finalizers.xml/AvoidCallingFinalize"/>-->
-
-    <!--<rule ref="rulesets/imports.xml/DuplicateImports"/>-->
-    <!--<rule ref="rulesets/imports.xml/DontImportJavaLang"/>-->
-    <!--<rule ref="rulesets/imports.xml/UnusedImports"/>-->
-    <!--<rule ref="rulesets/imports.xml/ImportFromSamePackage"/>-->
-
-    <!--<rule ref="rulesets/javabeans.xml/BeanMembersShouldSerialize"/>-->
-    <!--<rule ref="rulesets/javabeans.xml/MissingSerialVersionUID"/>-->
-
-    <!--<rule ref="rulesets/junit.xml/JUnitStaticSuite"/>-->
-    <!--<rule ref="rulesets/junit.xml/JUnitSpelling"/>-->
-    <!--<rule ref="rulesets/junit.xml/JUnitAssertionsShouldIncludeMessage"/>-->
-    <!--<rule ref="rulesets/junit.xml/JUnitTestsShouldIncludeAssert"/>-->
-    <!--<rule ref="rulesets/junit.xml/TestClassWithoutTestCases"/>-->
-    <!--<rule ref="rulesets/junit.xml/UnnecessaryBooleanAssertion"/>-->
-    <!--<rule ref="rulesets/junit.xml/UseAssertEqualsInsteadOfAssertTrue"/>-->
-    <!--<rule ref="rulesets/junit.xml/UseAssertSameInsteadOfAssertTrue"/>-->
-
-    <!--<rule ref="rulesets/logging-java.xml/AvoidPrintStackTrace"/>-->
-    <rule ref="rulesets/logging-java.xml/LoggerIsNotStaticFinal"/>
-    <!--<rule ref="rulesets/logging-java.xml/MoreThanOneLogger"/>-->
-    <!--<rule ref="rulesets/logging-java.xml/LoggerIsNotStaticFinal"/>-->
-    <!--<rule ref="rulesets/logging-java.xml/LogBlockWithoutIf"/>-->
-    <!--<rule ref="rulesets/logging-java.xml/SystemPrintln"/>-->
-    <!--<rule ref="rulesets/logging-jakarta-commons.xml/UseCorrectExceptionLogging"/>-->
-    <!--<rule ref="rulesets/logging-jakarta-commons.xml/ProperLogger"/>-->
-
-    <!--<rule ref="rulesets/naming.xml/ShortVariable"/>-->
-    <!--<rule ref="rulesets/naming.xml/LongVariable"/>-->
-    <!--<rule ref="rulesets/naming.xml/ShortMethodName"/>-->
-    <!--<rule ref="rulesets/naming.xml/VariableNamingConventions"/>-->
-    <!--<rule ref="rulesets/naming.xml/MethodNamingConventions"/>-->
-    <!--<rule ref="rulesets/naming.xml/ClassNamingConventions"/>-->
-    <!--<rule ref="rulesets/naming.xml/AbstractNaming"/>-->
-    <!--<rule ref="rulesets/naming.xml/AvoidDollarSigns"/>-->
-    <!--<rule ref="rulesets/naming.xml/MethodWithSameNameAsEnclosingClass"/>-->
-    <!--<rule ref="rulesets/naming.xml/SuspiciousHashcodeMethodName"/>-->
-    <!--<rule ref="rulesets/naming.xml/SuspiciousConstantFieldName"/>-->
-    <!--<rule ref="rulesets/naming.xml/AvoidFieldNameMatchingTypeName"/>-->
-    <!--<rule ref="rulesets/naming.xml/AvoidFieldNameMatchingMethodName"/>-->
-    <!--<rule ref="rulesets/naming.xml/AvoidNonConstructorMethodsWithClassName"/>-->
-    <!--<rule ref="rulesets/naming.xml/NoPackage"/>-->
-    <!--<rule ref="rulesets/naming.xml/PackageCase"/>-->
-
-    <!--<rule ref="rulesets/optimizations.xml/LocalVariableCouldBeFinal"/>-->
-    <!--<rule ref="rulesets/optimizations.xml/MethodArgumentCouldBeFinal"/>-->
-    <!--<rule ref="rulesets/optimizations.xml/AvoidInstantiatingObjectsInLoops"/>-->
-    <!--<rule ref="rulesets/optimizations.xml/UseArrayListInsteadOfVector"/>-->
-    <!--<rule ref="rulesets/optimizations.xml/SimplifyStartsWith"/>-->
-    <!--<rule ref="rulesets/optimizations.xml/UseStringBuilderForStringAppends"/>-->
-
-    <!--<rule ref="rulesets/strictexception.xml/AvoidCatchingThrowable"/>-->
-    <!--<rule ref="rulesets/strictexception.xml/SignatureDeclareThrowsException"/>-->
-    <!--<rule ref="rulesets/strictexception.xml/ExceptionAsFlowControl"/>-->
-    <!--<rule ref="rulesets/strictexception.xml/AvoidCatchingNPE"/>-->
-    <!--<rule ref="rulesets/strictexception.xml/AvoidThrowingRawExceptionTypes"/>-->
-    <!--<rule ref="rulesets/strictexception.xml/AvoidThrowingNullPointerException"/>-->
-
-    <!--<rule ref="rulesets/strings.xml/AvoidDuplicateLiterals"/>-->
-    <!--<rule ref="rulesets/strings.xml/StringInstantiation"/>-->
-    <!--<rule ref="rulesets/strings.xml/StringToString"/>-->
-    <!--<rule ref="rulesets/strings.xml/AvoidConcatenatingNonLiteralsInStringBuilder"/>-->
-    <!--<rule ref="rulesets/strings.xml/UnnecessaryCaseChange"/>-->
-
-    <!--<rule ref="rulesets/sunsecure.xml/MethodReturnsInternalArray"/>-->
-    <!--<rule ref="rulesets/sunsecure.xml/ArrayIsStoredDirectly"/>-->
-
-    <rule ref="rulesets/unusedcode.xml/UnusedLocalVariable"/>
-    <rule ref="rulesets/unusedcode.xml/UnusedPrivateField"/>
-    <rule ref="rulesets/unusedcode.xml/UnusedPrivateMethod"/>
-    <!--<rule ref="rulesets/unusedcode.xml/UnusedFormalParameter"/>-->
+<ruleset name="pmd-cxf-eclipse" xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 http://pmd.sourceforge.net/ruleset_2_0_0.xsd">
+    <description>CXF PMD Plugin preferences rule set</description>
+
+
+    <rule ref="rulesets/java/basic.xml/BooleanInstantiation"/>
+    <rule ref="rulesets/java/basic.xml/CollapsibleIfStatements"/>
+    <rule ref="rulesets/java/basic.xml/DoubleCheckedLocking"/>
+    <!--<rule ref="rulesets/java/basic.xml/EmptyCatchBlock"/>-->
+    <!--<rule ref="rulesets/java/basic.xml/EmptyFinallyBlock"/>-->
+    <!--<rule ref="rulesets/java/basic.xml/EmptyIfStmt"/>-->
+    <rule ref="rulesets/java/basic.xml/EmptyStatementNotInLoop"/>
+    <!--<rule ref="rulesets/java/basic.xml/EmptyStaticInitializer"/>-->
+    <!--<rule ref="rulesets/java/basic.xml/EmptySwitchStatements"/>-->
+    <!--<rule ref="rulesets/java/basic.xml/EmptySynchronizedBlock"/>-->
+    <!--<rule ref="rulesets/java/java/basic.xml/EmptyTryBlock"/>-->
+    <!--<rule ref="rulesets/java/basic.xml/EmptyWhileStmt"/>-->
+    <rule ref="rulesets/java/basic.xml/ForLoopShouldBeWhileLoop"/>
+    <rule ref="rulesets/java/basic.xml/JumbledIncrementer"/>
+    <!--<rule ref="rulesets/java/basic.xml/OverrideBothEqualsAndHashcode"/>-->
+    <rule ref="rulesets/java/basic.xml/ReturnFromFinallyBlock"/>
+    <rule ref="rulesets/java/basic.xml/UnconditionalIfStatement"/>
+    <rule ref="rulesets/java/basic.xml/UnnecessaryConversionTemporary"/>
+    <rule ref="rulesets/java/basic.xml/UnnecessaryFinalModifier"/>
+    <rule ref="rulesets/java/basic.xml/UnnecessaryReturn"/>
+    <!--<rule ref="rulesets/java/basic.xml/UselessOverridingMethod"/>-->
+
+    <!--<rule ref="rulesets/java/braces.xml/ForLoopsMustUseBraces"/>-->
+    <!--<rule ref="rulesets/java/braces.xml/IfElseStmtsMustUseBraces"/>-->
+    <!--<rule ref="rulesets/java/braces.xml/IfStmtsMustUseBraces"/>-->
+    <!--<rule ref="rulesets/java/braces.xml/WhileLoopsMustUseBraces"/>-->
+
+    <!--<rule ref="rulesets/java/clone.xml/CloneMethodMustImplementCloneable"/>-->
+    <!--<rule ref="rulesets/java/clone.xml/CloneThrowsCloneNotSupportedException"/>-->
+    <!--<rule ref="rulesets/java/clone.xml/ProperCloneImplementation"/>-->
+
+    <!--<rule ref="rulesets/java/codesize.xml/CyclomaticComplexity"/>-->
+    <!--<rule ref="rulesets/java/codesize.xml/ExcessiveClassLength"/>-->
+    <!--<rule ref="rulesets/java/codesize.xml/ExcessiveMethodLength"/>-->
+    <!--<rule ref="rulesets/java/codesize.xml/ExcessiveParameterList"/>-->
+    <!--<rule ref="rulesets/java/codesize.xml/ExcessivePublicCount"/>-->
+    <!--<rule ref="rulesets/java/codesize.xml/TooManyFields"/>-->
+
+    <!--<rule ref="rulesets/java/controversial.xml/AssignmentInOperand"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/AtLeastOneConstructor"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/CallSuperInConstructor"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/DontImportSun"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/NullAssignment"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/OnlyOneReturn"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/SingularField"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/SuspiciousOctalEscape"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/UnnecessaryConstructor"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/UnnecessaryParentheses"/>-->
+    <!--<rule ref="rulesets/java/controversial.xml/UnusedModifier"/>-->
+
+    <!--<rule ref="rulesets/java/coupling.xml/CouplingBetweenObjects"/>-->
+    <!--<rule ref="rulesets/java/coupling.xml/ExcessiveImports"/>-->
+    <!--<rule ref="rulesets/java/coupling.xml/LooseCoupling"/>-->
+
+    <!--<rule ref="rulesets/java/design.xml/AbstractClassWithoutAbstractMethod"/>-->
+    <!--<rule ref="rulesets/java/design.xml/AccessorClassGeneration"/>-->
+    <!--<rule ref="rulesets/java/design.xml/AssignmentToNonFinalStatic"/>-->
+    <!--<rule ref="rulesets/java/design.xml/AvoidDeeplyNestedIfStmts"/>-->
+    <!--<rule ref="rulesets/java/design.xml/AvoidInstanceofChecksInCatchClause"/>-->
+    <rule ref="rulesets/java/design.xml/AvoidProtectedFieldInFinalClass"/>
+    <!--<rule ref="rulesets/java/design.xml/AvoidReassigningParameters"/>-->
+    <!--<rule ref="rulesets/java/design.xml/AvoidSynchronizedAtMethodLevel"/>-->
+    <!--<rule ref="rulesets/java/design.xml/BadComparison"/>-->
+    <!--<rule ref="rulesets/java/design.xml/CloseConnection"/>-->
+    <!--<rule ref="rulesets/java/design.xml/CompareObjectsWithEquals"/>-->
+    <!--<rule ref="rulesets/java/design.xml/ConfusingTernary"/>-->
+    <rule ref="rulesets/java/design.xml/ConstructorCallsOverridableMethod"/>
+    <!--<rule ref="rulesets/java/design.xml/DefaultLabelNotLastInSwitchStmt"/>-->
+    <!--<rule ref="rulesets/java/design.xml/FinalFieldCouldBeStatic"/>-->
+    <rule ref="rulesets/java/design.xml/IdempotentOperations"/>
+    <!--<rule ref="rulesets/java/design.xml/ImmutableField"/>-->
+    <!--<rule ref="rulesets/java/design.xml/InstantiationToGetClass"/>-->
+    <!--<rule ref="rulesets/java/design.xml/MissingBreakInSwitch"/>-->
+    <!--<rule ref="rulesets/java/design.xml/MissingStaticMethodInNonInstantiatableClass"/>-->
+    <!--<rule ref="rulesets/java/design.xml/NonCaseLabelInSwitchStatement"/>-->
+    <!--<rule ref="rulesets/java/design.xml/NonStaticInitializer"/>-->
+    <rule ref="rulesets/java/design.xml/OptimizableToArrayCall"/>
+    <rule ref="rulesets/java/design.xml/PositionLiteralsFirstInComparisons"/>
+    <rule ref="rulesets/java/design.xml/SimplifyBooleanExpressions"/>
+    <rule ref="rulesets/java/design.xml/SimplifyBooleanReturns"/>
+    <rule ref="rulesets/java/design.xml/SimplifyConditional"/>
+    <!--<rule ref="rulesets/java/design.xml/SwitchDensity"/>-->
+    <!--<rule ref="rulesets/java/design.xml/SwitchStmtsShouldHaveDefault"/>-->
+    <rule ref="rulesets/java/design.xml/UnnecessaryLocalBeforeReturn"/>
+    <!--<rule ref="rulesets/java/design.xml/UseLocaleWithCaseConversions"/>-->
+    <!--<rule ref="rulesets/java/design.xml/UseNotifyAllInsteadOfNotify"/>-->
+    <!--<rule ref="rulesets/java/design.xml/UseSingleton"/>-->
+
+    <!--<rule ref="rulesets/java/finalizers.xml/EmptyFinalizer"/>-->
+    <!--<rule ref="rulesets/java/finalizers.xml/FinalizeOnlyCallsSuperFinalize"/>-->
+    <!--<rule ref="rulesets/java/finalizers.xml/FinalizeOverloaded"/>-->
+    <!--<rule ref="rulesets/java/finalizers.xml/FinalizeDoesNotCallSuperFinalize"/>-->
+    <!--<rule ref="rulesets/java/finalizers.xml/FinalizeShouldBeProtected"/>-->
+    <!--<rule ref="rulesets/java/finalizers.xml/AvoidCallingFinalize"/>-->
+
+    <!--<rule ref="rulesets/java/imports.xml/DuplicateImports"/>-->
+    <!--<rule ref="rulesets/java/imports.xml/DontImportJavaLang"/>-->
+    <!--<rule ref="rulesets/java/imports.xml/UnusedImports"/>-->
+    <!--<rule ref="rulesets/java/imports.xml/ImportFromSamePackage"/>-->
+
+    <!--<rule ref="rulesets/java/javabeans.xml/BeanMembersShouldSerialize"/>-->
+    <!--<rule ref="rulesets/java/javabeans.xml/MissingSerialVersionUID"/>-->
+
+    <!--<rule ref="rulesets/java/junit.xml/JUnitStaticSuite"/>-->
+    <!--<rule ref="rulesets/java/junit.xml/JUnitSpelling"/>-->
+    <!--<rule ref="rulesets/java/junit.xml/JUnitAssertionsShouldIncludeMessage"/>-->
+    <!--<rule ref="rulesets/java/junit.xml/JUnitTestsShouldIncludeAssert"/>-->
+    <!--<rule ref="rulesets/java/junit.xml/TestClassWithoutTestCases"/>-->
+    <!--<rule ref="rulesets/java/junit.xml/UnnecessaryBooleanAssertion"/>-->
+    <!--<rule ref="rulesets/java/junit.xml/UseAssertEqualsInsteadOfAssertTrue"/>-->
+    <!--<rule ref="rulesets/java/junit.xml/UseAssertSameInsteadOfAssertTrue"/>-->
+
+    <!--<rule ref="rulesets/java/logging-java.xml/AvoidPrintStackTrace"/>-->
+    <rule ref="rulesets/java/logging-java.xml/LoggerIsNotStaticFinal"/>
+    <!--<rule ref="rulesets/java/logging-java.xml/MoreThanOneLogger"/>-->
+    <!--<rule ref="rulesets/java/logging-java.xml/LoggerIsNotStaticFinal"/>-->
+    <!--<rule ref="rulesets/java/logging-java.xml/LogBlockWithoutIf"/>-->
+    <!--<rule ref="rulesets/java/logging-java.xml/SystemPrintln"/>-->
+    <!--<rule ref="rulesets/java/logging-jakarta-commons.xml/UseCorrectExceptionLogging"/>-->
+    <!--<rule ref="rulesets/java/logging-jakarta-commons.xml/ProperLogger"/>-->
+
+    <!--<rule ref="rulesets/java/naming.xml/ShortVariable"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/LongVariable"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/ShortMethodName"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/VariableNamingConventions"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/MethodNamingConventions"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/ClassNamingConventions"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/AbstractNaming"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/AvoidDollarSigns"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/MethodWithSameNameAsEnclosingClass"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/SuspiciousHashcodeMethodName"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/SuspiciousConstantFieldName"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/AvoidFieldNameMatchingTypeName"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/AvoidFieldNameMatchingMethodName"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/AvoidNonConstructorMethodsWithClassName"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/NoPackage"/>-->
+    <!--<rule ref="rulesets/java/naming.xml/PackageCase"/>-->
+
+    <!--<rule ref="rulesets/java/optimizations.xml/LocalVariableCouldBeFinal"/>-->
+    <!--<rule ref="rulesets/java/optimizations.xml/MethodArgumentCouldBeFinal"/>-->
+    <!--<rule ref="rulesets/java/optimizations.xml/AvoidInstantiatingObjectsInLoops"/>-->
+    <!--<rule ref="rulesets/java/optimizations.xml/UseArrayListInsteadOfVector"/>-->
+    <!--<rule ref="rulesets/java/optimizations.xml/SimplifyStartsWith"/>-->
+    <!--<rule ref="rulesets/java/optimizations.xml/UseStringBuilderForStringAppends"/>-->
+
+    <!--<rule ref="rulesets/java/strictexception.xml/AvoidCatchingThrowable"/>-->
+    <!--<rule ref="rulesets/java/strictexception.xml/SignatureDeclareThrowsException"/>-->
+    <!--<rule ref="rulesets/java/strictexception.xml/ExceptionAsFlowControl"/>-->
+    <!--<rule ref="rulesets/java/strictexception.xml/AvoidCatchingNPE"/>-->
+    <!--<rule ref="rulesets/java/strictexception.xml/AvoidThrowingRawExceptionTypes"/>-->
+    <!--<rule ref="rulesets/java/strictexception.xml/AvoidThrowingNullPointerException"/>-->
+
+    <!--<rule ref="rulesets/java/strings.xml/AvoidDuplicateLiterals"/>-->
+    <!--<rule ref="rulesets/java/strings.xml/StringInstantiation"/>-->
+    <!--<rule ref="rulesets/java/strings.xml/StringToString"/>-->
+    <!--<rule ref="rulesets/java/strings.xml/AvoidConcatenatingNonLiteralsInStringBuilder"/>-->
+    <!--<rule ref="rulesets/java/strings.xml/UnnecessaryCaseChange"/>-->
+
+    <!--<rule ref="rulesets/java/sunsecure.xml/MethodReturnsInternalArray"/>-->
+    <!--<rule ref="rulesets/java/sunsecure.xml/ArrayIsStoredDirectly"/>-->
+
+    <rule ref="rulesets/java/unusedcode.xml/UnusedLocalVariable"/>
+    <rule ref="rulesets/java/unusedcode.xml/UnusedPrivateField"/>
+    <rule ref="rulesets/java/unusedcode.xml/UnusedPrivateMethod"/>
+    <!--<rule ref="rulesets/java/unusedcode.xml/UnusedFormalParameter"/>-->
 
     <rule name="DontUseLoggerGetLogger"
           message="Don't use Logger.getLogger(...), use LogUtils.getL7dLogger(....) instead"
-          class="net.sourceforge.pmd.rules.XPathRule">
+          class="net.sourceforge.pmd.lang.rule.XPathRule"
+          language="java">
         <priority>2</priority>
         <description>Don't use Logger.getLogger(...), use LogUtils.getL7dLogger(....) instead</description>
         <properties>



Mime
View raw message