Return-Path: X-Original-To: apmail-cxf-commits-archive@www.apache.org Delivered-To: apmail-cxf-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 84EAF935A for ; Fri, 13 Jan 2012 19:36:19 +0000 (UTC) Received: (qmail 53412 invoked by uid 500); 13 Jan 2012 19:36:19 -0000 Delivered-To: apmail-cxf-commits-archive@cxf.apache.org Received: (qmail 53337 invoked by uid 500); 13 Jan 2012 19:36:18 -0000 Mailing-List: contact commits-help@cxf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cxf.apache.org Delivered-To: mailing list commits@cxf.apache.org Received: (qmail 53328 invoked by uid 99); 13 Jan 2012 19:36:18 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jan 2012 19:36:18 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jan 2012 19:36:13 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id B247B23889E1 for ; Fri, 13 Jan 2012 19:35:51 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1231266 - in /cxf/branches/2.5.x-fixes: ./ rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/ rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/ rt/bindings/corba/src/main/java/org/apache/cxf/binding/cor... Date: Fri, 13 Jan 2012 19:35:50 -0000 To: commits@cxf.apache.org From: dkulp@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120113193551.B247B23889E1@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: dkulp Date: Fri Jan 13 19:35:50 2012 New Revision: 1231266 URL: http://svn.apache.org/viewvc?rev=1231266&view=rev Log: Merged revisions 1229476 via svnmerge from https://svn.apache.org/repos/asf/cxf/trunk ........ r1229476 | dkulp | 2012-01-10 01:20:45 -0500 (Tue, 10 Jan 2012) | 2 lines Apparently the command line checkstyle is stricter than the in-eclipse version. Not sure why yet. ........ Modified: cxf/branches/2.5.x-fixes/ (props changed) cxf/branches/2.5.x-fixes/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaStreamWriter.java cxf/branches/2.5.x-fixes/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaObjectReferenceEventProducer.java cxf/branches/2.5.x-fixes/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/utils/CorbaObjectReferenceHelper.java cxf/branches/2.5.x-fixes/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/databinding/AegisDatabinding.java cxf/branches/2.5.x-fixes/rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/builders/InitiatorSignatureTokenBuilder.java cxf/branches/2.5.x-fixes/rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/builders/InitiatorTokenBuilder.java cxf/branches/2.5.x-fixes/tools/corba/src/test/java/org/apache/cxf/tools/corba/processors/WSDLToCorbaBindingTypeTest.java cxf/branches/2.5.x-fixes/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/MIMEBindingValidator.java cxf/branches/2.5.x-fixes/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSIBPValidator.java cxf/branches/2.5.x-fixes/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/generators/ClientGenerator.java cxf/branches/2.5.x-fixes/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/generators/ImplGenerator.java cxf/branches/2.5.x-fixes/tools/wsdlto/misc/src/main/java/org/apache/cxf/tools/misc/processor/WSDLToServiceProcessor.java cxf/branches/2.5.x-fixes/tools/wsdlto/misc/src/main/java/org/apache/cxf/tools/misc/processor/WSDLToSoapProcessor.java cxf/branches/2.5.x-fixes/tools/wsdlto/misc/src/main/java/org/apache/cxf/tools/misc/processor/WSDLToXMLProcessor.java Propchange: cxf/branches/2.5.x-fixes/ ------------------------------------------------------------------------------ --- svnmerge-integrated (original) +++ svnmerge-integrated Fri Jan 13 19:35:50 2012 @@ -1 +1 @@ -/cxf/trunk:1-1227739,1227823,1228209,1228228,1228230-1228231,1228268,1228277,1228359,1228770,1228850,1229348,1229663,1229965,1230800 +/cxf/trunk:1-1227739,1227823,1228209,1228228,1228230-1228231,1228268,1228277,1228359,1228770,1228850,1229348,1229476,1229663,1229965,1230800 Modified: cxf/branches/2.5.x-fixes/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaStreamWriter.java URL: http://svn.apache.org/viewvc/cxf/branches/2.5.x-fixes/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaStreamWriter.java?rev=1231266&r1=1231265&r2=1231266&view=diff ============================================================================== --- cxf/branches/2.5.x-fixes/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaStreamWriter.java (original) +++ cxf/branches/2.5.x-fixes/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaStreamWriter.java Fri Jan 13 19:35:50 2012 @@ -343,7 +343,7 @@ public class CorbaStreamWriter implement } public String getPrefix(String namespaceURI) { - for (Map.Entry entry: map.entrySet()) { + for (Map.Entry entry : map.entrySet()) { if (namespaceURI.equals(entry.getValue())) { return (String) entry.getKey(); } Modified: cxf/branches/2.5.x-fixes/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaObjectReferenceEventProducer.java URL: http://svn.apache.org/viewvc/cxf/branches/2.5.x-fixes/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaObjectReferenceEventProducer.java?rev=1231266&r1=1231265&r2=1231266&view=diff ============================================================================== --- cxf/branches/2.5.x-fixes/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaObjectReferenceEventProducer.java (original) +++ cxf/branches/2.5.x-fixes/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaObjectReferenceEventProducer.java Fri Jan 13 19:35:50 2012 @@ -144,7 +144,7 @@ public final class CorbaObjectReferenceE if (wsdlBinding == null && bindingName.getNamespaceURI().equals("") && !bindingName.getLocalPart().equals("")) { Collection bindingsCollection = CastUtils.cast(wsdlDef.getBindings().values()); - for (Binding b: bindingsCollection) { + for (Binding b : bindingsCollection) { if (b.getQName().getLocalPart().equals(bindingName.getLocalPart())) { wsdlBinding = b; break; Modified: cxf/branches/2.5.x-fixes/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/utils/CorbaObjectReferenceHelper.java URL: http://svn.apache.org/viewvc/cxf/branches/2.5.x-fixes/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/utils/CorbaObjectReferenceHelper.java?rev=1231266&r1=1231265&r2=1231266&view=diff ============================================================================== --- cxf/branches/2.5.x-fixes/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/utils/CorbaObjectReferenceHelper.java (original) +++ cxf/branches/2.5.x-fixes/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/utils/CorbaObjectReferenceHelper.java Fri Jan 13 19:35:50 2012 @@ -57,9 +57,9 @@ public final class CorbaObjectReferenceH public static QName getServiceName(Binding binding, Definition wsdlDef) { LOG.log(Level.FINE, "Getting service name for an object reference"); Collection services = CastUtils.cast(wsdlDef.getServices().values()); - for (Service serv: services) { + for (Service serv : services) { Collection ports = CastUtils.cast(serv.getPorts().values()); - for (Port pt: ports) { + for (Port pt : ports) { if (pt.getBinding().equals(binding)) { return serv.getQName(); } @@ -71,9 +71,9 @@ public final class CorbaObjectReferenceH public static String getEndpointName(Binding binding, Definition wsdlDef) { LOG.log(Level.FINE, "Getting endpoint name for an object reference"); Collection services = CastUtils.cast(wsdlDef.getServices().values()); - for (Service serv: services) { + for (Service serv : services) { Collection ports = CastUtils.cast(serv.getPorts().values()); - for (Port pt: ports) { + for (Port pt : ports) { if (pt.getBinding().equals(binding)) { return pt.getName(); } @@ -85,7 +85,7 @@ public final class CorbaObjectReferenceH public static Binding getDefaultBinding(Object obj, Definition wsdlDef) { LOG.log(Level.FINEST, "Getting binding for a default object reference"); Collection bindings = CastUtils.cast(wsdlDef.getBindings().values()); - for (Binding b: bindings) { + for (Binding b : bindings) { List extElements = b.getExtensibilityElements(); // Get the list of all extensibility elements for (Iterator extIter = extElements.iterator(); extIter.hasNext();) { Modified: cxf/branches/2.5.x-fixes/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/databinding/AegisDatabinding.java URL: http://svn.apache.org/viewvc/cxf/branches/2.5.x-fixes/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/databinding/AegisDatabinding.java?rev=1231266&r1=1231265&r2=1231266&view=diff ============================================================================== --- cxf/branches/2.5.x-fixes/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/databinding/AegisDatabinding.java (original) +++ cxf/branches/2.5.x-fixes/rt/databinding/aegis/src/main/java/org/apache/cxf/aegis/databinding/AegisDatabinding.java Fri Jan 13 19:35:50 2012 @@ -377,7 +377,7 @@ public class AegisDatabinding extends Ab return; } SchemaCollection col = s.getXmlSchemaCollection(); - for (MessagePartInfo part: container.getMessageParts()) { + for (MessagePartInfo part : container.getMessageParts()) { if (part.getXmlSchema() == null) { if (part.isElement()) { XmlSchemaAnnotated tp = col.getElementByQName(part.getElementQName()); Modified: cxf/branches/2.5.x-fixes/rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/builders/InitiatorSignatureTokenBuilder.java URL: http://svn.apache.org/viewvc/cxf/branches/2.5.x-fixes/rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/builders/InitiatorSignatureTokenBuilder.java?rev=1231266&r1=1231265&r2=1231266&view=diff ============================================================================== --- cxf/branches/2.5.x-fixes/rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/builders/InitiatorSignatureTokenBuilder.java (original) +++ cxf/branches/2.5.x-fixes/rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/builders/InitiatorSignatureTokenBuilder.java Fri Jan 13 19:35:50 2012 @@ -70,7 +70,7 @@ public class InitiatorSignatureTokenBuil } private void processAlternative(List assertions, InitiatorSignatureToken parent) { - for (Assertion token: assertions) { + for (Assertion token : assertions) { if (token instanceof Token) { parent.setInitiatorSignatureToken((Token)token); } Modified: cxf/branches/2.5.x-fixes/rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/builders/InitiatorTokenBuilder.java URL: http://svn.apache.org/viewvc/cxf/branches/2.5.x-fixes/rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/builders/InitiatorTokenBuilder.java?rev=1231266&r1=1231265&r2=1231266&view=diff ============================================================================== --- cxf/branches/2.5.x-fixes/rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/builders/InitiatorTokenBuilder.java (original) +++ cxf/branches/2.5.x-fixes/rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/builders/InitiatorTokenBuilder.java Fri Jan 13 19:35:50 2012 @@ -71,7 +71,7 @@ public class InitiatorTokenBuilder imple } private void processAlternative(List assertions, InitiatorToken parent) { - for (Assertion token: assertions) { + for (Assertion token : assertions) { if (token instanceof Token) { parent.setInitiatorToken((Token)token); } Modified: cxf/branches/2.5.x-fixes/tools/corba/src/test/java/org/apache/cxf/tools/corba/processors/WSDLToCorbaBindingTypeTest.java URL: http://svn.apache.org/viewvc/cxf/branches/2.5.x-fixes/tools/corba/src/test/java/org/apache/cxf/tools/corba/processors/WSDLToCorbaBindingTypeTest.java?rev=1231266&r1=1231265&r2=1231266&view=diff ============================================================================== --- cxf/branches/2.5.x-fixes/tools/corba/src/test/java/org/apache/cxf/tools/corba/processors/WSDLToCorbaBindingTypeTest.java (original) +++ cxf/branches/2.5.x-fixes/tools/corba/src/test/java/org/apache/cxf/tools/corba/processors/WSDLToCorbaBindingTypeTest.java Fri Jan 13 19:35:50 2012 @@ -578,8 +578,7 @@ public class WSDLToCorbaBindingTypeTest Iterator i = mapType.getStructOrExceptionOrUnion().iterator(); int strcnt = 0; int unioncnt = 0; - while (i.hasNext()) { - CorbaTypeImpl corbaType = (CorbaTypeImpl)i.next(); + for (CorbaTypeImpl corbaType : mapType.getStructOrExceptionOrUnion()) { if (corbaType instanceof Struct) { strcnt++; } Modified: cxf/branches/2.5.x-fixes/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/MIMEBindingValidator.java URL: http://svn.apache.org/viewvc/cxf/branches/2.5.x-fixes/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/MIMEBindingValidator.java?rev=1231266&r1=1231265&r2=1231266&view=diff ============================================================================== --- cxf/branches/2.5.x-fixes/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/MIMEBindingValidator.java (original) +++ cxf/branches/2.5.x-fixes/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/MIMEBindingValidator.java Fri Jan 13 19:35:50 2012 @@ -44,7 +44,7 @@ public class MIMEBindingValidator public boolean isValid() { Collection bindings = CastUtils.cast(def.getBindings().values()); - for (Binding binding: bindings) { + for (Binding binding : bindings) { Iterator itOperation = binding.getBindingOperations().iterator(); while (itOperation.hasNext()) { BindingOperation bindingOperation = (BindingOperation)itOperation.next(); @@ -106,6 +106,7 @@ public class MIMEBindingValidator private boolean doValidateMimeContentPartNames(Iterator mimeContents, String operationName) { // validate mime:content(s) in the mime:part as per R2909 String partName = null; + while (mimeContents.hasNext()) { MIMEContent mimeContent = (MIMEContent)mimeContents.next(); String mimeContnetPart = mimeContent.getPart(); Modified: cxf/branches/2.5.x-fixes/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSIBPValidator.java URL: http://svn.apache.org/viewvc/cxf/branches/2.5.x-fixes/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSIBPValidator.java?rev=1231266&r1=1231265&r2=1231266&view=diff ============================================================================== --- cxf/branches/2.5.x-fixes/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSIBPValidator.java (original) +++ cxf/branches/2.5.x-fixes/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSIBPValidator.java Fri Jan 13 19:35:50 2012 @@ -294,7 +294,7 @@ public class WSIBPValidator extends Abst public boolean checkR2203And2204() { Collection bindings = CastUtils.cast(def.getBindings().values()); - for (Binding binding: bindings) { + for (Binding binding : bindings) { String style = SOAPBindingUtil.getCanonicalBindingStyle(binding); @@ -365,7 +365,7 @@ public class WSIBPValidator extends Abst // TODO: Should also check SoapHeader/SoapHeaderFault public boolean checkR2205() { Collection bindings = CastUtils.cast(def.getBindings().values()); - for (Binding binding: bindings) { + for (Binding binding : bindings) { if (!SOAPBindingUtil.isSOAPBinding(binding)) { System.err.println("WSIBP Validator found <" @@ -399,7 +399,7 @@ public class WSIBPValidator extends Abst public boolean checkR2705() { Collection bindings = CastUtils.cast(def.getBindings().values()); - for (Binding binding: bindings) { + for (Binding binding : bindings) { if (SOAPBindingUtil.isMixedStyle(binding)) { addErrorMessage("Mixed style, invalid WSDL"); return false; Modified: cxf/branches/2.5.x-fixes/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/generators/ClientGenerator.java URL: http://svn.apache.org/viewvc/cxf/branches/2.5.x-fixes/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/generators/ClientGenerator.java?rev=1231266&r1=1231265&r2=1231266&view=diff ============================================================================== --- cxf/branches/2.5.x-fixes/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/generators/ClientGenerator.java (original) +++ cxf/branches/2.5.x-fixes/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/generators/ClientGenerator.java Fri Jan 13 19:35:50 2012 @@ -81,12 +81,8 @@ public class ClientGenerator extends Abs } Map interfaces = javaModel.getInterfaces(); - Iterator it = javaModel.getServiceClasses().values().iterator(); - while (it.hasNext()) { - JavaServiceClass js = (JavaServiceClass)it.next(); - Iterator i = js.getPorts().iterator(); - while (i.hasNext()) { - JavaPort jp = (JavaPort)i.next(); + for (JavaServiceClass js : javaModel.getServiceClasses().values()) { + for (JavaPort jp : js.getPorts()) { String interfaceName = jp.getInterfaceClass(); JavaInterface intf = interfaces.get(interfaceName); if (intf == null) { Modified: cxf/branches/2.5.x-fixes/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/generators/ImplGenerator.java URL: http://svn.apache.org/viewvc/cxf/branches/2.5.x-fixes/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/generators/ImplGenerator.java?rev=1231266&r1=1231265&r2=1231266&view=diff ============================================================================== --- cxf/branches/2.5.x-fixes/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/generators/ImplGenerator.java (original) +++ cxf/branches/2.5.x-fixes/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/generators/ImplGenerator.java Fri Jan 13 19:35:50 2012 @@ -89,8 +89,7 @@ public class ImplGenerator extends Abstr } } } else { - for (Iterator iter = interfaces.keySet().iterator(); iter.hasNext();) { - String interfaceName = (String)iter.next(); + for (String interfaceName : interfaces.keySet()) { JavaInterface intf = interfaces.get(interfaceName); outputImpl(intf, service, "", penv); } Modified: cxf/branches/2.5.x-fixes/tools/wsdlto/misc/src/main/java/org/apache/cxf/tools/misc/processor/WSDLToServiceProcessor.java URL: http://svn.apache.org/viewvc/cxf/branches/2.5.x-fixes/tools/wsdlto/misc/src/main/java/org/apache/cxf/tools/misc/processor/WSDLToServiceProcessor.java?rev=1231266&r1=1231265&r2=1231266&view=diff ============================================================================== --- cxf/branches/2.5.x-fixes/tools/wsdlto/misc/src/main/java/org/apache/cxf/tools/misc/processor/WSDLToServiceProcessor.java (original) +++ cxf/branches/2.5.x-fixes/tools/wsdlto/misc/src/main/java/org/apache/cxf/tools/misc/processor/WSDLToServiceProcessor.java Fri Jan 13 19:35:50 2012 @@ -71,7 +71,7 @@ public class WSDLToServiceProcessor exte if (services == null) { return false; } - for (QName serviceQName: services.keySet()) { + for (QName serviceQName : services.keySet()) { String serviceName = serviceQName.getLocalPart(); if (serviceName.equals(env.get(ToolConstants.CFG_SERVICE))) { service = (Service)services.get(serviceQName); @@ -86,7 +86,7 @@ public class WSDLToServiceProcessor exte if (ports == null) { return false; } - for (String portName: ports.keySet()) { + for (String portName : ports.keySet()) { if (portName.equals(env.get(ToolConstants.CFG_PORT))) { port = ports.get(portName); break; @@ -100,7 +100,7 @@ public class WSDLToServiceProcessor exte if (bindings == null) { return false; } - for (QName bindingQName: bindings.keySet()) { + for (QName bindingQName : bindings.keySet()) { String bindingName = bindingQName.getLocalPart(); String attrBinding = (String)env.get(ToolConstants.CFG_BINDING_ATTR); if (attrBinding.equals(bindingName)) { Modified: cxf/branches/2.5.x-fixes/tools/wsdlto/misc/src/main/java/org/apache/cxf/tools/misc/processor/WSDLToSoapProcessor.java URL: http://svn.apache.org/viewvc/cxf/branches/2.5.x-fixes/tools/wsdlto/misc/src/main/java/org/apache/cxf/tools/misc/processor/WSDLToSoapProcessor.java?rev=1231266&r1=1231265&r2=1231266&view=diff ============================================================================== --- cxf/branches/2.5.x-fixes/tools/wsdlto/misc/src/main/java/org/apache/cxf/tools/misc/processor/WSDLToSoapProcessor.java (original) +++ cxf/branches/2.5.x-fixes/tools/wsdlto/misc/src/main/java/org/apache/cxf/tools/misc/processor/WSDLToSoapProcessor.java Fri Jan 13 19:35:50 2012 @@ -90,7 +90,7 @@ public class WSDLToSoapProcessor extends Input input = op.getInput(); if (input != null && input.getMessage() != null) { Collection parts = CastUtils.cast(input.getMessage().getParts().values()); - for (Part part: parts) { + for (Part part : parts) { if (part.getTypeName() == null || "".equals(part.getTypeName().toString())) { Message msg = new Message("RPC_PART_ILLEGAL", LOG, new Object[] {part.getName()}); throw new ToolException(msg); @@ -100,7 +100,7 @@ public class WSDLToSoapProcessor extends Output output = op.getOutput(); if (output != null && output.getMessage() != null) { Collection parts = CastUtils.cast(output.getMessage().getParts().values()); - for (Part part: parts) { + for (Part part : parts) { if (part.getTypeName() == null || "".equals(part.getTypeName().toString())) { Message msg = new Message("RPC_PART_ILLEGAL", LOG, new Object[] {part.getName()}); throw new ToolException(msg); Modified: cxf/branches/2.5.x-fixes/tools/wsdlto/misc/src/main/java/org/apache/cxf/tools/misc/processor/WSDLToXMLProcessor.java URL: http://svn.apache.org/viewvc/cxf/branches/2.5.x-fixes/tools/wsdlto/misc/src/main/java/org/apache/cxf/tools/misc/processor/WSDLToXMLProcessor.java?rev=1231266&r1=1231265&r2=1231266&view=diff ============================================================================== --- cxf/branches/2.5.x-fixes/tools/wsdlto/misc/src/main/java/org/apache/cxf/tools/misc/processor/WSDLToXMLProcessor.java (original) +++ cxf/branches/2.5.x-fixes/tools/wsdlto/misc/src/main/java/org/apache/cxf/tools/misc/processor/WSDLToXMLProcessor.java Fri Jan 13 19:35:50 2012 @@ -118,7 +118,7 @@ public class WSDLToXMLProcessor extends if (portTypes == null) { return false; } - for (QName existPortQName: portTypes.keySet()) { + for (QName existPortQName : portTypes.keySet()) { String existPortName = existPortQName.getLocalPart(); if (existPortName.equals(env.get(ToolConstants.CFG_PORTTYPE))) { portType = portTypes.get(existPortQName);