cxf-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dk...@apache.org
Subject svn commit: r760073 - in /cxf/trunk/rt: frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/ management/src/main/java/org/apache/cxf/management/counters/ management/src/main/java/org/apache/cxf/management/interceptor/ management/src/main/java/org/a...
Date Mon, 30 Mar 2009 18:03:09 GMT
Author: dkulp
Date: Mon Mar 30 18:03:08 2009
New Revision: 760073

URL: http://svn.apache.org/viewvc?rev=760073&view=rev
Log:
[CXF-2140, CXF-2141] Patches to enhance the mgmt stuff from Cyrille Le Clerc applied.
Add ability to specify the mbean server directly
Add fault counting to response time counter stuff

Modified:
    cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/InjectionUtils.java
    cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/counters/MessageHandlingTimeRecorder.java
    cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/counters/ResponseTimeCounter.java
    cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/counters/ResponseTimeCounterMBean.java
    cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/AbstractMessageResponseTimeInterceptor.java
    cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/ResponseTimeMessageInInterceptor.java
    cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/ResponseTimeMessageInvokerInterceptor.java
    cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/ResponseTimeMessageOutInterceptor.java
    cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/jmx/InstrumentationManagerImpl.java
    cxf/trunk/rt/management/src/test/java/org/apache/cxf/management/counters/CounterRepositoryTest.java
    cxf/trunk/rt/management/src/test/java/org/apache/cxf/management/interceptor/ResponseTimeMessageInInterceptorTest.java
    cxf/trunk/rt/management/src/test/java/org/apache/cxf/management/interceptor/ResponseTimeMessageOutInterceptorTest.java

Modified: cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/InjectionUtils.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/InjectionUtils.java?rev=760073&r1=760072&r2=760073&view=diff
==============================================================================
--- cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/InjectionUtils.java
(original)
+++ cxf/trunk/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/InjectionUtils.java
Mon Mar 30 18:03:08 2009
@@ -325,7 +325,6 @@
         return theValues;
     }
     
-    @SuppressWarnings("unchecked")
     public static Object injectIntoArray(Type genericType, List<String> values,
                                          boolean decoded, ParameterType pathParam, Message
message) {
         Class<?> realType = InjectionUtils.getActualType(genericType);

Modified: cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/counters/MessageHandlingTimeRecorder.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/counters/MessageHandlingTimeRecorder.java?rev=760073&r1=760072&r2=760073&view=diff
==============================================================================
--- cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/counters/MessageHandlingTimeRecorder.java
(original)
+++ cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/counters/MessageHandlingTimeRecorder.java
Mon Mar 30 18:03:08 2009
@@ -20,12 +20,14 @@
 package org.apache.cxf.management.counters;
 
 import org.apache.cxf.message.Exchange;
+import org.apache.cxf.message.FaultMode;
 
 /* recoder the message actually handle begin and end time */ 
 public class MessageHandlingTimeRecorder {
     private Exchange exchange;
     private long beginTime;
     private long endTime;
+    private FaultMode faultMode;
     private boolean oneWay;
     
     public MessageHandlingTimeRecorder(Exchange ex) {
@@ -61,4 +63,11 @@
         return endTime - beginTime;
     }
 
+    public FaultMode getFaultMode() {
+        return faultMode;
+    }
+
+    public void setFaultMode(FaultMode faultMode) {
+        this.faultMode = faultMode;
+    }
 }

Modified: cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/counters/ResponseTimeCounter.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/counters/ResponseTimeCounter.java?rev=760073&r1=760072&r2=760073&view=diff
==============================================================================
--- cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/counters/ResponseTimeCounter.java
(original)
+++ cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/counters/ResponseTimeCounter.java
Mon Mar 30 18:03:08 2009
@@ -23,10 +23,16 @@
 
 import javax.management.ObjectName;
 
+import org.apache.cxf.message.FaultMode;
+
 public class ResponseTimeCounter implements ResponseTimeCounterMBean, Counter {    
     
     private ObjectName objectName;
     private AtomicInteger invocations = new AtomicInteger();
+    private AtomicInteger checkedApplicationFaults = new AtomicInteger();
+    private AtomicInteger unCheckedApplicationFaults = new AtomicInteger();
+    private AtomicInteger runtimeFaults = new AtomicInteger();
+    private AtomicInteger logicalRuntimeFaults = new AtomicInteger();
     private long totalHandlingTime;    
     private long maxHandlingTime;
     private long minHandlingTime = Integer.MAX_VALUE;
@@ -37,6 +43,29 @@
     
     public void  increase(MessageHandlingTimeRecorder mhtr) {
         invocations.getAndIncrement();
+        FaultMode faultMode = mhtr.getFaultMode();
+        if (null == faultMode) {
+            // no exception occured
+        } else {
+            switch (faultMode) {
+            case CHECKED_APPLICATION_FAULT:
+                checkedApplicationFaults.incrementAndGet();
+                break;
+            case LOGICAL_RUNTIME_FAULT:
+                logicalRuntimeFaults.incrementAndGet();
+                break;
+            case RUNTIME_FAULT:
+                runtimeFaults.incrementAndGet();
+                break;
+            case UNCHECKED_APPLICATION_FAULT:
+                unCheckedApplicationFaults.incrementAndGet();
+                break;
+            default:
+                runtimeFaults.incrementAndGet();
+                break;
+            }
+        }
+        
         long handlingTime = 0;
         if (mhtr.isOneWay()) {
             // We can count the response time 
@@ -53,11 +82,9 @@
         }
         if (minHandlingTime > handlingTime) {
             minHandlingTime = handlingTime;
-        }         
+        }
     }
     
-    
-    
     public ObjectName getObjectName() {
         return objectName;
     }
@@ -65,7 +92,6 @@
     public Number getAvgResponseTime() {        
         return (int)(totalHandlingTime / invocations.get());
     }
-
     
     public Number getMaxResponseTime() {        
         return maxHandlingTime;
@@ -79,7 +105,24 @@
         return invocations.get();
     }
 
-    public Number getTotalHandlingTime() {
-        return totalHandlingTime;
+    public Number getNumCheckedApplicationFaults() {
+        return checkedApplicationFaults.get();
     }
+
+    public Number getNumLogicalRuntimeFaults() {
+        return logicalRuntimeFaults.get();
+    }
+    
+    public Number getNumRuntimeFaults() {
+        return runtimeFaults.get();
+    }
+    
+    public Number getNumUnCheckedApplicationFaults() {
+        return unCheckedApplicationFaults.get();
+    }
+    
+    public Number getTotalHandlingTime() {        
+        return totalHandlingTime;
+    }  
+
 }

Modified: cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/counters/ResponseTimeCounterMBean.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/counters/ResponseTimeCounterMBean.java?rev=760073&r1=760072&r2=760073&view=diff
==============================================================================
--- cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/counters/ResponseTimeCounterMBean.java
(original)
+++ cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/counters/ResponseTimeCounterMBean.java
Mon Mar 30 18:03:08 2009
@@ -20,8 +20,12 @@
 
 public interface ResponseTimeCounterMBean {   
     Number getNumInvocations();
+    Number getNumCheckedApplicationFaults();
+    Number getNumLogicalRuntimeFaults();
+    Number getNumRuntimeFaults();
+    Number getNumUnCheckedApplicationFaults();
     Number getAvgResponseTime();
     Number getMaxResponseTime();
-    Number getMinResponseTime();
-    Number getTotalHandlingTime();    
-}
+    Number getMinResponseTime();   
+    Number getTotalHandlingTime();
+}
\ No newline at end of file

Modified: cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/AbstractMessageResponseTimeInterceptor.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/AbstractMessageResponseTimeInterceptor.java?rev=760073&r1=760072&r2=760073&view=diff
==============================================================================
--- cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/AbstractMessageResponseTimeInterceptor.java
(original)
+++ cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/AbstractMessageResponseTimeInterceptor.java
Mon Mar 30 18:03:08 2009
@@ -33,6 +33,7 @@
 import org.apache.cxf.management.counters.CounterRepository;
 import org.apache.cxf.management.counters.MessageHandlingTimeRecorder;
 import org.apache.cxf.message.Exchange;
+import org.apache.cxf.message.FaultMode;
 import org.apache.cxf.message.Message;
 import org.apache.cxf.phase.AbstractPhaseInterceptor;
 import org.apache.cxf.service.Service;
@@ -41,7 +42,7 @@
 public abstract class AbstractMessageResponseTimeInterceptor extends AbstractPhaseInterceptor<Message>
{
     private static final Logger LOG = LogUtils.getL7dLogger(AbstractMessageResponseTimeInterceptor.class);
     
-    public AbstractMessageResponseTimeInterceptor(String phase) {
+    AbstractMessageResponseTimeInterceptor(String phase) {
         super(phase);
     }
     
@@ -68,7 +69,8 @@
         }
         MessageHandlingTimeRecorder mhtr = ex.get(MessageHandlingTimeRecorder.class);
         if (null != mhtr) {
-            mhtr.endHandling();            
+            mhtr.endHandling();
+            mhtr.setFaultMode(ex.get(FaultMode.class));
             increaseCounter(ex, mhtr);
                         
         } // else can't get the MessageHandling Infor  

Modified: cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/ResponseTimeMessageInInterceptor.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/ResponseTimeMessageInInterceptor.java?rev=760073&r1=760072&r2=760073&view=diff
==============================================================================
--- cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/ResponseTimeMessageInInterceptor.java
(original)
+++ cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/ResponseTimeMessageInInterceptor.java
Mon Mar 30 18:03:08 2009
@@ -21,6 +21,7 @@
 
 import org.apache.cxf.interceptor.Fault;
 import org.apache.cxf.message.Exchange;
+import org.apache.cxf.message.FaultMode;
 import org.apache.cxf.message.Message;
 import org.apache.cxf.phase.Phase;
 
@@ -38,6 +39,12 @@
         } else {            
             beginHandlingMessage(ex);            
         }
-    }
+    }    
     
+    @Override
+    public void handleFault(Message message) {
+        Exchange ex = message.getExchange();
+        ex.put(FaultMode.class, message.get(FaultMode.class));
+        endHandlingMessage(ex);
+    }
 }

Modified: cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/ResponseTimeMessageInvokerInterceptor.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/ResponseTimeMessageInvokerInterceptor.java?rev=760073&r1=760072&r2=760073&view=diff
==============================================================================
--- cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/ResponseTimeMessageInvokerInterceptor.java
(original)
+++ cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/ResponseTimeMessageInvokerInterceptor.java
Mon Mar 30 18:03:08 2009
@@ -22,27 +22,35 @@
 import org.apache.cxf.interceptor.Fault;
 import org.apache.cxf.interceptor.ServiceInvokerInterceptor;
 import org.apache.cxf.message.Exchange;
+import org.apache.cxf.message.FaultMode;
 import org.apache.cxf.message.Message;
 import org.apache.cxf.phase.Phase;
 
 /* When the message get from the server side
  * The exchange.isOneWay() is workable when the message
  * handler by the binging interceptor  
- * */ 
-public class ResponseTimeMessageInvokerInterceptor 
-    extends AbstractMessageResponseTimeInterceptor {
-      
+ * */
+public class ResponseTimeMessageInvokerInterceptor extends AbstractMessageResponseTimeInterceptor
{
+    
     public ResponseTimeMessageInvokerInterceptor() {
         super(Phase.INVOKE);
-        //this interceptor should be add before the serviceInvokerInterceptor
+        // this interceptor should be add before the serviceInvokerInterceptor
         addBefore(ServiceInvokerInterceptor.class.getName());
     }
-
+    
     public void handleMessage(Message message) throws Fault {
         Exchange ex = message.getExchange();
         if (ex.isOneWay()) {
-            setOneWayMessage(ex); 
+            setOneWayMessage(ex);
+        }
+    }
+    
+    @Override
+    public void handleFault(Message message) {
+        Exchange ex = message.getExchange();
+        ex.put(FaultMode.class, message.get(FaultMode.class));
+        if (ex.isOneWay()) {
+            endHandlingMessage(ex);
         }
     }
-
 }

Modified: cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/ResponseTimeMessageOutInterceptor.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/ResponseTimeMessageOutInterceptor.java?rev=760073&r1=760072&r2=760073&view=diff
==============================================================================
--- cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/ResponseTimeMessageOutInterceptor.java
(original)
+++ cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/interceptor/ResponseTimeMessageOutInterceptor.java
Mon Mar 30 18:03:08 2009
@@ -20,6 +20,7 @@
 
 import org.apache.cxf.interceptor.Fault;
 import org.apache.cxf.message.Exchange;
+import org.apache.cxf.message.FaultMode;
 import org.apache.cxf.message.Message;
 import org.apache.cxf.phase.Phase;
 
@@ -35,10 +36,26 @@
             if (ex.isOneWay()) {
                 setOneWayMessage(ex);
             } else {
-                beginHandlingMessage(ex); 
+                beginHandlingMessage(ex);
             }
         } else { // the message is handled by server
             endHandlingMessage(ex);
         }
     }
+    
+    @Override
+    public void handleFault(Message message) {
+        Exchange ex = message.getExchange();
+        if (ex.isOneWay()) {
+            // do nothing, done by the ResponseTimeInvokerInterceptor
+        } else {
+            FaultMode faultMode = message.get(FaultMode.class);
+            if (faultMode == null) {
+                // client side exceptions don't have FaultMode set un the message properties
(as of 2.1.4)
+                faultMode = FaultMode.RUNTIME_FAULT;
+            }
+            ex.put(FaultMode.class, faultMode);
+            endHandlingMessage(ex);
+        }
+    }
 }

Modified: cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/jmx/InstrumentationManagerImpl.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/jmx/InstrumentationManagerImpl.java?rev=760073&r1=760072&r2=760073&view=diff
==============================================================================
--- cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/jmx/InstrumentationManagerImpl.java
(original)
+++ cxf/trunk/rt/management/src/main/java/org/apache/cxf/management/jmx/InstrumentationManagerImpl.java
Mon Mar 30 18:03:08 2009
@@ -46,13 +46,13 @@
 import org.apache.cxf.buslifecycle.BusLifeCycleListener;
 import org.apache.cxf.buslifecycle.BusLifeCycleManager;
 import org.apache.cxf.common.logging.LogUtils;
+import org.apache.cxf.helpers.CastUtils;
 import org.apache.cxf.management.InstrumentationManager;
 import org.apache.cxf.management.JMXConnectorPolicyType;
 import org.apache.cxf.management.ManagedComponent;
 import org.apache.cxf.management.ManagementConstants;
 import org.apache.cxf.management.jmx.export.runtime.ModelMBeanAssembler;
 
-
 /**
  * The manager class for the JMXManagedComponent which hosts the JMXManagedComponents.
  */
@@ -66,6 +66,10 @@
     private Set<ObjectName> busMBeans = new HashSet<ObjectName>();
     private ModelMBeanAssembler assembler;
     private boolean connectFailed;
+    /**
+     * For backward compatibility, {@link #createMBServerConnectorFactory} is <code>true</code>
by default.
+     */
+    private boolean createMBServerConnectorFactory = true;
     private String mbeanServerName = ManagementConstants.DEFAULT_DOMAIN_NAME;
     private boolean usePlatformMBeanServer;
     
@@ -86,6 +90,11 @@
     public void setServerName(String s) {
         mbeanServerName = s;
     }
+    
+    public void setCreateMBServerConnectorFactory(boolean createMBServerConnectorFactory)
{
+        this.createMBServerConnectorFactory = createMBServerConnectorFactory;
+    }
+    
     public void setUsePlatformMBeanServer(Boolean flag) {
         usePlatformMBeanServer = flag;
     }
@@ -105,28 +114,34 @@
     public void init() {    
         if (isEnabled()) {
             
-            // return platform mbean server if the option is specified.
-            if (usePlatformMBeanServer) {
-                mbs = ManagementFactory.getPlatformMBeanServer();
-            } else {
-                List servers = MBeanServerFactory.findMBeanServer(mbeanServerName);
-                if (servers.size() <= 1) {
-                    mbs = MBeanServerFactory.createMBeanServer(mbeanServerName);
+            if (mbs == null) {
+                // return platform mbean server if the option is specified.
+                if (usePlatformMBeanServer) {
+                    mbs = ManagementFactory.getPlatformMBeanServer();
                 } else {
-                    mbs = (MBeanServer)servers.get(0);
+                    List<MBeanServer> servers = CastUtils
+                        .cast(MBeanServerFactory.findMBeanServer(mbeanServerName));
+                    if (servers.size() <= 1) {
+                        mbs = MBeanServerFactory.createMBeanServer(mbeanServerName);
+                    } else {
+                        mbs = (MBeanServer)servers.get(0);
+                    }
+                }
+            }
+            
+            if (createMBServerConnectorFactory) {
+                mcf = MBServerConnectorFactory.getInstance();
+                mcf.setMBeanServer(mbs);
+                mcf.setThreaded(isThreaded());
+                mcf.setDaemon(isDaemon());
+                mcf.setServiceUrl(getJMXServiceURL());
+                try {
+                    mcf.createConnector();
+                } catch (IOException ex) {
+                    connectFailed = true;
+                    LOG.log(Level.SEVERE, "START_CONNECTOR_FAILURE_MSG", new Object[] {ex});
                 }
             }
-            mcf = MBServerConnectorFactory.getInstance();
-            mcf.setMBeanServer(mbs);
-            mcf.setThreaded(isThreaded());
-            mcf.setDaemon(isDaemon());
-            mcf.setServiceUrl(getJMXServiceURL());
-            try {            
-                mcf.createConnector();                
-            } catch (IOException ex) {
-                connectFailed = true;
-                LOG.log(Level.SEVERE, "START_CONNECTOR_FAILURE_MSG", new Object[]{ex});
-            }              
 
             if (!connectFailed && null != bus) {            
                 try {
@@ -191,17 +206,23 @@
     public MBeanServer getMBeanServer() {        
         return mbs;
     }
+
+    public void setServer(MBeanServer server) {
+        this.mbs = server;
+    }
     
     public void shutdown() {
         if (!isEnabled()) {
             return;           
         }
         
-        try {
-            mcf.destroy();
-        } catch (IOException ex) {
-            LOG.log(Level.SEVERE, "STOP_CONNECTOR_FAILURE_MSG", new Object[]{ex});
-        }   
+        if (mcf != null) {
+            try {
+                mcf.destroy();
+            } catch (IOException ex) {
+                LOG.log(Level.SEVERE, "STOP_CONNECTOR_FAILURE_MSG", new Object[] {ex});
+            }
+        }
     }
 
     public void initComplete() {

Modified: cxf/trunk/rt/management/src/test/java/org/apache/cxf/management/counters/CounterRepositoryTest.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/management/src/test/java/org/apache/cxf/management/counters/CounterRepositoryTest.java?rev=760073&r1=760072&r2=760073&view=diff
==============================================================================
--- cxf/trunk/rt/management/src/test/java/org/apache/cxf/management/counters/CounterRepositoryTest.java
(original)
+++ cxf/trunk/rt/management/src/test/java/org/apache/cxf/management/counters/CounterRepositoryTest.java
Mon Mar 30 18:03:08 2009
@@ -54,7 +54,7 @@
         EasyMock.expect(mhtr.isOneWay()).andReturn(true).anyTimes();
         EasyMock.expect(mhtr.getEndTime()).andReturn((long)100000000).anyTimes();
         EasyMock.expect(mhtr.getHandlingTime()).andReturn((long)1000).anyTimes();
-        
+        EasyMock.expect(mhtr.getFaultMode()).andReturn(null).anyTimes();
         EasyMock.replay(mhtr);
         cr.increaseCounter(serviceCounter, mhtr);
         cr.increaseCounter(operationCounter, mhtr);
@@ -77,6 +77,7 @@
         MessageHandlingTimeRecorder mhtr = EasyMock.createMock(MessageHandlingTimeRecorder.class);
         EasyMock.expect(mhtr.isOneWay()).andReturn(true).anyTimes();
         EasyMock.expect(mhtr.getEndTime()).andReturn((long)0).anyTimes();
+        EasyMock.expect(mhtr.getFaultMode()).andReturn(null).anyTimes();
         EasyMock.replay(mhtr);
         cr.increaseCounter(serviceCounter, mhtr);
         cr.increaseCounter(operationCounter, mhtr);
@@ -98,6 +99,7 @@
         MessageHandlingTimeRecorder mhtr1 = EasyMock.createMock(MessageHandlingTimeRecorder.class);
         EasyMock.expect(mhtr1.isOneWay()).andReturn(false).anyTimes();
         EasyMock.expect(mhtr1.getHandlingTime()).andReturn((long)1000).anyTimes();
+        EasyMock.expect(mhtr1.getFaultMode()).andReturn(null).anyTimes();
         EasyMock.replay(mhtr1);
         cr.createCounter(operationCounter, mhtr1);
         cr.increaseCounter(serviceCounter, mhtr1);
@@ -117,6 +119,7 @@
         MessageHandlingTimeRecorder mhtr2 = EasyMock.createMock(MessageHandlingTimeRecorder.class);
         EasyMock.expect(mhtr2.isOneWay()).andReturn(false).anyTimes();
         EasyMock.expect(mhtr2.getHandlingTime()).andReturn((long)2000).anyTimes();
+        EasyMock.expect(mhtr2.getFaultMode()).andReturn(null).anyTimes();
         EasyMock.replay(mhtr2);
         cr.increaseCounter(serviceCounter, mhtr2);
         cr.increaseCounter(operationCounter, mhtr2);

Modified: cxf/trunk/rt/management/src/test/java/org/apache/cxf/management/interceptor/ResponseTimeMessageInInterceptorTest.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/management/src/test/java/org/apache/cxf/management/interceptor/ResponseTimeMessageInInterceptorTest.java?rev=760073&r1=760072&r2=760073&view=diff
==============================================================================
--- cxf/trunk/rt/management/src/test/java/org/apache/cxf/management/interceptor/ResponseTimeMessageInInterceptorTest.java
(original)
+++ cxf/trunk/rt/management/src/test/java/org/apache/cxf/management/interceptor/ResponseTimeMessageInInterceptorTest.java
Mon Mar 30 18:03:08 2009
@@ -20,6 +20,7 @@
 package org.apache.cxf.management.interceptor;
 
 import org.apache.cxf.management.counters.MessageHandlingTimeRecorder;
+import org.apache.cxf.message.FaultMode;
 import org.apache.cxf.message.Message;
 import org.apache.cxf.message.MessageImpl;
 import org.easymock.classextension.EasyMock;
@@ -37,9 +38,12 @@
         EasyMock.expect(message.getExchange()).andReturn(exchange);
         EasyMock.expect(message.get(Message.REQUESTOR_ROLE)).andReturn(Boolean.TRUE).anyTimes();
         EasyMock.expect(exchange.getOutMessage()).andReturn(message);
+        EasyMock.expect(exchange.get(FaultMode.class)).andReturn(null);
         MessageHandlingTimeRecorder mhtr = EasyMock.createMock(MessageHandlingTimeRecorder.class);
         mhtr.endHandling();
-        EasyMock.expectLastCall();              
+        EasyMock.expectLastCall();        
+        mhtr.setFaultMode(null);
+        EasyMock.expectLastCall();
          
         EasyMock.replay(mhtr);
         EasyMock.expect(exchange.get(MessageHandlingTimeRecorder.class)).andReturn(mhtr);
       
@@ -54,7 +58,58 @@
         EasyMock.verify(cRepository);
         
     }
-    
+
+    @Test
+    public void testClientCheckedApplicationFaultMessageIn() {
+        testClientFaultMessageIn(FaultMode.CHECKED_APPLICATION_FAULT);
+    }
+
+    @Test
+    public void testClientLogicalFaultMessageIn() {
+        testClientFaultMessageIn(FaultMode.LOGICAL_RUNTIME_FAULT);
+    }
+
+    @Test
+    public void testClientRuntimeFaultMessageIn() {
+        testClientFaultMessageIn(FaultMode.RUNTIME_FAULT);
+    }
+
+    @Test
+    public void testClientUncheckedApplicationFaultMessageIn() {
+        testClientFaultMessageIn(FaultMode.UNCHECKED_APPLICATION_FAULT);
+    }
+
+    public void testClientFaultMessageIn(FaultMode faultMode) {
+        // need to increase the counter and is a client
+        setupCounterRepository(true, true);
+        setupExchangeForMessage();
+        EasyMock.expect(message.getExchange()).andReturn(exchange);
+        EasyMock.expect(message.get(Message.REQUESTOR_ROLE)).andReturn(Boolean.TRUE).anyTimes();
+        EasyMock.expect(message.get(FaultMode.class)).andReturn(faultMode).anyTimes();
+        EasyMock.expect(exchange.getOutMessage()).andReturn(message);
+        exchange.put(FaultMode.class, faultMode);
+        EasyMock.expectLastCall();
+        EasyMock.expect(exchange.get(FaultMode.class)).andReturn(faultMode).anyTimes();
+        MessageHandlingTimeRecorder mhtr = EasyMock.createMock(MessageHandlingTimeRecorder.class);
+        mhtr.endHandling();
+        EasyMock.expectLastCall();        
+        mhtr.setFaultMode(faultMode);
+        EasyMock.expectLastCall();
+         
+        EasyMock.replay(mhtr);
+        EasyMock.expect(exchange.get(MessageHandlingTimeRecorder.class)).andReturn(mhtr);
       
+        EasyMock.replay(exchange);
+        EasyMock.replay(message);
+        
+        rtmii.handleFault(message);
+        EasyMock.verify(message);
+        EasyMock.verify(bus);
+        EasyMock.verify(exchange);
+        EasyMock.verify(mhtr);
+        EasyMock.verify(cRepository);
+        
+    }
+
     
     // it would not fire the counter increase action now
     @Test

Modified: cxf/trunk/rt/management/src/test/java/org/apache/cxf/management/interceptor/ResponseTimeMessageOutInterceptorTest.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/management/src/test/java/org/apache/cxf/management/interceptor/ResponseTimeMessageOutInterceptorTest.java?rev=760073&r1=760072&r2=760073&view=diff
==============================================================================
--- cxf/trunk/rt/management/src/test/java/org/apache/cxf/management/interceptor/ResponseTimeMessageOutInterceptorTest.java
(original)
+++ cxf/trunk/rt/management/src/test/java/org/apache/cxf/management/interceptor/ResponseTimeMessageOutInterceptorTest.java
Mon Mar 30 18:03:08 2009
@@ -19,6 +19,7 @@
 
 package org.apache.cxf.management.interceptor;
 import org.apache.cxf.management.counters.MessageHandlingTimeRecorder;
+import org.apache.cxf.message.FaultMode;
 import org.apache.cxf.message.Message;
 import org.easymock.classextension.EasyMock;
 import org.junit.Test;
@@ -34,7 +35,10 @@
         EasyMock.expect(message.getExchange()).andReturn(exchange);
         EasyMock.expect(message.get(Message.REQUESTOR_ROLE)).andReturn(Boolean.FALSE).anyTimes();
         EasyMock.expect(exchange.getOutMessage()).andReturn(message);
+        EasyMock.expect(exchange.get(FaultMode.class)).andReturn(null);
         MessageHandlingTimeRecorder mhtr = EasyMock.createMock(MessageHandlingTimeRecorder.class);
+        mhtr.setFaultMode(null);
+        EasyMock.expectLastCall();
         mhtr.endHandling();
         EasyMock.expectLastCall();              
          
@@ -51,8 +55,60 @@
         EasyMock.verify(cRepository);
         
     }
+
+    @Test
+    public void testServerCheckedApplicationFaultMessageOut() {
+        testServerFaultMessageOut(FaultMode.CHECKED_APPLICATION_FAULT);
+    }
+
+    @Test
+    public void testServerLogicalRuntimeFaultMessageOut() {
+        testServerFaultMessageOut(FaultMode.LOGICAL_RUNTIME_FAULT);
+    }
+    
+    @Test
+    public void testServerRuntimeFaultMessageOut() {
+        testServerFaultMessageOut(FaultMode.RUNTIME_FAULT);
+    }
     
     @Test
+    public void testServerUncheckedApplicationFaultMessageOut() {
+        testServerFaultMessageOut(FaultMode.UNCHECKED_APPLICATION_FAULT);
+    }
+    
+    public void testServerFaultMessageOut(FaultMode faultMode) {
+        // need to increase the counter and is not a client
+        setupCounterRepository(true, false);
+        setupExchangeForMessage();
+        EasyMock.expect(message.getExchange()).andReturn(exchange);
+        EasyMock.expect(message.get(Message.REQUESTOR_ROLE)).andReturn(Boolean.FALSE).anyTimes();
+        EasyMock.expect(message.get(FaultMode.class)).andReturn(faultMode).anyTimes();
+        EasyMock.expect(exchange.getOutMessage()).andReturn(message);
+        exchange.put(FaultMode.class, faultMode);
+        EasyMock.expectLastCall();
+        EasyMock.expect(exchange.isOneWay()).andReturn(false);
+        EasyMock.expect(exchange.get(FaultMode.class)).andReturn(faultMode).anyTimes();
+        MessageHandlingTimeRecorder mhtr = EasyMock.createMock(MessageHandlingTimeRecorder.class);
+        mhtr.setFaultMode(faultMode);
+        EasyMock.expectLastCall();
+        mhtr.endHandling();
+        EasyMock.expectLastCall();              
+        
+        EasyMock.replay(mhtr);
+        EasyMock.expect(exchange.get(MessageHandlingTimeRecorder.class)).andReturn(mhtr);
       
+        EasyMock.replay(exchange);
+        EasyMock.replay(message);
+        
+        rtmoi.handleFault(message);
+        EasyMock.verify(message);
+        EasyMock.verify(bus);
+        EasyMock.verify(exchange);
+        EasyMock.verify(mhtr);
+        EasyMock.verify(cRepository);
+        
+    }
+
+    @Test
     public void testClientOneWayMessageOut() {
         //need to increase the counter and is a client
         setupCounterRepository(true, true);



Mime
View raw message