cxf-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dk...@apache.org
Subject svn commit: r726031 - in /cxf/branches/2.1.x-fixes: ./ rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/model/ rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/
Date Fri, 12 Dec 2008 15:14:54 GMT
Author: dkulp
Date: Fri Dec 12 07:14:54 2008
New Revision: 726031

URL: http://svn.apache.org/viewvc?rev=726031&view=rev
Log:
Merged revisions 725348 via svnmerge from 
https://svn.apache.org/repos/asf/cxf/trunk

........
  r725348 | sergeyb | 2008-12-10 12:21:27 -0500 (Wed, 10 Dec 2008) | 1 line
  
  JAXRS : minor updates to class and operation resource info comparators
........

Modified:
    cxf/branches/2.1.x-fixes/   (props changed)
    cxf/branches/2.1.x-fixes/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/model/OperationResourceInfoComparator.java
    cxf/branches/2.1.x-fixes/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/model/URITemplate.java
    cxf/branches/2.1.x-fixes/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java

Propchange: cxf/branches/2.1.x-fixes/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Dec 12 07:14:54 2008
@@ -1 +1 @@
-/cxf/trunk:686333-686363,686764,686820,687096,687194,687363,687387,687463,687543,687722,687798,687814,687817,687891,687910,687914,688086,688102,688133,688596,688735,688870,689572,689596,689855,689924,690067,690289,691246,691271,691295,691338,691355,691488,691602,691646,691706,691728,692116,692157,692310,692466,692499,693653,693819,694179,694263,694417,694716,694744,694747,694795,694869,694981,694987,694993,695041,695096,695396,695484,695537,695552,695561,695619,695684,695835,695840,695868,695935,695977,696016,696094,696433,696720,697085,697868,698128,699289,700261,700507,700602,700981,701316,701783,701830,701862,702187,702205-702248,702267,702547,702561,702580,702602,702609,702616,702653,702656,702957,703191,703239,703309,703501,703513,703548,704584,704937,704997,705150,705235,705274,705340,705446,705548,705614,705692,705708,706482,706631,706675,706900,706909,707034,707089,707100,707902,708035,708044,708074,708410,708417,708550,708554,709353-709354,709425,710076,710150,71015
 4,711193,711388,711410,711490,711635,711949,711975,712194,712198,712238,712272,712299,712312,712670,712893,713082,713095-713096,713099,713584,713597,713737,713804,713899,714167-714168,714245,714255,717937-717961,718281-718448,718565,718620,718640,718665,718970,719017,719210,719215-719218,719222-719273,719305,719327-719680,720053,720119-720218,720238,720293-720316,720497,721221,721241,721501,722117,722129,722412,722988,723024,723338,723378,723716-723791,724333-724372,724433-724438,724449,724481,724485,724668,724780,724782,724785,724793,724795,724940,725071,725316,725332,725335,725364,725418,725425-725426,725455,725506,725554,725562,725651,725671,725688,725754,725773
+/cxf/trunk:686333-686363,686764,686820,687096,687194,687363,687387,687463,687543,687722,687798,687814,687817,687891,687910,687914,688086,688102,688133,688596,688735,688870,689572,689596,689855,689924,690067,690289,691246,691271,691295,691338,691355,691488,691602,691646,691706,691728,692116,692157,692310,692466,692499,693653,693819,694179,694263,694417,694716,694744,694747,694795,694869,694981,694987,694993,695041,695096,695396,695484,695537,695552,695561,695619,695684,695835,695840,695868,695935,695977,696016,696094,696433,696720,697085,697868,698128,699289,700261,700507,700602,700981,701316,701783,701830,701862,702187,702205-702248,702267,702547,702561,702580,702602,702609,702616,702653,702656,702957,703191,703239,703309,703501,703513,703548,704584,704937,704997,705150,705235,705274,705340,705446,705548,705614,705692,705708,706482,706631,706675,706900,706909,707034,707089,707100,707902,708035,708044,708074,708410,708417,708550,708554,709353-709354,709425,710076,710150,71015
 4,711193,711388,711410,711490,711635,711949,711975,712194,712198,712238,712272,712299,712312,712670,712893,713082,713095-713096,713099,713584,713597,713737,713804,713899,714167-714168,714245,714255,717937-717961,718281-718448,718565,718620,718640,718665,718970,719017,719210,719215-719218,719222-719273,719305,719327-719680,720053,720119-720218,720238,720293-720316,720497,721221,721241,721501,722117,722129,722412,722988,723024,723338,723378,723716-723791,724333-724372,724433-724438,724449,724481,724485,724668,724780,724782,724785,724793,724795,724940,725071,725316,725332,725335,725348,725364,725418,725425-725426,725455,725506,725554,725562,725651,725671,725688,725754,725773

Propchange: cxf/branches/2.1.x-fixes/
------------------------------------------------------------------------------
Binary property 'svnmerge-integrated' - no diff available.

Modified: cxf/branches/2.1.x-fixes/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/model/OperationResourceInfoComparator.java
URL: http://svn.apache.org/viewvc/cxf/branches/2.1.x-fixes/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/model/OperationResourceInfoComparator.java?rev=726031&r1=726030&r2=726031&view=diff
==============================================================================
--- cxf/branches/2.1.x-fixes/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/model/OperationResourceInfoComparator.java
(original)
+++ cxf/branches/2.1.x-fixes/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/model/OperationResourceInfoComparator.java
Fri Dec 12 07:14:54 2008
@@ -34,30 +34,17 @@
         }
 
             
-        String l1 = e1.getURITemplate().getLiteralChars();
-        String l2 = e2.getURITemplate().getLiteralChars();
-        if (!l1.equals(l2)) {
-            // descending order 
-            return l1.length() < l2.length() ? 1 : -1; 
-        }
-        
-        int g1 = e1.getURITemplate().getNumberOfGroups();
-        int g2 = e2.getURITemplate().getNumberOfGroups();
-        if (g1 != g2) {
-            // descending order 
-            return g1 < g2 ? 1 : -1;
-        }
+        int result = URITemplate.compareTemplates(
+                          e1.getURITemplate(),
+                          e2.getURITemplate());
         
-        int gCustom1 = e1.getURITemplate().getNumberOfGroupsWithCustomExpression();
-        int gCustom2 = e2.getURITemplate().getNumberOfGroupsWithCustomExpression();
-        if (gCustom1 != gCustom2) {
-            // descending order 
-            return gCustom1 < gCustom2 ? 1 : -1;
-        }
+        if (result == 0) {
         
-        int result = JAXRSUtils.compareSortedMediaTypes(
+            result = JAXRSUtils.compareSortedMediaTypes(
                           e1.getConsumeTypes(), 
                           e2.getConsumeTypes());
+        }
+        
         if (result == 0) {
             //use the media type of output data as the secondary key.
             result = JAXRSUtils.compareSortedMediaTypes(e1.getProduceTypes(), 

Modified: cxf/branches/2.1.x-fixes/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/model/URITemplate.java
URL: http://svn.apache.org/viewvc/cxf/branches/2.1.x-fixes/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/model/URITemplate.java?rev=726031&r1=726030&r2=726031&view=diff
==============================================================================
--- cxf/branches/2.1.x-fixes/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/model/URITemplate.java
(original)
+++ cxf/branches/2.1.x-fixes/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/model/URITemplate.java
Fri Dec 12 07:14:54 2008
@@ -35,7 +35,6 @@
 public final class URITemplate {
     
     public static final String TEMPLATE_PARAMETERS = "jaxrs.template.parameters";
-    
     public static final String LIMITED_REGEX_SUFFIX = "(/.*)?";
     public static final String FINAL_MATCH_GROUP = "FINAL_MATCH_GROUP";
     
@@ -46,6 +45,7 @@
         Pattern.compile("\\{(\\w[-\\w\\.]*)(\\:(.+?))?\\}");
 
     private static final String DEFAULT_PATH_VARIABLE_REGEX = "([^/]+?)";
+    private static final String CHARACTERS_TO_ESCAPE = ".";
     
     private final String template;
     private final List<String> templateVariables = new ArrayList<String>();
@@ -123,9 +123,9 @@
     }
     
     private static boolean isReservedCharater(char ch) {
-        return '.' == ch;
+        return CHARACTERS_TO_ESCAPE.indexOf(ch) != -1;
     }
-
+    
     public boolean match(String uri, MultivaluedMap<String, String> templateVariableToValue)
{
 
         if (uri == null) {
@@ -192,4 +192,27 @@
         
         return new URITemplate(pathValue);
     }
+    
+    public static int compareTemplates(URITemplate t1, URITemplate t2) {
+        String l1 = t1.getLiteralChars();
+        String l2 = t2.getLiteralChars();
+        if (!l1.equals(l2)) {
+            // descending order 
+            return l1.length() < l2.length() ? 1 : -1; 
+        }
+        
+        int g1 = t1.getNumberOfGroups();
+        int g2 = t2.getNumberOfGroups();
+        // descending order 
+        int result = g1 < g2 ? 1 : g1 > g2 ? -1 : 0;
+        if (result == 0) {
+            int gCustom1 = t1.getNumberOfGroupsWithCustomExpression();
+            int gCustom2 = t2.getNumberOfGroupsWithCustomExpression();
+            if (gCustom1 != gCustom2) {
+                // descending order 
+                return gCustom1 < gCustom2 ? 1 : -1;
+            }
+        }
+        return result;
+    }
 }

Modified: cxf/branches/2.1.x-fixes/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java
URL: http://svn.apache.org/viewvc/cxf/branches/2.1.x-fixes/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java?rev=726031&r1=726030&r2=726031&view=diff
==============================================================================
--- cxf/branches/2.1.x-fixes/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java
(original)
+++ cxf/branches/2.1.x-fixes/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java
Fri Dec 12 07:14:54 2008
@@ -81,6 +81,7 @@
 import org.apache.cxf.jaxrs.impl.SecurityContextImpl;
 import org.apache.cxf.jaxrs.impl.UriInfoImpl;
 import org.apache.cxf.jaxrs.model.ClassResourceInfo;
+import org.apache.cxf.jaxrs.model.ClassResourceInfoComparator;
 import org.apache.cxf.jaxrs.model.OperationResourceInfo;
 import org.apache.cxf.jaxrs.model.OperationResourceInfoComparator;
 import org.apache.cxf.jaxrs.model.URITemplate;
@@ -218,24 +219,7 @@
         
         SortedMap<ClassResourceInfo, MultivaluedMap<String, String>> candidateList
= 
             new TreeMap<ClassResourceInfo, MultivaluedMap<String, String>>(
-                new Comparator<ClassResourceInfo>() {
-
-                    public int compare(ClassResourceInfo cr1, ClassResourceInfo cr2) {
-                        
-                        String l1 = cr1.getURITemplate().getLiteralChars();
-                        String l2 = cr2.getURITemplate().getLiteralChars();
-                        if (!l1.equals(l2)) {
-                            // descending order 
-                            return l1.length() < l2.length() ? 1 : -1; 
-                        }
-                        
-                        int g1 = cr1.getURITemplate().getNumberOfGroups();
-                        int g2 = cr2.getURITemplate().getNumberOfGroups();
-                        // descending order 
-                        return g1 < g2 ? 1 : g1 > g2 ? -1 : 0;
-                    }
-                    
-                });
+                new ClassResourceInfoComparator());
         
         for (ClassResourceInfo resource : resources) {
             MultivaluedMap<String, String> map = new MetadataMap<String, String>();



Mime
View raw message