Return-Path: Delivered-To: apmail-incubator-cxf-commits-archive@locus.apache.org Received: (qmail 90153 invoked from network); 26 Jan 2008 13:56:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 26 Jan 2008 13:56:16 -0000 Received: (qmail 5290 invoked by uid 500); 26 Jan 2008 13:56:07 -0000 Delivered-To: apmail-incubator-cxf-commits-archive@incubator.apache.org Received: (qmail 5228 invoked by uid 500); 26 Jan 2008 13:56:06 -0000 Mailing-List: contact cxf-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cxf-dev@incubator.apache.org Delivered-To: mailing list cxf-commits@incubator.apache.org Received: (qmail 5219 invoked by uid 99); 26 Jan 2008 13:56:06 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 Jan 2008 05:56:06 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 Jan 2008 13:56:00 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 1014B1A9832; Sat, 26 Jan 2008 05:55:52 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r615451 - /incubator/cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java Date: Sat, 26 Jan 2008 13:55:52 -0000 To: cxf-commits@incubator.apache.org From: gmazza@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080126135553.1014B1A9832@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: gmazza Date: Sat Jan 26 05:55:50 2008 New Revision: 615451 URL: http://svn.apache.org/viewvc?rev=615451&view=rev Log: Made missing phase error message more explicit. Modified: incubator/cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java Modified: incubator/cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java?rev=615451&r1=615450&r2=615451&view=diff ============================================================================== --- incubator/cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java (original) +++ incubator/cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java Sat Jan 26 05:55:50 2008 @@ -160,20 +160,22 @@ public void add(Interceptor i, boolean force) { PhaseInterceptor pi = (PhaseInterceptor)i; - if (LOG.isLoggable(Level.FINE)) { - LOG.fine("Adding interceptor " + i + " to phase " + pi.getPhase()); - } - - String phaseName = pi.getPhase(); - + String phaseName = pi.getPhase(); Integer phase = nameMap.get(phaseName); + if (phase == null) { - LOG.fine("Phase " + phaseName + " does not exist. Skipping handler " - + i.getClass().getName()); + LOG.fine("Skipping interceptor " + i.getClass().getName() + + ((phaseName == null) ? ": Phase declaration is missing." + : ": Phase " + phaseName + " specified does not exist.")); } else { + if (LOG.isLoggable(Level.FINE)) { + LOG.fine("Adding interceptor " + i + " to phase " + phaseName); + } + insertInterceptor(phase, pi, force); } } + public synchronized void pause() { state = State.PAUSED;