Return-Path: Delivered-To: apmail-incubator-cxf-commits-archive@locus.apache.org Received: (qmail 35053 invoked from network); 18 Nov 2007 21:13:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 18 Nov 2007 21:13:42 -0000 Received: (qmail 62490 invoked by uid 500); 18 Nov 2007 21:13:29 -0000 Delivered-To: apmail-incubator-cxf-commits-archive@incubator.apache.org Received: (qmail 62434 invoked by uid 500); 18 Nov 2007 21:13:29 -0000 Mailing-List: contact cxf-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cxf-dev@incubator.apache.org Delivered-To: mailing list cxf-commits@incubator.apache.org Received: (qmail 62425 invoked by uid 99); 18 Nov 2007 21:13:29 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Nov 2007 13:13:29 -0800 X-ASF-Spam-Status: No, hits=-98.0 required=10.0 tests=ALL_TRUSTED,URIBL_BLACK X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Nov 2007 21:13:25 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id DB1F51A9832; Sun, 18 Nov 2007 13:13:18 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r596138 - in /incubator/cxf/trunk/testutils/src/main/java/org/apache/hello_world_xml_http/wrapped: GreeterFaultImpl.java GreeterImpl.java Date: Sun, 18 Nov 2007 21:13:18 -0000 To: cxf-commits@incubator.apache.org From: bimargulies@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20071118211318.DB1F51A9832@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bimargulies Date: Sun Nov 18 13:13:17 2007 New Revision: 596138 URL: http://svn.apache.org/viewvc?rev=596138&view=rev Log: Clean up some use of System.out.println. Should we PMD this? Modified: incubator/cxf/trunk/testutils/src/main/java/org/apache/hello_world_xml_http/wrapped/GreeterFaultImpl.java incubator/cxf/trunk/testutils/src/main/java/org/apache/hello_world_xml_http/wrapped/GreeterImpl.java Modified: incubator/cxf/trunk/testutils/src/main/java/org/apache/hello_world_xml_http/wrapped/GreeterFaultImpl.java URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/testutils/src/main/java/org/apache/hello_world_xml_http/wrapped/GreeterFaultImpl.java?rev=596138&r1=596137&r2=596138&view=diff ============================================================================== --- incubator/cxf/trunk/testutils/src/main/java/org/apache/hello_world_xml_http/wrapped/GreeterFaultImpl.java (original) +++ incubator/cxf/trunk/testutils/src/main/java/org/apache/hello_world_xml_http/wrapped/GreeterFaultImpl.java Sun Nov 18 13:13:17 2007 @@ -19,6 +19,10 @@ package org.apache.hello_world_xml_http.wrapped; +import java.util.logging.Logger; + +import org.apache.cxf.common.logging.LogUtils; + @javax.jws.WebService(serviceName = "XMLService", portName = "XMLFaultPort", @@ -29,15 +33,16 @@ @javax.xml.ws.BindingType(value = "http://cxf.apache.org/bindings/xformat") public class GreeterFaultImpl implements Greeter { - public static final String RUNTIME_EXCEPTION_MESSAGE = "test throw out runtime exception"; + private static final Logger LOG = LogUtils.getL7dLogger(GreeterFaultImpl.class); + public String greetMe(String me) { return "Hello " + me; } public void greetMeOneWay(String me) { - System.out.println("Executing operation greetMeOneWay\n"); - System.out.println("Hello there " + me); + LOG.info("Executing operation greetMeOneWay"); + LOG.info("Hello there " + me); } public String sayHi() { Modified: incubator/cxf/trunk/testutils/src/main/java/org/apache/hello_world_xml_http/wrapped/GreeterImpl.java URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/testutils/src/main/java/org/apache/hello_world_xml_http/wrapped/GreeterImpl.java?rev=596138&r1=596137&r2=596138&view=diff ============================================================================== --- incubator/cxf/trunk/testutils/src/main/java/org/apache/hello_world_xml_http/wrapped/GreeterImpl.java (original) +++ incubator/cxf/trunk/testutils/src/main/java/org/apache/hello_world_xml_http/wrapped/GreeterImpl.java Sun Nov 18 13:13:17 2007 @@ -19,6 +19,9 @@ package org.apache.hello_world_xml_http.wrapped; +import java.util.logging.Logger; + +import org.apache.cxf.common.logging.LogUtils; import org.apache.hello_world_xml_http.wrapped.types.FaultDetail; @javax.jws.WebService(serviceName = "XMLService", @@ -30,22 +33,27 @@ @javax.xml.ws.BindingType(value = "http://cxf.apache.org/bindings/xformat") public class GreeterImpl implements Greeter { + + private static final Logger LOG = LogUtils.getL7dLogger(GreeterImpl.class); + public String greetMe(String me) { - System.out.println("Executing operation greetMe\n" + me); + LOG.info("Executing operation greetMe\n" + me); return "Hello " + me; } public void greetMeOneWay(String me) { - System.out.println("Executing operation greetMeOneWay\n"); - System.out.println("Hello there " + me); + LOG.info("Executing operation greetMeOneWay\n"); + LOG.info("Hello there " + me); } public String sayHi() { + LOG.info("Executing operation sayHi\n"); return "Bonjour"; } public void pingMe() throws PingMeFault { + LOG.info("Executing operation pingMe\n"); FaultDetail faultDetail = new FaultDetail(); faultDetail.setMajor((short)2); faultDetail.setMinor((short)1);