cxf-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ningji...@apache.org
Subject svn commit: r578103 - in /incubator/cxf/trunk/integration/jca/src: main/java/org/apache/cxf/jca/core/resourceadapter/ main/java/org/apache/cxf/jca/cxf/ test/java/org/apache/cxf/jca/core/resourceadapter/ test/java/org/apache/cxf/jca/cxf/
Date Fri, 21 Sep 2007 13:44:57 GMT
Author: ningjiang
Date: Fri Sep 21 06:44:56 2007
New Revision: 578103

URL: http://svn.apache.org/viewvc?rev=578103&view=rev
Log:
Fixed the typos and added the getManagedConnectionMetaData()

Modified:
    incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/core/resourceadapter/AbstractManagedConnectionImpl.java
    incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/cxf/Messages.properties
    incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/core/resourceadapter/ManagedConnectionImplTest.java
    incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ConnectionFactoryImplTest.java

Modified: incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/core/resourceadapter/AbstractManagedConnectionImpl.java
URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/core/resourceadapter/AbstractManagedConnectionImpl.java?rev=578103&r1=578102&r2=578103&view=diff
==============================================================================
--- incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/core/resourceadapter/AbstractManagedConnectionImpl.java
(original)
+++ incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/core/resourceadapter/AbstractManagedConnectionImpl.java
Fri Sep 21 06:44:56 2007
@@ -23,7 +23,6 @@
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
-import javax.resource.NotSupportedException;
 import javax.resource.ResourceException;
 import javax.resource.spi.ConnectionEvent;
 import javax.resource.spi.ConnectionEventListener;
@@ -33,6 +32,7 @@
 import javax.security.auth.Subject;
 import org.apache.cxf.common.logging.LogUtils;
 import org.apache.cxf.jca.core.logging.LoggerHelper;
+import org.apache.cxf.jca.cxf.CXFManagedConnectionMetaData;
 
 public abstract class AbstractManagedConnectionImpl implements ManagedConnection {
     private static final Logger LOG = LogUtils.getL7dLogger(AbstractManagedConnectionImpl.class);
@@ -101,7 +101,7 @@
     }
 
     public ManagedConnectionMetaData getMetaData() throws ResourceException {
-        throw new NotSupportedException("NOT_YET_IMPLEMENTED getMetaData");
+        return new CXFManagedConnectionMetaData();
     }
 
     public void setLogWriter(PrintWriter aPrintWriter) throws ResourceException {

Modified: incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/cxf/Messages.properties
URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/cxf/Messages.properties?rev=578103&r1=578102&r2=578103&view=diff
==============================================================================
--- incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/cxf/Messages.properties
(original)
+++ incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/cxf/Messages.properties
Fri Sep 21 06:44:56 2007
@@ -20,5 +20,5 @@
 #
 INTERFACE_IS_NULL = The interface parameter is null. 
 IS_NOT_AN_INTERFACE = The [{0}] is not an interface.
-FAIL_TO_GET_CXF_CONNECTION = Failed to get the CXF Connection with connection parameters
: {0}
+FAILED_TO_GET_CXF_CONNECTION = Failed to get the CXF Connection with connection parameters:
{0}
 ASSOCIATED_ERROR = Error in associating connection.

Modified: incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/core/resourceadapter/ManagedConnectionImplTest.java
URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/core/resourceadapter/ManagedConnectionImplTest.java?rev=578103&r1=578102&r2=578103&view=diff
==============================================================================
--- incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/core/resourceadapter/ManagedConnectionImplTest.java
(original)
+++ incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/core/resourceadapter/ManagedConnectionImplTest.java
Fri Sep 21 06:44:56 2007
@@ -83,10 +83,9 @@
     @Test
     public void testGetMetaData() throws Exception {
         try {
-            mc.getMetaData();
-            fail("expect exception");
+            mc.getMetaData();            
         } catch (NotSupportedException expected) {
-            // do nothing here
+            fail("Got the Exception here");
         }
     }
 
@@ -94,7 +93,7 @@
     public void testGetSetSubject() {
         Subject s = new Subject();
         mc.setSubject(s);
-        assertEquals("got back what we set", s, mc.getSubject());
+        assertEquals("Got back what we set", s, mc.getSubject());
     }
 
     @Test
@@ -103,7 +102,7 @@
         };
 
         mc.setConnectionRequestInfo(ri);
-        assertEquals("got back what we set", ri, mc.getConnectionRequestInfo());
+        assertEquals("Got back what we set", ri, mc.getConnectionRequestInfo());
     }
 
     @Test

Modified: incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ConnectionFactoryImplTest.java
URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ConnectionFactoryImplTest.java?rev=578103&r1=578102&r2=578103&view=diff
==============================================================================
--- incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ConnectionFactoryImplTest.java
(original)
+++ incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ConnectionFactoryImplTest.java
Fri Sep 21 06:44:56 2007
@@ -60,7 +60,7 @@
 
     @Test
     public void testInstanceOfReferencable() throws Exception {
-        assertTrue("Instance of Referencable", cf instanceof Referenceable);
+        assertTrue("Instance of Referenceable", cf instanceof Referenceable);
 
         assertNull("No ref set", cf.getReference());
         Reference ref = EasyMock.createMock(Reference.class);
@@ -179,7 +179,7 @@
             param.setServiceName(new QName(""));
             param.setPortName(new QName(""));
             cf.getConnection(param);
-            fail("Expect exception on use of non interface class");
+            fail("Expect exception on using of none interface class");
         } catch (ResourceException re) {
             assertTrue(true);
         }
@@ -190,7 +190,7 @@
         try {
             param.setInterface(null);
             cf.getConnection(param);
-            fail("Should get an exception");
+            fail("Expect exception of no interface here");
         } catch (ResourceException re) {
             assertTrue(true);
         }



Mime
View raw message