cxf-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zarar Siddiqi <zar...@gmail.com>
Subject Re: svn commit: r551748 getFaultInfo() required?
Date Wed, 08 Aug 2007 19:25:11 GMT

I have created a JIRA and supplied a patch that fixes this issue.

https://issues.apache.org/jira/browse/CXF-899

Any feedback would be appreciated.

Thanks,
Zarar



Zarar Siddiqi wrote:
> 
> Hi,
> 
> Do you know where in the spec it stays that the getFaultInfo() method is
> required?  
> 
> If the getFaultInfo() method is not specified then the user has the option
> to specify any additional properties for the exception in the @WebFault
> class rather than having to create a new class.  This behavior is also
> compatible with how XFire/Aegis did things.
> 
> On page 21 of the JAX-WS 2.0 Spec it says that the class annotated with
> @WebFault can have two constructors + the getFaultInfo() method.  Since
> we're not enforcing the two constructors, why enforce the getFaultInfo()? 
> The place where this is being enforced is the WebFaultOutInterceptor whose
> behavior should be probably changed to using the @WebFault class as the
> faultInfo bean if getFaultInfo() is not present.
> 
> I think this offers greater flexibility to users while still complying
> with the spec. This way those who'd like to specify getFaultInfo() can do
> so and those who don't want to, don't have to.  
> 
> Any thoughts?
> 
> Thanks,
> Zarar
> 
> 
> 
> ningjiang wrote:
>> 
>> Author: ningjiang
>> Date: Thu Jun 28 18:41:34 2007
>> New Revision: 551748
>> 
>> URL: http://svn.apache.org/viewvc?view=rev&rev=551748
>> Log:
>> CXF-753 applied Glen's patch and added some comments to binding API
>> 
>> Modified:
>>    
>> incubator/cxf/trunk/api/src/main/java/org/apache/cxf/BusException.java
>>    
>> incubator/cxf/trunk/api/src/main/java/org/apache/cxf/binding/Binding.java
>>    
>> incubator/cxf/trunk/api/src/main/java/org/apache/cxf/binding/BindingFactory.java
>>    
>> incubator/cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java
>>    
>> incubator/cxf/trunk/common/common/src/main/java/org/apache/cxf/configuration/spring/AbstractBeanDefinitionParser.java
>>    
>> incubator/cxf/trunk/distribution/src/main/release/samples/mtosi_1.1/xsd/interfaces/NotificationService.xsd
>>    
>> incubator/cxf/trunk/distribution/src/main/release/samples/mtosi_1.1/xsd/networkResources/Notifications.xsd
>>    
>> incubator/cxf/trunk/distribution/src/main/release/samples/mtosi_1.1/xsd/networkResources/VendorExtensions.xsd
>>    
>> incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/core/resourceadapter/Messages.properties
>>    
>> incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/MimeBodyPartInputStream.java
>>    
>> incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/interceptor/AbstractFaultChainInitiatorObserver.java
>>    
>> incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/interceptor/ClientOutFaultObserver.java
>>    
>> incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/transport/http/Messages.properties
>>    
>> incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/JaxwsServiceBuilder.java
>>    
>> incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/Messages.properties
>>    
>> incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/http/GreeterImpl.java
>>    
>> incubator/cxf/trunk/tools/javato/core/src/main/java/org/apache/cxf/tools/java2wsdl/processor/internal/ServiceBuilderFactory.java
>>    
>> incubator/cxf/trunk/tools/javato/test/src/test/java/org/apache/cxf/tools/java2wsdl/processor/JavaToProcessorTest.java
>> 
>> Modified:
>> incubator/cxf/trunk/api/src/main/java/org/apache/cxf/BusException.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/api/src/main/java/org/apache/cxf/BusException.java?view=diff&rev=551748&r1=551747&r2=551748
>> ==============================================================================
>> ---
>> incubator/cxf/trunk/api/src/main/java/org/apache/cxf/BusException.java
>> (original)
>> +++
>> incubator/cxf/trunk/api/src/main/java/org/apache/cxf/BusException.java
>> Thu Jun 28 18:41:34 2007
>> @@ -22,7 +22,7 @@
>>  import org.apache.cxf.common.i18n.Message;
>>  
>>  /**
>> - * The BusException class is used to indicate a bus exception has
>> occured.
>> + * The BusException class is used to indicate a bus exception has
>> occurred.
>>   */
>>  public class BusException extends org.apache.cxf.common.i18n.Exception {
>>  
>> 
>> Modified:
>> incubator/cxf/trunk/api/src/main/java/org/apache/cxf/binding/Binding.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/api/src/main/java/org/apache/cxf/binding/Binding.java?view=diff&rev=551748&r1=551747&r2=551748
>> ==============================================================================
>> ---
>> incubator/cxf/trunk/api/src/main/java/org/apache/cxf/binding/Binding.java
>> (original)
>> +++
>> incubator/cxf/trunk/api/src/main/java/org/apache/cxf/binding/Binding.java
>> Thu Jun 28 18:41:34 2007
>> @@ -29,9 +29,23 @@
>>   */
>>  public interface Binding extends InterceptorProvider {
>>      
>> +    /**
>> +     * Create a Message for this Binding.
>> +     * @return the Binding message
>> +     */
>>      Message createMessage();
>> -
>> +    
>> +    /**
>> +     * Create a Message form the messge.
>> +     * 
>> +     * @param m the message used for creating a binding message
>> +     * @return the Binding message
>> +     */ 
>>      Message createMessage(Message m);
>>      
>> +    /**
>> +     * Get the BindingInfor
>> +     * @return the BingdingInfo Object     
>> +     */
>>      BindingInfo getBindingInfo();
>>  }
>> 
>> Modified:
>> incubator/cxf/trunk/api/src/main/java/org/apache/cxf/binding/BindingFactory.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/api/src/main/java/org/apache/cxf/binding/BindingFactory.java?view=diff&rev=551748&r1=551747&r2=551748
>> ==============================================================================
>> ---
>> incubator/cxf/trunk/api/src/main/java/org/apache/cxf/binding/BindingFactory.java
>> (original)
>> +++
>> incubator/cxf/trunk/api/src/main/java/org/apache/cxf/binding/BindingFactory.java
>> Thu Jun 28 18:41:34 2007
>> @@ -33,11 +33,12 @@
>>       * Create a Binding from the BindingInfo metadata.
>>       * 
>>       * @param binding
>> +     * @return the Binding object
>>       */
>>      Binding createBinding(BindingInfo binding);
>>  
>>      /**
>> -     * Creates a "default" BindingInfo object for the service. Can
>> return a subclass. 
>> +     * Create a "default" BindingInfo object for the service. Can return
>> a subclass. 
>>       * @param service
>>       * @param namespace
>>       * @param configObject - binding specific configuration object
>> @@ -45,5 +46,12 @@
>>       */
>>      BindingInfo createBindingInfo(Service service, String namespace,
>> Object configObject);
>>      
>> +    /**
>> +     * Set the destionation's message observer which is created by using
>> the endpoint to
>> +     * listen the incoming message
>> +     * @param d the destination that will be set the MessageObserver 
>> +     * @param e the endpoint to build up the MessageObserver
>> +     * @return the BindingInfo object 
>> +     */
>>      void addListener(Destination d, Endpoint e);
>>  }
>> 
>> Modified:
>> incubator/cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java?view=diff&rev=551748&r1=551747&r2=551748
>> ==============================================================================
>> ---
>> incubator/cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java
>> (original)
>> +++
>> incubator/cxf/trunk/api/src/main/java/org/apache/cxf/phase/PhaseInterceptorChain.java
>> Thu Jun 28 18:41:34 2007
>> @@ -69,7 +69,7 @@
>>      
>>      // currently one chain for one request/response, use below as signal
>> to avoid duplicate fault processing
>>      // on nested calling of doIntercept(), which will throw same fault
>> multi-times
>> -    private boolean faultOccured;
>> +    private boolean faultOccurred;
>>      
>>      
>>      private PhaseInterceptorChain(PhaseInterceptorChain src) {
>> @@ -206,9 +206,9 @@
>>                  currentInterceptor.handleMessage(message);
>>                  
>>              } catch (RuntimeException ex) {
>> -                if (!faultOccured) {
>> +                if (!faultOccurred) {
>>   
>> -                    faultOccured = true;
>> +                    faultOccurred = true;
>>                      if (LOG.isLoggable(Level.INFO)) {
>>                          LogUtils.log(LOG, Level.INFO, "Interceptor has
>> thrown exception, unwinding now", ex);
>>                      }
>> 
>> Modified:
>> incubator/cxf/trunk/common/common/src/main/java/org/apache/cxf/configuration/spring/AbstractBeanDefinitionParser.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/common/common/src/main/java/org/apache/cxf/configuration/spring/AbstractBeanDefinitionParser.java?view=diff&rev=551748&r1=551747&r2=551748
>> ==============================================================================
>> ---
>> incubator/cxf/trunk/common/common/src/main/java/org/apache/cxf/configuration/spring/AbstractBeanDefinitionParser.java
>> (original)
>> +++
>> incubator/cxf/trunk/common/common/src/main/java/org/apache/cxf/configuration/spring/AbstractBeanDefinitionParser.java
>> Thu Jun 28 18:41:34 2007
>> @@ -306,6 +306,10 @@
>>          return new QName(ns, local, pre);
>>      }
>>  
>> +    /* This id-or-name resolution logic follows that in Spring's
>> +     *
>> org.springframework.beans.factory.xml.BeanDefinitionParserDelegate object
>> +     * Intent is to have resolution of CXF custom beans follow that of
>> Spring beans
>> +     */    
>>      protected String getIdOrName(Element elem) {
>>          String id =
>> elem.getAttribute(BeanDefinitionParserDelegate.ID_ATTRIBUTE);
>>          
>> 
>> Modified:
>> incubator/cxf/trunk/distribution/src/main/release/samples/mtosi_1.1/xsd/interfaces/NotificationService.xsd
>> URL:
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/distribution/src/main/release/samples/mtosi_1.1/xsd/interfaces/NotificationService.xsd?view=diff&rev=551748&r1=551747&r2=551748
>> ==============================================================================
>> ---
>> incubator/cxf/trunk/distribution/src/main/release/samples/mtosi_1.1/xsd/interfaces/NotificationService.xsd
>> (original)
>> +++
>> incubator/cxf/trunk/distribution/src/main/release/samples/mtosi_1.1/xsd/interfaces/NotificationService.xsd
>> Thu Jun 28 18:41:34 2007
>> @@ -16,7 +16,7 @@
>>        <xsd:documentation>
>>        To define the enumeration of all the supported topic types.
>>        Note that topic types are logical categories of events.
>> -      The following MTOSI events are not bound to any topic types;
>> Heartbeat, EventLossOccured, EventLossCleared
>> +      The following MTOSI events are not bound to any topic types:
>> Heartbeat, EventLossOccurred, EventLossCleared
>>        Refer to the Event_T definition.
>>        </xsd:documentation>
>>      </xsd:annotation>
>> @@ -24,28 +24,28 @@
>>        <xsd:enumeration value="Inventory">
>>          <xsd:annotation>
>>            <xsd:documentation>
>> -          The topic type for these events; ObjectCreation,
>> ObjectDeletion, AttributeValueChange, StateChange, ObjectDiscovery.  
>> +          The topic type for these events: ObjectCreation,
>> ObjectDeletion, AttributeValueChange, StateChange, ObjectDiscovery.  
>>            </xsd:documentation>
>>          </xsd:annotation>
>>        </xsd:enumeration>
>>        <xsd:enumeration value="Fault">
>>          <xsd:annotation>
>>            <xsd:documentation>
>> -          The topic type for these events; Alarm.  
>> +          The topic type for these events: Alarm.  
>>            </xsd:documentation>
>>          </xsd:annotation>
>>        </xsd:enumeration>
>>        <xsd:enumeration value="Protection">
>>          <xsd:annotation>
>>            <xsd:documentation>
>> -          The topic type for these events; ProtectionSwitch,
>> EProtectionSwitch.  
>> +          The topic type for these events: ProtectionSwitch,
>> EProtectionSwitch.  
>>            </xsd:documentation>
>>          </xsd:annotation>
>>        </xsd:enumeration>
>>        <xsd:enumeration value="FileTransferStatus">
>>          <xsd:annotation>
>>            <xsd:documentation>
>> -          The topic type for these events; FileTransferStatus.  
>> +          The topic type for these events: FileTransferStatus.  
>>            </xsd:documentation>
>>          </xsd:annotation>
>>        </xsd:enumeration>
>> 
>> Modified:
>> incubator/cxf/trunk/distribution/src/main/release/samples/mtosi_1.1/xsd/networkResources/Notifications.xsd
>> URL:
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/distribution/src/main/release/samples/mtosi_1.1/xsd/networkResources/Notifications.xsd?view=diff&rev=551748&r1=551747&r2=551748
>> ==============================================================================
>> ---
>> incubator/cxf/trunk/distribution/src/main/release/samples/mtosi_1.1/xsd/networkResources/Notifications.xsd
>> (original)
>> +++
>> incubator/cxf/trunk/distribution/src/main/release/samples/mtosi_1.1/xsd/networkResources/Notifications.xsd
>> Thu Jun 28 18:41:34 2007
>> @@ -888,10 +888,10 @@
>>      </xsd:all>
>>    </xsd:complexType>
>>    <!-- ================= -->
>> -  <xsd:complexType name="EventLossOccured_T">
>> +  <xsd:complexType name="EventLossOccurred_T">
>>      <xsd:annotation>
>>        <xsd:documentation>
>> -The structure of the EventLossOccured event type.
>> +The structure of the EventLossOccurred event type.
>>        </xsd:documentation>
>>      </xsd:annotation>
>>      <xsd:all>
>> @@ -930,10 +930,10 @@
>>            </xsd:documentation>
>>          </xsd:annotation>
>>        </xsd:element>
>> -      <xsd:element name="vendorExtensions" type="EventLossOccuredExt_T"
>> minOccurs="0">
>> +      <xsd:element name="vendorExtensions" type="EventLossOccurredExt_T"
>> minOccurs="0">
>>          <xsd:annotation>
>>            <xsd:documentation>
>> -The specific containment for vendor extensions of the EventLossOccured
>> notification object.
>> +The specific containment for vendor extensions of the EventLossOccurred
>> notification object.
>>            </xsd:documentation>
>>          </xsd:annotation>
>>        </xsd:element>
>> @@ -1031,7 +1031,7 @@
>>        <xsd:element name="Heartbeat" type="Heartbeat_T"/>
>>        <xsd:element name="Alarm" type="Alarm_T"/>
>>        <xsd:element name="FileTransferStatus"
>> type="FileTransferStatus_T"/>
>> -      <xsd:element name="EventLossOccured" type="EventLossOccured_T"/>
>> +      <xsd:element name="EventLossOccurred" type="EventLossOccurred_T"/>
>>        <xsd:element name="EventLossCleared" type="EventLossCleared_T"/>
>>        <xsd:element name="VendorNotification"
>> type="VendorNotification_T"/>
>>      </xsd:choice>
>> 
>> Modified:
>> incubator/cxf/trunk/distribution/src/main/release/samples/mtosi_1.1/xsd/networkResources/VendorExtensions.xsd
>> URL:
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/distribution/src/main/release/samples/mtosi_1.1/xsd/networkResources/VendorExtensions.xsd?view=diff&rev=551748&r1=551747&r2=551748
>> ==============================================================================
>> ---
>> incubator/cxf/trunk/distribution/src/main/release/samples/mtosi_1.1/xsd/networkResources/VendorExtensions.xsd
>> (original)
>> +++
>> incubator/cxf/trunk/distribution/src/main/release/samples/mtosi_1.1/xsd/networkResources/VendorExtensions.xsd
>> Thu Jun 28 18:41:34 2007
>> @@ -401,10 +401,10 @@
>>      <xsd:attribute name="tmf854Version" type="TMF854_Version_T"
>> use="optional"/>
>>    </xsd:complexType>
>>    <!-- ================= -->
>> -  <xsd:complexType name="EventLossOccuredExt_T">
>> +  <xsd:complexType name="EventLossOccurredExt_T">
>>      <xsd:annotation>
>>        <xsd:documentation>
>> -Vendor extension of the EventLossOccured_T structure
>> +Vendor extension of the EventLossOccurred_T structure
>>              </xsd:documentation>
>>      </xsd:annotation>
>>      <xsd:sequence>
>> 
>> Modified:
>> incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/core/resourceadapter/Messages.properties
>> URL:
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/core/resourceadapter/Messages.properties?view=diff&rev=551748&r1=551747&r2=551748
>> ==============================================================================
>> ---
>> incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/core/resourceadapter/Messages.properties
>> (original)
>> +++
>> incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/core/resourceadapter/Messages.properties
>> Thu Jun 28 18:41:34 2007
>> @@ -23,7 +23,7 @@
>>  NULL_LOG_WRITER = setLogWriter called with null log value
>>  NO_CONFIG_FOR_INTERFACE = No configuration for interface {0}
>>  INITIALISATION_INCOMPLETE = Initialisation is not complete,
>> createConnectionFactory must be called on this ManagedConnectionFactory
>> to complete initialisation
>> -ERROR_DURING_GET_CONNECTION = Error occured during getConnection:
>> +ERROR_DURING_GET_CONNECTION = Error occurred during getConnection:
>>  INSUFFICIENT_CONFIG = Insufficient configration provided.  Values for
>> either CorbaReference or NameServiceReference (or both) must be provided.
>>  ERROR_CREATING_TX_CURRENT_PROXY = Error creating
>> org.omg.CosTransactions.Current proxy. Exception {0} thrown.
>>  CONNECTION_CLOSED_EVENT_FIRED = CONNECTION_CLOSED event fired at {0}
>> @@ -49,5 +49,6 @@
>>  ASSOCIATE_CONNECTION_CALLED = associateConnection called on '{0}',
>> connection '{1}'
>>  
>>  SETTING_PROPERTY = Setting Property {0} with value {1}
>> +
>>  
>>  
>> 
>> Modified:
>> incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/MimeBodyPartInputStream.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/MimeBodyPartInputStream.java?view=diff&rev=551748&r1=551747&r2=551748
>> ==============================================================================
>> ---
>> incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/MimeBodyPartInputStream.java
>> (original)
>> +++
>> incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/MimeBodyPartInputStream.java
>> Thu Jun 28 18:41:34 2007
>> @@ -45,7 +45,7 @@
>>  
>>          // read the next value from stream
>>          int value = inStream.read();
>> -        // A problem occured because all the mime parts tends to have a
>> /r/n
>> +        // A problem occurred because all the mime parts tends to have a
>> /r/n
>>          // at the end. Making it hard to transform them to correct
>>          // DataSources.
>>          // This logic introduced to handle it
>> @@ -102,4 +102,4 @@
>>          }
>>          return value;
>>      }
>> -}
>> \ No newline at end of file
>> +}
>> 
>> Modified:
>> incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/interceptor/AbstractFaultChainInitiatorObserver.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/interceptor/AbstractFaultChainInitiatorObserver.java?view=diff&rev=551748&r1=551747&r2=551748
>> ==============================================================================
>> ---
>> incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/interceptor/AbstractFaultChainInitiatorObserver.java
>> (original)
>> +++
>> incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/interceptor/AbstractFaultChainInitiatorObserver.java
>> Thu Jun 28 18:41:34 2007
>> @@ -85,7 +85,7 @@
>>          try {
>>              chain.doIntercept(faultMessage);
>>          } catch (Exception exc) {
>> -            LogUtils.log(LOG, Level.SEVERE, "Error occured during error
>> handling, give up!", exc);
>> +            LogUtils.log(LOG, Level.SEVERE, "Error occurred during error
>> handling, give up!", exc);
>>              throw new RuntimeException(exc.getCause());
>>          }
>>      }
>> 
>> Modified:
>> incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/interceptor/ClientOutFaultObserver.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/interceptor/ClientOutFaultObserver.java?view=diff&rev=551748&r1=551747&r2=551748
>> ==============================================================================
>> ---
>> incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/interceptor/ClientOutFaultObserver.java
>> (original)
>> +++
>> incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/interceptor/ClientOutFaultObserver.java
>> Thu Jun 28 18:41:34 2007
>> @@ -41,7 +41,7 @@
>>       * override the super class method
>>       */
>>      public void onMessage(Message m) {
>> -        // do nothing for exception occured during client sending out
>> request
>> +        // do nothing for exception occurred during client sending out
>> request
>>      }
>>  
>>      protected boolean isOutboundObserver() {
>> 
>> Modified:
>> incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/transport/http/Messages.properties
>> URL:
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/transport/http/Messages.properties?view=diff&rev=551748&r1=551747&r2=551748
>> ==============================================================================
>> ---
>> incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/transport/http/Messages.properties
>> (original)
>> +++
>> incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/transport/http/Messages.properties
>> Thu Jun 28 18:41:34 2007
>> @@ -18,4 +18,4 @@
>>  #    under the License.
>>  #
>>  #
>> -COULD_NOT_PROVIDE_WSDL = Exception occured while trying to process {0}
>> \ No newline at end of file
>> +COULD_NOT_PROVIDE_WSDL = Exception occurred while trying to process {0}
>> 
>> Modified:
>> incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/JaxwsServiceBuilder.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/JaxwsServiceBuilder.java?view=diff&rev=551748&r1=551747&r2=551748
>> ==============================================================================
>> ---
>> incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/JaxwsServiceBuilder.java
>> (original)
>> +++
>> incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/JaxwsServiceBuilder.java
>> Thu Jun 28 18:41:34 2007
>> @@ -45,7 +45,7 @@
>>      public void validate() {
>>          Class clz = getServiceClass();
>>          if (java.rmi.Remote.class.isAssignableFrom(clz)) {
>> -            throw new RuntimeException("JAXWS SEI can not implement
>> java.rmi.Remote interface.");
>> +            throw new RuntimeException("JAXWS SEIs may not implement the
>> java.rmi.Remote interface.");
>>          }
>>      }
>>      
>> 
>> Modified:
>> incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/Messages.properties
>> URL:
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/Messages.properties?view=diff&rev=551748&r1=551747&r2=551748
>> ==============================================================================
>> ---
>> incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/Messages.properties
>> (original)
>> +++
>> incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/Messages.properties
>> Thu Jun 28 18:41:34 2007
>> @@ -22,7 +22,7 @@
>>  NO_GETFAULTINFO_METHOD = JAX-WS faults are required to have a
>> getFaultInfo method.
>>  COULD_NOT_INVOKE = Could not invoke getFaultInfo method on Exception.
>>  DISPATCH_OBJECT_CANNOT_BE_NULL = Null object passed into Dispatch
>> marshalling
>> -EXCEPTION_WRITING_OBJECT = Exception occured while marshalling Dispatch
>> object to stream
>> +EXCEPTION_WRITING_OBJECT = Exception occurred while marshalling Dispatch
>> object to stream
>>  ATTACHMENT_NOT_SUPPORTED = Attachments of type {0} are not supported.
>>  DISPATCH_OBJECT_NOT_SUPPORTED_SOAPBINDING = {0} is not valid in {1} mode
>> with SOAP/HTTP binding.
>> -DISPATCH_OBJECT_NOT_SUPPORTED_XMLBINDING = {0} is not valid in {1} mode
>> with XML/HTTP binding.
>> \ No newline at end of file
>> +DISPATCH_OBJECT_NOT_SUPPORTED_XMLBINDING = {0} is not valid in {1} mode
>> with XML/HTTP binding.
>> 
>> Modified:
>> incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/http/GreeterImpl.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/http/GreeterImpl.java?view=diff&rev=551748&r1=551747&r2=551748
>> ==============================================================================
>> ---
>> incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/http/GreeterImpl.java
>> (original)
>> +++
>> incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/http/GreeterImpl.java
>> Thu Jun 28 18:41:34 2007
>> @@ -45,15 +45,13 @@
>>  
>>      public String greetMe(String me) {
>>          LOG.info("Executing operation greetMe");
>> -        //System.out.println("Executing operation greetMe");
>> -        //System.out.println("Message received: " + me + "\n");
>> +        LOG.info("Message received: " + me);
>>          return "Hello " + me;
>>      }
>>      
>>  
>>      public String sayHi() {
>> -        LOG.info("Executing operation sayHi");
>> -        //System.out.println("Executing operation sayHi\n");
>> +        LOG.info("Executing operation sayHi");        
>>          return "Bonjour from " + myName;
>>      }
>>      
>> 
>> Modified:
>> incubator/cxf/trunk/tools/javato/core/src/main/java/org/apache/cxf/tools/java2wsdl/processor/internal/ServiceBuilderFactory.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/tools/javato/core/src/main/java/org/apache/cxf/tools/java2wsdl/processor/internal/ServiceBuilderFactory.java?view=diff&rev=551748&r1=551747&r2=551748
>> ==============================================================================
>> ---
>> incubator/cxf/trunk/tools/javato/core/src/main/java/org/apache/cxf/tools/java2wsdl/processor/internal/ServiceBuilderFactory.java
>> (original)
>> +++
>> incubator/cxf/trunk/tools/javato/core/src/main/java/org/apache/cxf/tools/java2wsdl/processor/internal/ServiceBuilderFactory.java
>> Thu Jun 28 18:41:34 2007
>> @@ -49,7 +49,7 @@
>>              String clzName = getBuilderClassName(s);
>>              builder = (ServiceBuilder)
>> Class.forName(clzName).newInstance();
>>          } catch (Exception e) {
>> -            throw new ToolException("Can not find or initialize the
>> ServiceBulider for style: " + s
>> +            throw new ToolException("Can not find or initialize the
>> ServiceBuilder for style: " + s
>>                                      + " Reason: \n" + e.getMessage(),
>>                                      e);
>>          }
>> 
>> Modified:
>> incubator/cxf/trunk/tools/javato/test/src/test/java/org/apache/cxf/tools/java2wsdl/processor/JavaToProcessorTest.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/cxf/trunk/tools/javato/test/src/test/java/org/apache/cxf/tools/java2wsdl/processor/JavaToProcessorTest.java?view=diff&rev=551748&r1=551747&r2=551748
>> ==============================================================================
>> ---
>> incubator/cxf/trunk/tools/javato/test/src/test/java/org/apache/cxf/tools/java2wsdl/processor/JavaToProcessorTest.java
>> (original)
>> +++
>> incubator/cxf/trunk/tools/javato/test/src/test/java/org/apache/cxf/tools/java2wsdl/processor/JavaToProcessorTest.java
>> Thu Jun 28 18:41:34 2007
>> @@ -358,7 +358,7 @@
>>          try {
>>              processor.process();
>>          } catch (RuntimeException e) {
>> -            assertEquals("JAXWS SEI can not implement java.rmi.Remote
>> interface.", e.getMessage());
>> +            assertEquals("JAXWS SEIs may not implement the
>> java.rmi.Remote interface.", e.getMessage());
>>          }
>>      }
>>  }
>> 
>> 
>> 
>> 
> 
> 

-- 
View this message in context: http://www.nabble.com/svn-commit%3A-r551748---in--incubator-cxf-trunk%3A-api-src-main-java-org-apache-cxf--api-src-main-java-org-apache-cxf-binding--api-src-main-java-org-apache-cxf-phase--common-common-src-main-java-org-apache-cxf-configuration-spring--distribution-src-main-re...-tf3997742.html#a12060229
Sent from the cxf-commits mailing list archive at Nabble.com.


Mime
View raw message