Return-Path: 
 <cxf-commits-return-2048-apmail-incubator-cxf-commits-archive=incubator.apache.org@incubator.apache.org>
Delivered-To: apmail-incubator-cxf-commits-archive@locus.apache.org
Received: (qmail 30792 invoked from network); 22 May 2007 07:27:20 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 22 May 2007 07:27:20 -0000
Received: (qmail 55968 invoked by uid 500); 22 May 2007 07:27:25 -0000
Delivered-To: apmail-incubator-cxf-commits-archive@incubator.apache.org
Received: (qmail 55822 invoked by uid 500); 22 May 2007 07:27:24 -0000
Mailing-List: contact cxf-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:cxf-commits-help@incubator.apache.org>
List-Unsubscribe: <mailto:cxf-commits-unsubscribe@incubator.apache.org>
List-Post: <mailto:cxf-commits@incubator.apache.org>
List-Id: <cxf-commits.incubator.apache.org>
Reply-To: cxf-dev@incubator.apache.org
Delivered-To: mailing list cxf-commits@incubator.apache.org
Received: (qmail 55662 invoked by uid 99); 22 May 2007 07:27:24 -0000
Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 May 2007 00:27:24 -0700
X-ASF-Spam-Status: No, hits=-0.0 required=10.0
	tests=SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (herse.apache.org: domain of freeman.fang@iona.com
 designates 65.223.216.181 as permitted sender)
Received: from [65.223.216.181] (HELO amereast-smg1.iona.com) (65.223.216.181)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 May 2007 00:27:17 -0700
Received: from amer-ems1.IONAGLOBAL.COM ([10.65.6.25])
	by amereast-smg1.iona.com (Switch-3.1.7/Switch-3.1.7) with ESMTP id
 l4M7PdG7017496;
	Tue, 22 May 2007 03:25:40 -0400 (EDT)
Received: from [10.129.9.200] ([10.129.9.200]) by amer-ems1.IONAGLOBAL.COM
 with Microsoft SMTPSVC(6.0.3790.1830);
	 Tue, 22 May 2007 03:26:53 -0400
Message-ID: <4652992F.8020903@iona.com>
Date: Tue, 22 May 2007 15:18:07 +0800
From: Freeman Fang <freeman.fang@iona.com>
User-Agent: Thunderbird 1.5.0.2 (X11/20060524)
MIME-Version: 1.0
To: cxf-dev@incubator.apache.org
CC: cxf-commits@incubator.apache.org
Subject: Re: svn commit: r540413 - in
 /incubator/cxf/trunk/distribution/src/main/release/samples:
 common_build.xml hello_world/build.xml
 hello_world/src/demo/hw/client/Client.java
 hello_world/src/demo/hw/server/Server.java
References: <20070522040923.772681A981A@eris.apache.org>
 <465271FC.8060602@iona.com> <46527736.5030601@iona.com>
 <465295EF.5050601@iona.com>
In-Reply-To: <465295EF.5050601@iona.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 22 May 2007 07:26:54.0518 (UTC)
 FILETIME=[92A17D60:01C79C42]
X-Virus-Checked: Checked by ClamAV on apache.org

Hi James,
Not all demos has this problem, hello_world has this problem because it 
need load a cxf.xml which enable wsdl shema validation. And the cxf.xml 
itself cann't pass spring file validation.

Again, spring config file change is still in progress, I believe still 
other change will affect our demo or test which has spring config file, 
so I think before this task totally done, we can provide a way to 
isolate the spring validation, both for tests and demos.

In fact, we already do that in system test

<properties>
        <surefire.fork.mode>pertest</surefire.fork.mode>
        <spring.validation.mode>VALIDATION_NONE</spring.validation.mode>
    </properties>
Any thought?
Freeman

James Mao wrote:
> I'm just curious about is it just hello_world demo?
> I can see you change the /hello_world/build.xml and set the property 
> in the wsdl2java target.
> I assume all the demos which use wsdl2java has the same problem, right?
> if yes, then all the other demos has the same problem and they are not 
> fixed yet, this cause the demos not consistent.
>
> As you said there's a best way. i think we should go to the best way 
> directly.
> Good catch though
>
> James
>
>
>> Hi James,
>>
>> I believe Andrea open spring validation these days,
>>
>> And I guess she is still working on it. You can get more details from 
>> mails with title "CXF Extensions for Spring XML".
>>
>> In fact, the best way to fix this problem is change cxf.xml to make 
>> it pass spring validation after this spring bean refactor done.
>>
>> Any thoughts?
>> Thanks very much
>>
>> Freeman
>>
>> James Mao wrote:
>>> Is possible to set the spring.validation.mode to VALIDATION_NONE as 
>>> default in the Runtime?
>>> So in the client/server and tools you don't need to set the property
>>> IMO, this is really a redundant step for all users.
>>>
>>>
>>> James
>>>
>>>
>>>> Author: ffang
>>>> Date: Mon May 21 21:09:22 2007
>>>> New Revision: 540413
>>>>
>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=540413
>>>> Log:
>>>> [CXF-668] provide a way to let demo specify spring validation mode 
>>>> to get hello_world demo working
>>>>
>>>> Modified:
>>>>     
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/common_build.xml 
>>>>
>>>>     
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/build.xml 
>>>>
>>>>     
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/client/Client.java 
>>>>
>>>>     
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/server/Server.java 
>>>>
>>>>
>>>> Modified: 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/common_build.xml 
>>>>
>>>> URL: 
>>>> http://svn.apache.org/viewvc/incubator/cxf/trunk/distribution/src/main/release/samples/common_build.xml?view=diff&rev=540413&r1=540412&r2=540413 
>>>>
>>>> ============================================================================== 
>>>>
>>>> --- 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/common_build.xml 
>>>> (original)
>>>> +++ 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/common_build.xml 
>>>> Mon May 21 21:09:22 2007
>>>> @@ -200,13 +200,14 @@
>>>>                  </not>
>>>>              </condition>
>>>>              <property name="binding.arg" value=""/>
>>>> -
>>>> +        <property name="spring.validation.mode" 
>>>> value="VALIDATION_AUTO"/>
>>>>              <java failonerror="true" 
>>>> classname="org.apache.cxf.tools.wsdlto.WSDLToJava" fork="yes">
>>>>                  <classpath>
>>>>                      <path refid="cxf.classpath" />
>>>>                  </classpath>
>>>>                  <sysproperty key="java.util.logging.config.file" 
>>>> value="${cxf.etc.dir}/logging.properties"/>
>>>>                  <sysproperty key="exitOnFinish" value="true"/>
>>>> +                <sysproperty key="spring.validation.mode" 
>>>> value="${spring.validation.mode}"/>
>>>>                  <arg line="@{servicename.arg}"/>
>>>>                  <arg line="${package.arg.@{file}}"/>
>>>>                  <arg line="${binding.arg}"/>
>>>>
>>>> Modified: 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/build.xml 
>>>>
>>>> URL: 
>>>> http://svn.apache.org/viewvc/incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/build.xml?view=diff&rev=540413&r1=540412&r2=540413 
>>>>
>>>> ============================================================================== 
>>>>
>>>> --- 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/build.xml 
>>>> (original)
>>>> +++ 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/build.xml 
>>>> Mon May 21 21:09:22 2007
>>>> @@ -44,6 +44,7 @@
>>>>               <target name="generate.code">
>>>>          <echo level="info" message="Generating code using 
>>>> wsdl2java..."/>
>>>> +        <property name="spring.validation.mode" 
>>>> value="VALIDATION_NONE"/>
>>>>          <wsdl2java file="hello_world.wsdl"/>
>>>>      </target>
>>>>  
>>>>
>>>> Modified: 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/client/Client.java 
>>>>
>>>> URL: 
>>>> http://svn.apache.org/viewvc/incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/client/Client.java?view=diff&rev=540413&r1=540412&r2=540413 
>>>>
>>>> ============================================================================== 
>>>>
>>>> --- 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/client/Client.java 
>>>> (original)
>>>> +++ 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/client/Client.java 
>>>> Mon May 21 21:09:22 2007
>>>> @@ -52,6 +52,7 @@
>>>>          }
>>>>                   System.out.println(wsdlURL);
>>>> +        System.setProperty("spring.validation.mode", 
>>>> "VALIDATION_NONE");
>>>>          SOAPService ss = new SOAPService(wsdlURL, SERVICE_NAME);
>>>>          Greeter port = ss.getSoapPort();
>>>>          String resp;
>>>> Modified: 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/server/Server.java 
>>>>
>>>> URL: 
>>>> http://svn.apache.org/viewvc/incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/server/Server.java?view=diff&rev=540413&r1=540412&r2=540413 
>>>>
>>>> ============================================================================== 
>>>>
>>>> --- 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/server/Server.java 
>>>> (original)
>>>> +++ 
>>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/server/Server.java 
>>>> Mon May 21 21:09:22 2007
>>>> @@ -25,7 +25,7 @@
>>>>  
>>>>      protected Server() throws Exception {
>>>>          System.out.println("Starting Server");
>>>> -
>>>> +        System.setProperty("spring.validation.mode", 
>>>> "VALIDATION_NONE");
>>>>          Object implementor = new GreeterImpl();
>>>>          String address = 
>>>> "http://localhost:9000/SoapContext/SoapPort";
>>>>          Endpoint.publish(address, implementor);
>>>>
>>>>
>>>>
>>>>   
>>>
>>>
>>
>>
>
>