Mailing-List: contact cxf-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cxf-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: domain of james.mao@iona.com designates
 65.223.216.181 as permitted sender)
Message-ID: <465295EF.5050601@iona.com>
Date: Tue, 22 May 2007 15:04:15 +0800
From: James Mao <james.mao@iona.com>
User-Agent: Thunderbird 1.5.0.10 (Windows/20070221)
MIME-Version: 1.0
To: cxf-dev@incubator.apache.org
CC: cxf-commits@incubator.apache.org
Subject: Re: svn commit: r540413 - in
 /incubator/cxf/trunk/distribution/src/main/release/samples:
 common_build.xml hello_world/build.xml
 hello_world/src/demo/hw/client/Client.java
 hello_world/src/demo/hw/server/Server.java
References: <20070522040923.772681A981A@eris.apache.org>
 <465271FC.8060602@iona.com> <46527736.5030601@iona.com>
In-Reply-To: <46527736.5030601@iona.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

I'm just curious about is it just hello_world demo?
I can see you change the /hello_world/build.xml and set the property in 
the wsdl2java target.
I assume all the demos which use wsdl2java has the same problem, right?
if yes, then all the other demos has the same problem and they are not 
fixed yet, this cause the demos not consistent.

As you said there's a best way. i think we should go to the best way 
directly.
Good catch though

James


> Hi James,
>
> I believe Andrea open spring validation these days,
>
> And I guess she is still working on it. You can get more details from 
> mails with title "CXF Extensions for Spring XML".
>
> In fact, the best way to fix this problem is change cxf.xml to make it 
> pass spring validation after this spring bean refactor done.
>
> Any thoughts?
> Thanks very much
>
> Freeman
>
> James Mao wrote:
>> Is possible to set the spring.validation.mode to VALIDATION_NONE as 
>> default in the Runtime?
>> So in the client/server and tools you don't need to set the property
>> IMO, this is really a redundant step for all users.
>>
>>
>> James
>>
>>
>>> Author: ffang
>>> Date: Mon May 21 21:09:22 2007
>>> New Revision: 540413
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=540413
>>> Log:
>>> [CXF-668] provide a way to let demo specify spring validation mode 
>>> to get hello_world demo working
>>>
>>> Modified:
>>>     
>>> incubator/cxf/trunk/distribution/src/main/release/samples/common_build.xml 
>>>
>>>     
>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/build.xml 
>>>
>>>     
>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/client/Client.java 
>>>
>>>     
>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/server/Server.java 
>>>
>>>
>>> Modified: 
>>> incubator/cxf/trunk/distribution/src/main/release/samples/common_build.xml 
>>>
>>> URL: 
>>> http://svn.apache.org/viewvc/incubator/cxf/trunk/distribution/src/main/release/samples/common_build.xml?view=diff&rev=540413&r1=540412&r2=540413 
>>>
>>> ============================================================================== 
>>>
>>> --- 
>>> incubator/cxf/trunk/distribution/src/main/release/samples/common_build.xml 
>>> (original)
>>> +++ 
>>> incubator/cxf/trunk/distribution/src/main/release/samples/common_build.xml 
>>> Mon May 21 21:09:22 2007
>>> @@ -200,13 +200,14 @@
>>>                  </not>
>>>              </condition>
>>>              <property name="binding.arg" value=""/>
>>> -
>>> +        <property name="spring.validation.mode" 
>>> value="VALIDATION_AUTO"/>
>>>              <java failonerror="true" 
>>> classname="org.apache.cxf.tools.wsdlto.WSDLToJava" fork="yes">
>>>                  <classpath>
>>>                      <path refid="cxf.classpath" />
>>>                  </classpath>
>>>                  <sysproperty key="java.util.logging.config.file" 
>>> value="${cxf.etc.dir}/logging.properties"/>
>>>                  <sysproperty key="exitOnFinish" value="true"/>
>>> +                <sysproperty key="spring.validation.mode" 
>>> value="${spring.validation.mode}"/>
>>>                  <arg line="@{servicename.arg}"/>
>>>                  <arg line="${package.arg.@{file}}"/>
>>>                  <arg line="${binding.arg}"/>
>>>
>>> Modified: 
>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/build.xml 
>>>
>>> URL: 
>>> http://svn.apache.org/viewvc/incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/build.xml?view=diff&rev=540413&r1=540412&r2=540413 
>>>
>>> ============================================================================== 
>>>
>>> --- 
>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/build.xml 
>>> (original)
>>> +++ 
>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/build.xml 
>>> Mon May 21 21:09:22 2007
>>> @@ -44,6 +44,7 @@
>>>               <target name="generate.code">
>>>          <echo level="info" message="Generating code using 
>>> wsdl2java..."/>
>>> +        <property name="spring.validation.mode" 
>>> value="VALIDATION_NONE"/>
>>>          <wsdl2java file="hello_world.wsdl"/>
>>>      </target>
>>>  
>>>
>>> Modified: 
>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/client/Client.java 
>>>
>>> URL: 
>>> http://svn.apache.org/viewvc/incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/client/Client.java?view=diff&rev=540413&r1=540412&r2=540413 
>>>
>>> ============================================================================== 
>>>
>>> --- 
>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/client/Client.java 
>>> (original)
>>> +++ 
>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/client/Client.java 
>>> Mon May 21 21:09:22 2007
>>> @@ -52,6 +52,7 @@
>>>          }
>>>                   System.out.println(wsdlURL);
>>> +        System.setProperty("spring.validation.mode", 
>>> "VALIDATION_NONE");
>>>          SOAPService ss = new SOAPService(wsdlURL, SERVICE_NAME);
>>>          Greeter port = ss.getSoapPort();
>>>          String resp;
>>> Modified: 
>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/server/Server.java 
>>>
>>> URL: 
>>> http://svn.apache.org/viewvc/incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/server/Server.java?view=diff&rev=540413&r1=540412&r2=540413 
>>>
>>> ============================================================================== 
>>>
>>> --- 
>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/server/Server.java 
>>> (original)
>>> +++ 
>>> incubator/cxf/trunk/distribution/src/main/release/samples/hello_world/src/demo/hw/server/Server.java 
>>> Mon May 21 21:09:22 2007
>>> @@ -25,7 +25,7 @@
>>>  
>>>      protected Server() throws Exception {
>>>          System.out.println("Starting Server");
>>> -
>>> +        System.setProperty("spring.validation.mode", 
>>> "VALIDATION_NONE");
>>>          Object implementor = new GreeterImpl();
>>>          String address = "http://localhost:9000/SoapContext/SoapPort";
>>>          Endpoint.publish(address, implementor);
>>>
>>>
>>>
>>>   
>>
>>
>
>