cxf-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Glynn, Eoghan" <eoghan.gl...@iona.com>
Subject RE: svn commit: r497869 - /incubator/cxf/trunk/rt/transports/http2/src/main/java/org/apache/cxf/transport/http/JettyHTTPDestination.java
Date Fri, 19 Jan 2007 17:15:25 GMT

Hi Willem,

Why all the duplication in rt-transports-http2?

If we're going to keep the Jetty5-based rt-transports-http stuff, then
the two modules should be merged so as to avoid duplication, with common
code factored up into abstract base classes.

I've raised an JIRA task for a similar refactoring of the
duplication-heavy servlet code:
http://issues.apache.org/jira/browse/CXF-343

Cheers,
Eoghan

> -----Original Message-----
> From: ningjiang@apache.org [mailto:ningjiang@apache.org] 
> Sent: 19 January 2007 16:48
> To: cxf-commits@incubator.apache.org
> Subject: svn commit: r497869 - 
> /incubator/cxf/trunk/rt/transports/http2/src/main/java/org/apa
> che/cxf/transport/http/JettyHTTPDestination.java
> 
> Author: ningjiang
> Date: Fri Jan 19 08:47:39 2007
> New Revision: 497869
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=497869
> Log:
> Get the ?wsdl work again
> 
> Modified:
>     
> incubator/cxf/trunk/rt/transports/http2/src/main/java/org/apac
> he/cxf/transport/http/JettyHTTPDestination.java
> 
> Modified: 
> incubator/cxf/trunk/rt/transports/http2/src/main/java/org/apac
> he/cxf/transport/http/JettyHTTPDestination.java
> URL: 
> http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/transports
> /http2/src/main/java/org/apache/cxf/transport/http/JettyHTTPDe
> stination.java?view=diff&rev=497869&r1=497868&r2=497869
> ==============================================================
> ================
> --- 
> incubator/cxf/trunk/rt/transports/http2/src/main/java/org/apac
> he/cxf/transport/http/JettyHTTPDestination.java (original)
> +++ 
> incubator/cxf/trunk/rt/transports/http2/src/main/java/org/apache/cxf
> +++ /transport/http/JettyHTTPDestination.java Fri Jan 19 08:47:39 2007
> @@ -253,7 +253,8 @@
>              return;
>          }
>  
> -        if ("GET".equals(req.getMethod()) && 
> req.getRequestURI().toString().toLowerCase().endsWith("?wsdl")) {
> +        if ("GET".equals(req.getMethod()) && 
> req.getQueryString() != null 
> +            && req.getQueryString().toLowerCase().equals("wsdl")) {
>              try {
>  
>                  
> resp.addHeader(HttpHeaderHelper.CONTENT_TYPE, "text/xml");
> 
> 
> 

Mime
View raw message