Return-Path: Delivered-To: apmail-incubator-cxf-commits-archive@locus.apache.org Received: (qmail 81023 invoked from network); 13 Sep 2006 10:13:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 13 Sep 2006 10:13:45 -0000 Received: (qmail 50564 invoked by uid 500); 13 Sep 2006 10:13:44 -0000 Delivered-To: apmail-incubator-cxf-commits-archive@incubator.apache.org Received: (qmail 50491 invoked by uid 500); 13 Sep 2006 10:13:44 -0000 Mailing-List: contact cxf-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cxf-dev@incubator.apache.org Delivered-To: mailing list cxf-commits@incubator.apache.org Received: (qmail 50482 invoked by uid 99); 13 Sep 2006 10:13:44 -0000 Received: from idunn.apache.osuosl.org (HELO idunn.apache.osuosl.org) (140.211.166.84) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Sep 2006 03:13:44 -0700 Authentication-Results: idunn.apache.osuosl.org smtp.mail=eoghan.glynn@iona.com; spf=pass X-ASF-Spam-Status: No, hits=0.1 required=5.0 tests=FORGED_RCVD_HELO Received-SPF: pass (idunn.apache.osuosl.org: domain iona.com designates 62.221.12.33 as permitted sender) Received: from ([62.221.12.33:38449] helo=emea-smg1.iona.com) by idunn.apache.osuosl.org (ecelerity 2.1 r(10620)) with ESMTP id D3/20-08973-3E9D7054 for ; Wed, 13 Sep 2006 03:13:57 -0700 Received: from emea-ems1.ionaglobal.com (dutec.ie [10.2.1.125]) by emea-smg1.iona.com (Switch-3.1.7/Switch-3.1.7) with ESMTP id k8D9kYKB014688; Wed, 13 Sep 2006 09:46:34 GMT X-MimeOLE: Produced By Microsoft Exchange V6.0.6603.0 content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: quoted-printable Subject: RE: svn commit: r442861 - in /incubator/cxf/trunk: api/src/main/java/org/apache/cxf/endpoint/ rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/interceptor/ rt/core/src/main/java/org/apache/cxf/endpoint/ rt/frontend/jaxws/src/main/java/org/apache Date: Wed, 13 Sep 2006 11:13:35 +0100 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: svn commit: r442861 - in /incubator/cxf/trunk: api/src/main/java/org/apache/cxf/endpoint/ rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/interceptor/ rt/core/src/main/java/org/apache/cxf/endpoint/ rt/frontend/jaxws/src/main/java/org/apache Thread-Index: AcbW/FJkMQhUn/m1S1aIfX0hIPGZIgAGi60Q From: "Glynn, Eoghan" To: , X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Hi Tom, Your change to ClientImpl conflicted with some changes I'd made in my working copy, around setting the Method property on the OperationInfo on the client side. Not a problem, I've resolved the conflict but I did notice you commented out newly redundant code in ClientImpl & EndpointInvocationHandler. IMO this practice should this avoided for reasons of code readability. Just remove the dead code ... if we ever need to restore it, it can be reconstructed from the version log maintained by SVN. Cheers, Eoghan=20 > -----Original Message----- > From: tli@apache.org [mailto:tli@apache.org]=20 > Sent: 13 September 2006 07:17 > To: cxf-commits@incubator.apache.org > Subject: svn commit: r442861 - in /incubator/cxf/trunk:=20 > api/src/main/java/org/apache/cxf/endpoint/=20 > rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/int > erceptor/ rt/core/src/main/java/org/apache/cxf/endpoint/=20 > rt/frontend/jaxws/src/main/java/org/apache/... >=20 > Author: tli > Date: Tue Sep 12 23:17:02 2006 > New Revision: 442861 >=20 > URL: http://svn.apache.org/viewvc?view=3Drev&rev=3D442861 > Log: > rollback api change of Endpoint, using method set in the=20 > OperationInfo, change the client side using method set in=20 > OperationInfo instead of method set in Message >=20 > Modified: > =20 > incubator/cxf/trunk/api/src/main/java/org/apache/cxf/endpoint/ > Endpoint.java > =20 > incubator/cxf/trunk/rt/bindings/soap/src/main/java/org/apache/ > cxf/binding/soap/interceptor/RPCInInterceptor.java > =20 > incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/endpo > int/ClientImpl.java > =20 > incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/endpo > int/EndpointImpl.java > =20 > incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache > /cxf/jaxws/EndpointImpl.java > =20 > incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache > /cxf/jaxws/EndpointInvocationHandler.java > =20 > incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache > /cxf/jaxws/ServiceImpl.java > =20 > incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache > /cxf/jaxws/interceptors/WrapperClassInInterceptor.java > =20 > incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/jaxw > s/ClientServerRPCLitTest.java >=20 > Modified:=20 > incubator/cxf/trunk/api/src/main/java/org/apache/cxf/endpoint/ > Endpoint.java > URL:=20 > http://svn.apache.org/viewvc/incubator/cxf/trunk/api/src/main/ > java/org/apache/cxf/endpoint/Endpoint.java?view=3Ddiff&rev=3D44286 > 1&r1=3D442860&r2=3D442861 > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > ---=20 > incubator/cxf/trunk/api/src/main/java/org/apache/cxf/endpoint/ > Endpoint.java (original) > +++=20 > incubator/cxf/trunk/api/src/main/java/org/apache/cxf/endpoint/Endpoi > +++ nt.java Tue Sep 12 23:17:02 2006 > @@ -44,8 +44,5 @@ > Executor getExecutor(); > =20 > Interceptor getFaultInterceptor(); > - =20 > - Object getImplementor(); > - =20 > - void setImplementor(Object impl); > + > } >=20 > Modified:=20 > incubator/cxf/trunk/rt/bindings/soap/src/main/java/org/apache/ > cxf/binding/soap/interceptor/RPCInInterceptor.java > URL:=20 > http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/bindings/s > oap/src/main/java/org/apache/cxf/binding/soap/interceptor/RPCI > nInterceptor.java?view=3Ddiff&rev=3D442861&r1=3D442860&r2=3D442861 > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > ---=20 > incubator/cxf/trunk/rt/bindings/soap/src/main/java/org/apache/ > cxf/binding/soap/interceptor/RPCInInterceptor.java (original) > +++=20 > incubator/cxf/trunk/rt/bindings/soap/src/main/java/org/apache/cxf/bi > +++ nding/soap/interceptor/RPCInInterceptor.java Tue Sep 12 23:17:02=20 > +++ 2006 > @@ -26,7 +26,6 @@ > import javax.xml.namespace.QName; > =20 > import org.apache.cxf.databinding.DataReader; > -import org.apache.cxf.endpoint.Endpoint; import=20 > org.apache.cxf.interceptor.AbstractInDatabindingInterceptor; > import org.apache.cxf.message.Message; > import org.apache.cxf.phase.Phase; > @@ -36,7 +35,6 @@ > import org.apache.cxf.service.model.ServiceModelUtil; > import org.apache.cxf.staxutils.DepthXMLStreamReader; > import org.apache.cxf.staxutils.StaxUtils; > -import org.apache.cxf.tools.util.ProcessorUtil; > =20 > public class RPCInInterceptor extends=20 > AbstractInDatabindingInterceptor { > =20 > @@ -68,19 +66,20 @@ > =20 > BindingOperationInfo operation =3D null; > if=20 > (message.getExchange().get(BindingOperationInfo.class) =3D=3D null) { > - operation =3D getOperation(message, xmlReader); = =20 > + operation =3D getOperation(message, xmlReader); > // Store operation into the message. > =20 > message.getExchange().put(BindingOperationInfo.class, operation); > } else { > operation =3D=20 > message.getExchange().get(BindingOperationInfo.class); > } > - findMethod(message); > MessageInfo msg; > DataReader dr =3D getMessageDataReader(message); > =20 > if (!isRequestor(message)) { > + System.out.println("Server"); > msg =3D operation.getInput().getMessageInfo(); > } else { > + System.out.println("Client"); > msg =3D operation.getOutput().getMessageInfo(); > } > =20 > @@ -101,44 +100,11 @@ > String expMessage =3D "Parameter " + name + "=20 > does not equal to the name in the servicemodel!"; > message.setContent(Exception.class, new=20 > RuntimeException(expMessage)); > } > - Object param =3D dr.read(elName, message,=20 > getParameterTypeClass(message, idx)); > + Method meth =3D (Method)=20 > operation.getOperationInfo().getProperty(Method.class.getName()); > + System.out.println("meth is null =3D " + (meth =3D=3D = null)); > + Object param =3D dr.read(elName, message,=20 > + meth.getParameterTypes()[idx]); > parameters.add(param); > } > message.setContent(List.class, parameters); > - } > - > - private void findMethod(Message message) { > - Endpoint ep =3D message.getExchange().get(Endpoint.class); > - BindingOperationInfo boi =3D=20 > message.getExchange().get(BindingOperationInfo.class); > - Class implementorClass =3D null; > - if (!isRequestor(message)) { > - implementorClass =3D ep.getImplementor().getClass(); > - } else { > - implementorClass =3D (Class)ep.getImplementor(); > - } > - for (Method meth : implementorClass.getDeclaredMethods()) { > - String opName =3D=20 > boi.getOperationInfo().getName().getLocalPart(); > - if=20 > (ProcessorUtil.mangleNameToVariableName(meth.getName()).equals > (opName)) { > - message.put(Method.class, meth); > - break; > - } > - } > - } > - > - private Class getParameterTypeClass(Message message, int idx) { > - Method method =3D message.get(Method.class); > - BindingOperationInfo boi =3D=20 > message.getExchange().get(BindingOperationInfo.class); > - MessageInfo mi; > - if (!isRequestor(message)) { > - mi =3D boi.getOperationInfo().getInput(); > - } else { > - mi =3D boi.getOperationInfo().getOutput(); > - } > - MessagePartInfo mpi =3D mi.getMessagePartByIndex(idx); > - if (!mpi.isElement()) { > - return method.getParameterTypes()[idx]; > - } else { > - return null; > - } > } > } >=20 > Modified:=20 > incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/endpo > int/ClientImpl.java > URL:=20 > http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/core/src/m > ain/java/org/apache/cxf/endpoint/ClientImpl.java?view=3Ddiff&rev > =3D442861&r1=3D442860&r2=3D442861 > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > ---=20 > incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/endpo > int/ClientImpl.java (original) > +++=20 > incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/endpoint/Cl > +++ ientImpl.java Tue Sep 12 23:17:02 2006 > @@ -78,7 +78,8 @@ > LOG.fine("Invoke, operation info: " + oi + ",=20 > params: " + params); > } > Message message =3D endpoint.getBinding().createMessage(); > - setMethod(ctx, message); > + =20 > + //setMethod(ctx, message); > setParameters(params, message); > Exchange exchange =3D new ExchangeImpl(); > if (null !=3D ctx) { > @@ -182,12 +183,12 @@ > } > } > =20 > - private void setMethod(Map ctx, Message=20 > message) { > - if (ctx !=3D null) { > - message.setContent(Method.class,=20 > ctx.get(Method.class.getName())); > - methd =3D (Method)ctx.get(Method.class.getName()); > - } > - } > +// private void setMethod(Map ctx,=20 > Message message) { > +// if (ctx !=3D null) { > +// message.setContent(Method.class,=20 > ctx.get(Method.class.getName())); > +// methd =3D (Method)ctx.get(Method.class.getName()); > +// } > +// } > =20 > =20 > =20 >=20 > Modified:=20 > incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/endpo > int/EndpointImpl.java > URL:=20 > http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/core/src/m > ain/java/org/apache/cxf/endpoint/EndpointImpl.java?view=3Ddiff&r > ev=3D442861&r1=3D442860&r2=3D442861 > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > ---=20 > incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/endpo > int/EndpointImpl.java (original) > +++=20 > incubator/cxf/trunk/rt/core/src/main/java/org/apache/cxf/endpoint/En > +++ dpointImpl.java Tue Sep 12 23:17:02 2006 > @@ -47,7 +47,6 @@ > private Executor executor; > private Bus bus; > private Interceptor faultInterceptor; > - private Object implementor; > =20 > public EndpointImpl(Bus bus, Service s, EndpointInfo ei)=20 > throws EndpointException { > this.bus =3D bus; > @@ -105,14 +104,6 @@ > Message msg =3D new Message("NO_BINDING_FACTORY",=20 > BUNDLE, namespace); > throw new EndpointException(msg); > } > - } > - > - public Object getImplementor() { > - return implementor; > - } > - > - public void setImplementor(Object implementor) { > - this.implementor =3D implementor; > } > =20 > } >=20 > Modified:=20 > incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache > /cxf/jaxws/EndpointImpl.java > URL:=20 > http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/j > axws/src/main/java/org/apache/cxf/jaxws/EndpointImpl.java?view > =3Ddiff&rev=3D442861&r1=3D442860&r2=3D442861 > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > ---=20 > incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache > /cxf/jaxws/EndpointImpl.java (original) > +++=20 > incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/j > +++ axws/EndpointImpl.java Tue Sep 12 23:17:02 2006 > @@ -84,8 +84,7 @@ > } > // TODO: use bindigURI =20 > try { > - endpoint =3D new JaxwsEndpointImpl(bus, service, ei); > - endpoint.setImplementor(implementor); > + endpoint =3D new JaxwsEndpointImpl(bus, service,=20 > ei); =20 > } catch (EndpointException e) { > throw new WebServiceException(e); > } >=20 > Modified:=20 > incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache > /cxf/jaxws/EndpointInvocationHandler.java > URL:=20 > http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/j > axws/src/main/java/org/apache/cxf/jaxws/EndpointInvocationHand > ler.java?view=3Ddiff&rev=3D442861&r1=3D442860&r2=3D442861 > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > ---=20 > incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache > /cxf/jaxws/EndpointInvocationHandler.java (original) > +++=20 > incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/j > +++ axws/EndpointInvocationHandler.java Tue Sep 12 23:17:02 2006 > @@ -95,7 +95,7 @@ > =20 > Object[] paramsWithOutHolder =3D handleHolder(params); > Map context =3D new HashMap(); > - context.put(Method.class.getName(), method); > + //context.put(Method.class.getName(), method); > =20 > =20 > boolean isAsync =3D method.getName().endsWith("Async"); > @@ -200,6 +200,7 @@ > =20 > oi.setProperty(WrapperClassOutInterceptor.SINGLE_WRAPPED_PART, > requestWrapper); > =20 > boi2.getOperationInfo().setProperty(WrappedInInterceptor.SINGL > E_WRAPPED_PART, > Boolean.TRUE); > + =20 > + boi3.getOperationInfo().setProperty(Method.class.getName(), method); > infoMap.put(method, boi3); > return boi3; > } > @@ -208,7 +209,8 @@ > // TODO - exception > } > } > - infoMap.put(method, boi2); > + =20 > boi2.getOperationInfo().setProperty(Method.class.getName(), method); > + infoMap.put(method, boi2); =20 > return boi2; > } > } >=20 > Modified:=20 > incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache > /cxf/jaxws/ServiceImpl.java > URL:=20 > http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/j > axws/src/main/java/org/apache/cxf/jaxws/ServiceImpl.java?view=3D > diff&rev=3D442861&r1=3D442860&r2=3D442861 > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > ---=20 > incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache > /cxf/jaxws/ServiceImpl.java (original) > +++=20 > incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/j > +++ axws/ServiceImpl.java Tue Sep 12 23:17:02 2006 > @@ -203,8 +203,7 @@ > =20 > JaxwsEndpointImpl jaxwsEndpoint; > try { > - jaxwsEndpoint =3D new JaxwsEndpointImpl(bus, service, = ei); > - jaxwsEndpoint.setImplementor(serviceEndpointInterface); > + jaxwsEndpoint =3D new JaxwsEndpointImpl(bus,=20 > service, ei); =20 > } catch (EndpointException e) { > throw new WebServiceException(e); > } >=20 > Modified:=20 > incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache > /cxf/jaxws/interceptors/WrapperClassInInterceptor.java > URL:=20 > http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/j > axws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperCl > assInInterceptor.java?view=3Ddiff&rev=3D442861&r1=3D442860&r2=3D442861 > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > ---=20 > incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache > /cxf/jaxws/interceptors/WrapperClassInInterceptor.java (original) > +++=20 > incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/j > +++ axws/interceptors/WrapperClassInInterceptor.java Tue Sep=20 > 12 23:17:02=20 > +++ 2006 > @@ -37,8 +37,6 @@ > import org.apache.cxf.service.model.MessagePartInfo; > import org.apache.cxf.service.model.OperationInfo; > =20 > - > - > public class WrapperClassInInterceptor extends=20 > AbstractPhaseInterceptor { > =20 > public WrapperClassInInterceptor() { @@ -52,8 +50,8 @@ > return; > } > Method method =3D=20 > (Method)boi.getOperationInfo().getProperty(Method.class.getName()); > - if (method =3D=3D null) { > - method =3D message.getContent(Method.class); > + if (method =3D=3D null) { =20 > + method =3D=20 > + (Method)boi.getOperationInfo().getProperty(Method.class.getName()); > } > if (method !=3D null && method.getName().endsWith("Async")) { > return; > @@ -113,7 +111,7 @@ > =20 > CastUtils.cast(lst,=20 > Object.class).add(obj); > } catch (Exception e) { > - //TODO - fault > + // TODO - fault > throw new Fault(e); > } > } > @@ -124,5 +122,4 @@ > } > } > =20 > - =20 > } >=20 > Modified:=20 > incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/jaxw > s/ClientServerRPCLitTest.java > URL:=20 > http://svn.apache.org/viewvc/incubator/cxf/trunk/systests/src/ > test/java/org/apache/cxf/jaxws/ClientServerRPCLitTest.java?vie > w=3Ddiff&rev=3D442861&r1=3D442860&r2=3D442861 > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > ---=20 > incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/jaxw > s/ClientServerRPCLitTest.java (original) > +++=20 > incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/jaxws/Clie > +++ ntServerRPCLitTest.java Tue Sep 12 23:17:02 2006 > @@ -71,7 +71,6 @@ > } > =20 > public void testBasicConnection() throws Exception { > - > SOAPServiceRPCLit service =3D new SOAPServiceRPCLit(); > assertNotNull(service); > =20 >=20 >=20 >=20