cxf-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Glynn, Eoghan" <eoghan.gl...@iona.com>
Subject RE: svn commit: r449549 - /incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java
Date Mon, 25 Sep 2006 09:19:50 GMT

PMD often reports false positives for its unused private method rule -
I've seen this happen if the method signature is templated, has multiple
overrides, or is defined after its called.

Its really annoying to say the least. Sometimes the spurious warning can
be made go away by re-ordering the code slightly, other-times it simpler
to just work-around the issue by changing the access modifier to
protected.

Since the rule enforcement logic seems broken in PMD, I'd just as soon
disbale the rule. However I've seen too much time burned in religious
wars about code style, and the automated checking thereof, to bother
bringing this up ... ;)

/Eoghan

> -----Original Message-----
> From: Dan Diephouse [mailto:dan@envoisolutions.com] 
> Sent: 25 September 2006 03:58
> To: cxf-dev@incubator.apache.org
> Cc: cxf-commits@incubator.apache.org
> Subject: Re: svn commit: r449549 - 
> /incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apach
> e/cxf/jaxws/support/JaxWsServiceFactoryBean.java
> 
> Thanks - but can you explain why that fixes the pmd 
> complaint? Are private methods not allowed? That seems silly :-)
> 
> - Dan
> 
> ningjiang@apache.org wrote:
> > Author: ningjiang
> > Date: Sun Sep 24 19:38:12 2006
> > New Revision: 449549
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=449549
> > Log:
> > fixed the pmd error for intializeWrapping
> >
> > Modified:
> >     
> > 
> incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jax
> > ws/support/JaxWsServiceFactoryBean.java
> >
> > Modified: 
> > 
> incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jax
> > ws/support/JaxWsServiceFactoryBean.java
> > URL: 
> > 
> http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/jaxws/src
> > 
> /main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java?v
> > iew=diff&rev=449549&r1=449548&r2=449549
> > 
> ======================================================================
> > ========
> > --- 
> > 
> incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jax
> > ws/support/JaxWsServiceFactoryBean.java (original)
> > +++ 
> incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf
> > +++ /jaxws/support/JaxWsServiceFactoryBean.java Sun Sep 24 19:38:12 
> > +++ 2006
> > @@ -154,7 +154,7 @@
> >          initalizeClassInfo(o, method);
> >      }
> >  
> > -    private void intializeWrapping(OperationInfo o, Method 
> selected) {
> > +    void intializeWrapping(OperationInfo o, Method selected) {
> >          Class responseWrapper = getResponseWrapper(selected);
> >          if (responseWrapper != null) {
> >              
> > 
> o.getUnwrappedOperation().getOutput().setProperty(WrapperClassOutInter
> > ceptor.WRAPPER_CLASS,
> >
> >
> >   
> 
> 
> --
> Dan Diephouse
> Envoi Solutions
> http://envoisolutions.com
> http://netzooid.com/blog
> 
> 

Mime
View raw message