cxf-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Freeman Fang <freeman.f...@iona.com>
Subject Re: svn commit: r439963 - in /incubator/cxf/trunk: common/src/main/java/org/apache/cxf/staxutils/ rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/interceptor/ rt/bindings/soap/src/test/java/org/apache/cxf/binding/soap/ rt/core/src/main/java/org
Date Fri, 08 Sep 2006 08:08:04 GMT
Hi Eoghan,

You are totally correct, in fact, I am refactoring this part now.

Thanks very much

Freeman

Glynn, Eoghan wrote:

>Hi Freeman,
>
>I was a bit confused by your change to the SoapOutInterceptor below,
>which seems to only allow the header parts to be mbe added if no
>previous interceptor has added a header.
>
>Obviously this would not be the case when the WS-A interceptor adds
>wsa:* headers. 
>
>Can you review the change I committed to SoapOutInterceptor to allow
>interceptor-provided headers and message-specific headers to both be
>marshalled.
>
>Cheers,
>Eoghan
>
>  
>
>>Modified: 
>>incubator/cxf/trunk/rt/bindings/soap/src/main/java/org/apache/
>>cxf/binding/soap/interceptor/SoapOutInterceptor.java
>>    
>>
>
>[snip]
>
>  
>
>>             Element eleHeaders = message.getHeaders(Element.class);
>>-            
>>-
>>             if (eleHeaders != null) {
>>                 StaxUtils.writeElement(eleHeaders, xtw, true);
>>-            }
>>+            } else {
>>             
>>+                handleHeaderPart(message);
>>+            }
>>
>
>
>  
>


-- 
Freeman Fang
Software Engineer

IONA Asia Pacific Software Development Center
No.2 Floor A Unit Information Center
Zhongguancun Software Park Haidian District,
Beijing, P.R.China

Tel.: +86-10-82825151 -  ex. 551
Fax: +86-10-8282-5210
freeman.fang@iona.com
-------------------------------------------------
Making Software Work Together TM




Mime
View raw message