cxf-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Kulp <daniel.k...@iona.com>
Subject Re: svn commit: r449549 - /incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java
Date Mon, 25 Sep 2006 19:58:42 GMT

Eoghan,

Have you run into those issues recently?   They are supposedly fixed in 3.7 
released in June:
http://sourceforge.net/project/shownotes.php?release_id=421303&group_id=56262
The lastest version of  the PMD maven plugin (version 2.1) does use 3.7.

It's quite possible the cruisecontrol machine hasn't updated it's plugin in a 
while....

Yep, that's it.   It only has version 2.0 in the repository directory of the 
user.   That's why it worked fine for you, but not cruisecontrol.   I'm not 
sure why maven wasn't downloading a new version.   That kind of sucks.  
Sometimes maven can be quite frustrating.


Dan



On Monday September 25 2006 3:27 pm, Dan Diephouse wrote:
> Well, if it doesn't work I think we should disable it. If we have to
> change what we want our code to look like for PMD to be happy, then that
> is a very bad thing IMO.
>
> - Dan
>
> Glynn, Eoghan wrote:
> >PMD often reports false positives for its unused private method rule -
> >I've seen this happen if the method signature is templated, has multiple
> >overrides, or is defined after its called.
> >
> >Its really annoying to say the least. Sometimes the spurious warning can
> >be made go away by re-ordering the code slightly, other-times it simpler
> >to just work-around the issue by changing the access modifier to
> >protected.
> >
> >Since the rule enforcement logic seems broken in PMD, I'd just as soon
> >disbale the rule. However I've seen too much time burned in religious
> >wars about code style, and the automated checking thereof, to bother
> >bringing this up ... ;)
> >
> >/Eoghan
> >
> >>-----Original Message-----
> >>From: Dan Diephouse [mailto:dan@envoisolutions.com]
> >>Sent: 25 September 2006 03:58
> >>To: cxf-dev@incubator.apache.org
> >>Cc: cxf-commits@incubator.apache.org
> >>Subject: Re: svn commit: r449549 -
> >>/incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apach
> >>e/cxf/jaxws/support/JaxWsServiceFactoryBean.java
> >>
> >>Thanks - but can you explain why that fixes the pmd
> >>complaint? Are private methods not allowed? That seems silly :-)
> >>
> >>- Dan
> >>
> >>ningjiang@apache.org wrote:
> >>>Author: ningjiang
> >>>Date: Sun Sep 24 19:38:12 2006
> >>>New Revision: 449549
> >>>
> >>>URL: http://svn.apache.org/viewvc?view=rev&rev=449549
> >>>Log:
> >>>fixed the pmd error for intializeWrapping
> >>>
> >>>Modified:
> >>
> >>incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jax
> >>
> >>>ws/support/JaxWsServiceFactoryBean.java
> >>>
> >>>Modified:
> >>
> >>incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jax
> >>
> >>>ws/support/JaxWsServiceFactoryBean.java
> >>>URL:
> >>
> >>http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/jaxws/src
> >>
> >>
> >>/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java?v
> >>
> >>>iew=diff&rev=449549&r1=449548&r2=449549
> >>
> >>======================================================================
> >>
> >>>========
> >>>---
> >>
> >>incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jax
> >>
> >>>ws/support/JaxWsServiceFactoryBean.java (original)
> >>>+++
> >>
> >>incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf
> >>
> >>>+++ /jaxws/support/JaxWsServiceFactoryBean.java Sun Sep 24 19:38:12
> >>>+++ 2006
> >>>@@ -154,7 +154,7 @@
> >>>         initalizeClassInfo(o, method);
> >>>     }
> >>>
> >>>-    private void intializeWrapping(OperationInfo o, Method
> >>
> >>selected) {
> >>
> >>>+    void intializeWrapping(OperationInfo o, Method selected) {
> >>>         Class responseWrapper = getResponseWrapper(selected);
> >>>         if (responseWrapper != null) {
> >>
> >>o.getUnwrappedOperation().getOutput().setProperty(WrapperClassOutInter
> >>
> >>>ceptor.WRAPPER_CLASS,
> >>
> >>--
> >>Dan Diephouse
> >>Envoi Solutions
> >>http://envoisolutions.com
> >>http://netzooid.com/blog

-- 
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727    C: 508-380-7194   F:781-902-8001
daniel.kulp@iona.com

Mime
View raw message