Mailing-List: contact user-help@curator.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@curator.incubator.apache.org
Received-SPF: error (nike.apache.org: local policy)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\))
Subject: Re: LeaderSelector Executor
From: Jordan Zimmerman <jordan@jordanzimmerman.com>
In-Reply-To: 
 <CAH3vNzPSd9J1KNZnh9iL=A3Gt5nTcfbEyN8n=fqcwK3KL_hgNg@mail.gmail.com>
Date: Wed, 28 Aug 2013 09:32:29 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <04EDE5F0-880B-41A9-A0AE-A9182A794B6E@jordanzimmerman.com>
References: 
 <CAH3vNzPSd9J1KNZnh9iL=A3Gt5nTcfbEyN8n=fqcwK3KL_hgNg@mail.gmail.com>
To: user@curator.incubator.apache.org

This looks very broken to me. Please open an issue for this.

-Jordan

On Aug 28, 2013, at 7:44 AM, Henrik Nordvik <henrikno@gmail.com> wrote:

> Hi,
>=20
> The LeaderSelector has a constructor which takes in ThreadFactory and =
Executor as parameters. The "default" constructor uses =
MoreExecutors.sameThreadExecutor().
> I tried using my own ThreadPool with multiple threads, because I =
thought that was they way of using multiple leaders.=20
> When I did that, to my surprise, it started multiple leaders per path. =
After reading the code it makes sense, it only guarantees that you are =
the leader when submitting the thread to the executor.
>=20
> It seems to me like using anything other than sameThreadExecutor makes =
little sense.
> When would you want to use it?
>=20
>=20
> Example snippet:
>     LeaderSelectorListener listener =3D new =
MyLeaderSelectorListener("1");
>     ExecutorService executorPool =3D Executors.newFixedThreadPool(20);
>     LeaderSelector leaderSelector =3D new LeaderSelector(client, path, =
threadFactory, executorPool, listener);
>     leaderSelector.autoRequeue();
>     leaderSelector.start();
>     // MyLeaderSelectorListener.takeLeadership is called multiple =
times here, even though it is in a sleep-loop.
>=20
>=20
> --
> Henrik Nordvik