From dev-return-10410-archive-asf-public=cust-asf.ponee.io@curator.apache.org Thu Aug 8 23:22:48 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 94368180642 for ; Fri, 9 Aug 2019 01:22:48 +0200 (CEST) Received: (qmail 50381 invoked by uid 500); 8 Aug 2019 23:22:47 -0000 Mailing-List: contact dev-help@curator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@curator.apache.org Delivered-To: mailing list dev@curator.apache.org Received: (qmail 50370 invoked by uid 99); 8 Aug 2019 23:22:47 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Aug 2019 23:22:47 +0000 From: GitBox To: dev@curator.apache.org Subject: [GitHub] [curator] Randgalt commented on a change in pull request #320: [CURATOR-533] - improve circuit breaking behavior Message-ID: <156530656768.16365.6380498720487402523.gitbox@gitbox.apache.org> Date: Thu, 08 Aug 2019 23:22:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Randgalt commented on a change in pull request #320: [CURATOR-533] - improve circuit breaking behavior URL: https://github.com/apache/curator/pull/320#discussion_r312281525 ########## File path: curator-framework/src/main/java/org/apache/curator/framework/state/ConnectionStateListener.java ########## @@ -31,14 +31,14 @@ void stateChanged(CuratorFramework client, ConnectionState newState); /** - * Normally, ConnectionStateListeners are decorated via the configured - * {@link org.apache.curator.framework.state.ConnectionStateListenerDecorator}. For certain - * critical cases, however, this is not desired. If your listener returns true - * for doNotDecorate(), it will not be passed through the decorator. + * ConnectionStateListener managers set via {@link org.apache.curator.framework.CuratorFrameworkFactory.Builder#connectionStateListenerManagerFactory(ConnectionStateListenerManagerFactory)} + * are allowed to proxy (etc.) ConnectionStateListeners as needed. If this method returns true + * the ConnectionStateListener manager must not proxy the listener as it's a vital internal + * listener used by Curator. * * @return true/false */ - default boolean doNotDecorate() + default boolean doNotProxy() Review comment: It’s not specific to circuit breaking. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services