curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (CURATOR-533) Improve CURATOR-505 by making the CircuitBreaker instance shared
Date Sun, 28 Jul 2019 16:47:00 GMT

     [ https://issues.apache.org/jira/browse/CURATOR-533?focusedWorklogId=283902&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-283902
]

ASF GitHub Bot logged work on CURATOR-533:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Jul/19 16:46
            Start Date: 28/Jul/19 16:46
    Worklog Time Spent: 10m 
      Work Description: Randgalt commented on pull request #320: [CURATOR-533] - introduced
circuit breaking behavior
URL: https://github.com/apache/curator/pull/320
 
 
   CURATOR-505 introduced circuit breaking behavior via CircuitBreakingConnectionStateListener
and ConnectionStateListenerDecorator. Elastic has been using it to success but reports that
the implementation can be improved. The existing implementation uses a new CircuitBreaker
for each ConnectionStateListener set in a Curator client. It turns out that this is not ideal.
Instead, a shared CircuitBreaker should be used per Curator client.
   
   Unfortunately, the best way to do this is to remove the ConnectionStateListenerDecorator
semantics and use a different mechanism. This Issue proposes to do this and remove ConnectionStateListenerDecorator.
This is a breaking change but given the short amount of time it's been in Curator it's unlikely
that it's been widely adopted.
   
   In this commit, ConnectionStateListenerDecorator is removed in favor of ConnectionStateListenerManagerFactory.
ConnectionStateManager uses this factory to create the container to hold registered ConnectionStateListeners.
A new CircuitBreakerManager now manages the circuit breaking behavior using a shared CircuitBreaker.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 283902)
            Time Spent: 10m
    Remaining Estimate: 0h

> Improve CURATOR-505 by making the CircuitBreaker instance shared
> ----------------------------------------------------------------
>
>                 Key: CURATOR-533
>                 URL: https://issues.apache.org/jira/browse/CURATOR-533
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Framework, Recipes
>    Affects Versions: 4.2.0
>            Reporter: Jordan Zimmerman
>            Assignee: Jordan Zimmerman
>            Priority: Major
>             Fix For: 4.2.1
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> CURATOR-505 introduced circuit breaking behavior via {{CircuitBreakingConnectionStateListener}}
and {{ConnectionStateListenerDecorator}}. Elastic has been using it to success but reports
that the implementation can be improved. The existing implementation uses a new {{CircuitBreaker}}
for each {{ConnectionStateListener}} set in a Curator client. It turns out that this is not
ideal. Instead, a shared {{CircuitBreaker}} should be used per Curator client.
> Unfortunately, the best way to do this is to remove the {{ConnectionStateListenerDecorator}}
semantics and use a different mechanism. This Issue proposes to do this and remove {{ConnectionStateListenerDecorator}}.
This is a breaking change but given the short amount of time it's been in Curator it's unlikely
that it's been widely adopted. 
> If the community considers a breaking change too harsh the older classes can be maintained
for a while and marked as {{@Deprecated}}.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Mime
View raw message