From dev-return-10221-archive-asf-public=cust-asf.ponee.io@curator.apache.org Wed May 22 15:04:26 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 60DAD180651 for ; Wed, 22 May 2019 17:04:26 +0200 (CEST) Received: (qmail 48235 invoked by uid 500); 22 May 2019 15:04:25 -0000 Mailing-List: contact dev-help@curator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@curator.apache.org Delivered-To: mailing list dev@curator.apache.org Received: (qmail 48224 invoked by uid 99); 22 May 2019 15:04:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 May 2019 15:04:25 +0000 From: GitBox To: dev@curator.apache.org Subject: [GitHub] [curator] pacomendes opened a new pull request #312: Compilation on jdk11 for release 8 Message-ID: <155853746536.7235.4050775342900507317.gitbox@gitbox.apache.org> Date: Wed, 22 May 2019 15:04:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit pacomendes opened a new pull request #312: Compilation on jdk11 for release 8 URL: https://github.com/apache/curator/pull/312 Hi, we're migrating to JDK11 and came across this potential issue. I see from the manifest that 4.2.0 is built on jdk11: ``` Build-Jdk: 11.0.2 Built-By: jordanzimmerman ``` Changes to covariant return types for `ByteBuffer` in JDK11 may cause a `java.lang.NoSuchMethodError` when running on JDK 8. Which may impact these calls: https://github.com/apache/curator/blob/master/curator-framework/src/main/java/org/apache/curator/framework/imps/GzipCompressionProvider.java#L307-L319 This can be mitigated by setting the `--release` to 8. Although I see that .travis.yml is still using `oraclejdk8` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services