curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [curator] pacomendes opened a new pull request #312: Compilation on jdk11 for release 8
Date Wed, 22 May 2019 15:04:25 GMT
pacomendes opened a new pull request #312: Compilation on jdk11 for release 8
URL: https://github.com/apache/curator/pull/312
 
 
   Hi, we're migrating to JDK11 and came across this potential issue.
   
   I see from the manifest that 4.2.0 is built on jdk11:
   ```
   Build-Jdk: 11.0.2
   Built-By: jordanzimmerman
   ```
   
   Changes to covariant return types for `ByteBuffer` in JDK11 may cause a `java.lang.NoSuchMethodError`
when running on JDK 8. Which may impact these calls:
   
   https://github.com/apache/curator/blob/master/curator-framework/src/main/java/org/apache/curator/framework/imps/GzipCompressionProvider.java#L307-L319
   
   This can be mitigated by setting the `--release` to 8. Although I see that .travis.yml
is still using `oraclejdk8`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message