curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (CURATOR-499) ZKPaths strips trailing "/" incorrectly when creating sequential nodes
Date Thu, 07 Feb 2019 21:20:00 GMT

     [ https://issues.apache.org/jira/browse/CURATOR-499?focusedWorklogId=195950&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-195950
]

ASF GitHub Bot logged work on CURATOR-499:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Feb/19 21:19
            Start Date: 07/Feb/19 21:19
    Worklog Time Spent: 10m 
      Work Description: Randgalt commented on issue #300: CURATOR-499 Allow creating sequential
nodes with an empty name
URL: https://github.com/apache/curator/pull/300#issuecomment-459205238
 
 
   I'm +1 on this change but do you mind writing more tests in `TestZKPaths`? I'd like to
see more complete coverage of the new methods.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 195950)
    Time Spent: 20m  (was: 10m)

> ZKPaths strips trailing "/" incorrectly when creating sequential nodes
> ----------------------------------------------------------------------
>
>                 Key: CURATOR-499
>                 URL: https://issues.apache.org/jira/browse/CURATOR-499
>             Project: Apache Curator
>          Issue Type: Bug
>            Reporter: Marquis Wang
>            Assignee: Jordan Zimmerman
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> I think this was introduced in CURATOR-166, which changed ZKPaths to strip trailing slashes
from child nodes.
> This is fine in most cases: it made it so 
> {code:java}
> curatorFramework.create()
>     .forPath("/path/to/node/", data);{code}
> would create a node at {{/path/to/node}}.
> However, if you want to create a sequential node:
> {code:java}
> curatorFramework.create()
>     .withMode(CreateMode.PERSISTENT_SEQUENTIAL)
>     .forPath("/path/to/node/", data);{code}
> In clients after CURATOR-166 (2.7.1 and higher), this will create a node {{/path/to/node00000001}}.
Before, and if you call the zookeeper cli with the same options, it would create a node {{/path/to/node/00000001}}.
> This effectively makes it so you cannot use curator to create sequential nodes where
the entire node name is the sequence number.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message