curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-483) Sequential PersistentNodes with protection don't resync after reconnection
Date Tue, 13 Nov 2018 21:25:00 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685752#comment-16685752
] 

ASF GitHub Bot commented on CURATOR-483:
----------------------------------------

Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/281#discussion_r233227009
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java
---
    @@ -445,7 +445,8 @@ private void createNode()
             try
             {
                 String existingPath = nodePath.get();
    -            String createPath = (existingPath != null && !useProtection) ? existingPath
: basePath;
    +            String createPath = existingPath == null || (useProtection && !isSequential(mode))
? basePath
    +                    : (useProtection ? basePath + existingPath.substring(existingPath.length()-10)
: existingPath);
    --- End diff --
    
    Thanks @Randgalt, I figured that there was a good place to put this, but couldn't remember
where it should be. @njhill can you refactor the sequential number extraction into org.apache.curator.utils.ZKPaths
class? Or, if you don't have time, let me know and I'll get it done.


> Sequential PersistentNodes with protection don't resync after reconnection
> --------------------------------------------------------------------------
>
>                 Key: CURATOR-483
>                 URL: https://issues.apache.org/jira/browse/CURATOR-483
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Recipes
>    Affects Versions: 4.0.1
>            Reporter: Nick Hill
>            Priority: Major
>
> When using a {{PersistentNode}} with a sequential creation mode (in my case ephemeral
but I think persistent would be the same) and "protection" turned on, unexpected duplicate
znodes get created upon reconnection after a disconnect (without the sequence suffix), rather
than it just taking ownership of the previously created znode.
> I tracked down the cause of this and have made a simple fix.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message