curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From njhill <...@git.apache.org>
Subject [GitHub] curator pull request #281: [CURATOR-483] Fix path used when re-creating sequ...
Date Wed, 07 Nov 2018 01:38:04 GMT
Github user njhill commented on a diff in the pull request:

    https://github.com/apache/curator/pull/281#discussion_r231356314
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java
---
    @@ -445,7 +445,8 @@ private void createNode()
             try
             {
                 String existingPath = nodePath.get();
    -            String createPath = (existingPath != null && !useProtection) ? existingPath
: basePath;
    +            String createPath = existingPath == null || (useProtection && !isSequential(mode))
? basePath
    +                    : (useProtection ? basePath + existingPath.substring(existingPath.length()-10)
: existingPath);
    --- End diff --
    
    Thanks @cammckenzie. I reworked this to use if statements and defined a constant for the
10 number. I couldn't find such a constant defined elsewhere; it's hardcoded in the zookeeper
code: https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java#L662.
    
    I also removed the redundant added static `isSequential(CreateMode)` method, didn't notice
that this is already a method on the enum.


---

Mime
View raw message