From dev-return-9362-archive-asf-public=cust-asf.ponee.io@curator.apache.org Wed Oct 24 04:31:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D404A18066B for ; Wed, 24 Oct 2018 04:31:03 +0200 (CEST) Received: (qmail 9996 invoked by uid 500); 24 Oct 2018 02:31:02 -0000 Mailing-List: contact dev-help@curator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@curator.apache.org Delivered-To: mailing list dev@curator.apache.org Received: (qmail 9985 invoked by uid 99); 24 Oct 2018 02:31:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Oct 2018 02:31:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 60E9BC21D4 for ; Wed, 24 Oct 2018 02:31:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id AzQc11qxHSlP for ; Wed, 24 Oct 2018 02:31:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 379645F17E for ; Wed, 24 Oct 2018 02:31:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7BA58E0F39 for ; Wed, 24 Oct 2018 02:31:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1963C252B1 for ; Wed, 24 Oct 2018 02:31:00 +0000 (UTC) Date: Wed, 24 Oct 2018 02:31:00 +0000 (UTC) From: "Akira Ajisaka (JIRA)" To: dev@curator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CURATOR-409) TestingQuorumPeerMain does not work with Zookeeper 3.5.3-beta MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CURATOR-409?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D166= 61622#comment-16661622 ]=20 Akira Ajisaka commented on CURATOR-409: --------------------------------------- Is there any chance to backport this to 2.x and 3.x? Apache Hadoop is using Curator 2.12.0 and upgraded ZooKeeper from 3.4.8 to = 3.14.13. And then, hit this issue (tracked by YARN-8937). > TestingQuorumPeerMain does not work with Zookeeper 3.5.3-beta > ------------------------------------------------------------- > > Key: CURATOR-409 > URL: https://issues.apache.org/jira/browse/CURATOR-409 > Project: Apache Curator > Issue Type: Bug > Components: Tests > Affects Versions: 3.3.0 > Reporter: Stig Rohde D=C3=B8ssing > Priority: Major > Fix For: 4.0.0 > > > Zookeeper 3.5.3 has added a getQuorumPeer method to QuorumPeerMain https:= //github.com/apache/zookeeper/blob/release-3.5.3/src/java/main/org/apache/z= ookeeper/server/quorum/QuorumPeerMain.java#L194. TestingQuorumPeerMain has = an identically named method, which is now unintentionally overridding the o= ne in the base class. > This causes TestingCluster to be unusable. > {code} > 20:36:41.199 [Thread-1] ERROR org.apache.curator.test.TestingZooKeeperSer= ver - From testing server (random state: false) for instance: InstanceSpec{= dataDirectory=3DC:\Users\Esran\AppData\Local\Temp\1494009401090-0, port=3D6= 5306, electionPort=3D65307, quorumPort=3D65308, deleteDataDirectoryOnClose= =3Dtrue, serverId=3D1, tickTime=3D-1, maxClientCnxns=3D-1, customProperties= =3D{}, hostname=3D127.0.0.1} org.apache.curator.test.InstanceSpec@59c4b497 > java.lang.NullPointerException: null > =09at org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(Quo= rumPeerMain.java:158) ~[zookeeper-3.5.3-beta.jar:3.5.3-beta-8ce24f9e675cbef= ffb8f21a47e06b42864475a60] > =09at org.apache.curator.test.TestingZooKeeperServer$1.run(TestingZooKeep= erServer.java:150) [curator-test-3.3.0.jar:3.3.0] > =09at java.lang.Thread.run(Thread.java:745) [?:1.8.0_73] > {code} > The method in TestingQuorumPeerMain should be renamed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)