From dev-return-9339-archive-asf-public=cust-asf.ponee.io@curator.apache.org  Sun Sep 23 18:12:24 2018
Return-Path: <dev-return-9339-archive-asf-public=cust-asf.ponee.io@curator.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id BBD64180658
	for <archive-asf-public@cust-asf.ponee.io>; Sun, 23 Sep 2018 18:12:23 +0200 (CEST)
Received: (qmail 24700 invoked by uid 500); 23 Sep 2018 16:12:22 -0000
Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@curator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@curator.apache.org>
List-Post: <mailto:dev@curator.apache.org>
List-Id: <dev.curator.apache.org>
Reply-To: dev@curator.apache.org
Delivered-To: mailing list dev@curator.apache.org
Received: (qmail 24689 invoked by uid 99); 23 Sep 2018 16:12:22 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Sep 2018 16:12:22 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id B9426DFF92; Sun, 23 Sep 2018 16:12:21 +0000 (UTC)
From: dragonsinth <git@git.apache.org>
To: dev@curator.apache.org
Reply-To: dev@curator.apache.org
References: <git-pr-278-curator@git.apache.org>
In-Reply-To: <git-pr-278-curator@git.apache.org>
Subject: [GitHub] curator pull request #278: [CURATOR-477] added support for turning off zk wa...
Content-Type: text/plain
Message-Id: <20180923161221.B9426DFF92@git1-us-west.apache.org>
Date: Sun, 23 Sep 2018 16:12:21 +0000 (UTC)

Github user dragonsinth commented on a diff in the pull request:

    https://github.com/apache/curator/pull/278#discussion_r219703563
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/TreeCache.java ---
    @@ -263,15 +284,31 @@ private void doRefreshData() throws Exception
                 {
                     if ( dataIsCompressed )
                     {
    -                    client.getData().decompressed().usingWatcher(this).inBackground(this).forPath(path);
    +                    maybeWatch(client.getData().decompressed()).forPath(path);
                     }
                     else
                     {
    -                    client.getData().usingWatcher(this).inBackground(this).forPath(path);
    +                    maybeWatch(client.getData()).forPath(path);
                     }
                 }
             }
     
    +        private ErrorListenerPathable<byte[]> maybeWatch(GetDataWatchBackgroundStatable dataBuilder) {
    +            if (disableZkWatches) {
    +                return dataBuilder.inBackground(this);
    +            } else {
    +                return dataBuilder.usingWatcher(this).inBackground(this);
    +            }
    +        }
    +
    +        private ErrorListenerPathable<byte[]> maybeWatch(GetDataBuilder dataBuilder) {
    +            if (disableZkWatches) {
    +                return dataBuilder.inBackground(this);
    +            } else {
    +                return dataBuilder.usingWatcher(this).inBackground(this);
    +            }
    +        }
    +
    --- End diff --
    
    ```java
            private void doRefreshChildren() throws Exception
            {
                if ( treeState.get() == TreeState.STARTED )
                {
                    maybeWatch(client.getChildren()).forPath(path);
                }
            }
    
            private void doRefreshData() throws Exception
            {
                if ( treeState.get() == TreeState.STARTED )
                {
                    if ( dataIsCompressed )
                    {
                        maybeWatch(client.getData().decompressed()).forPath(path);
                    }
                    else
                    {
                        maybeWatch(client.getData()).forPath(path);
                    }
                }
            }
    
            private <T, P extends Watchable<BackgroundPathable<T>> & BackgroundPathable<T>> Pathable<T> maybeWatch(P dataBuilder)
            {
                if ( disableZkWatches )
                {
                    return dataBuilder.inBackground(this);
                }
                else
                {
                    return dataBuilder.usingWatcher(this).inBackground(this);
                }
            }
    ```


---