curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cameron McKenzie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-472) Test-only code started to be called in prod
Date Mon, 30 Jul 2018 00:56:00 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561318#comment-16561318
] 

Cameron McKenzie commented on CURATOR-472:
------------------------------------------

Thanks, I would have thought that when the close() is called on ZK that closing the underlying
connection would cause the sendThread to wake up, but I haven't looked at the ZK code, so
can't confirm what they're sleeping on. Maybe there's a race condition on shutdown?

> Test-only code started to be called in prod
> -------------------------------------------
>
>                 Key: CURATOR-472
>                 URL: https://issues.apache.org/jira/browse/CURATOR-472
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Client
>            Reporter: mskonovalov
>            Assignee: Cameron McKenzie
>            Priority: Critical
>
> After commit {{fe2c7c4cd606c0cf4bc4fab15deedc0f4c33ea0e}} the method
>  
> {code:java}
> protected boolean testableWaitForShutdown(int wait)
>     throws InterruptedException
> {code}
> with the following comment
>  
>  
> {code:java}
> * Wait up to wait milliseconds for the underlying threads to shutdown.
> * THIS METHOD IS EXPECTED TO BE USED FOR TESTING ONLY!!!
> {code}
> started to be called from real method {{ZooKeeper.close()}}
> It prevents tests to finish.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message